From: Christoph Lameter <clameter@sgi.com>
To: Aubrey Li <aubreylee@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
"linux-os (Dick Johnson)" <linux-os@analogic.com>,
Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Date: Fri, 19 Jan 2007 10:21:33 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701191014250.15317@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <6d6a94c50701171923g48c8652ayd281a10d1cb5dd95@mail.gmail.com>
On Thu, 18 Jan 2007, Aubrey Li wrote:
> +int sysctl_pagecache_ratio = 10;
> +
Pagecache ratio is the ratio of memory to be left over? Would it not be
better to twist this around and to be able to specify how much of the
memory of a node may be used by the pagecache?
Why limit the size of the pagecache? Some kind of rationale would be
useful. Maybe it was there in earlier incarnations of the patch that I did
not see? It should be kept with it.
zone_reclaim already dynamically limits the size of the pagecache.
> + if (alloc_flags & ALLOC_PAGECACHE)
> + min = min + (sysctl_pagecache_ratio * z->present_pages) / 100;
The calculation of the multiplication / division is usually not done in
the hot allocation path. See f.e. how min_unmapped_pages is handled in
mm/page_alloc.c
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <clameter@sgi.com>
To: Aubrey Li <aubreylee@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
"linux-os (Dick Johnson)" <linux-os@analogic.com>,
Robin Getz <rgetz@blackfin.uclinux.org>
Subject: Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Date: Fri, 19 Jan 2007 10:21:33 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0701191014250.15317@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <6d6a94c50701171923g48c8652ayd281a10d1cb5dd95@mail.gmail.com>
On Thu, 18 Jan 2007, Aubrey Li wrote:
> +int sysctl_pagecache_ratio = 10;
> +
Pagecache ratio is the ratio of memory to be left over? Would it not be
better to twist this around and to be able to specify how much of the
memory of a node may be used by the pagecache?
Why limit the size of the pagecache? Some kind of rationale would be
useful. Maybe it was there in earlier incarnations of the patch that I did
not see? It should be kept with it.
zone_reclaim already dynamically limits the size of the pagecache.
> + if (alloc_flags & ALLOC_PAGECACHE)
> + min = min + (sysctl_pagecache_ratio * z->present_pages) / 100;
The calculation of the multiplication / division is usually not done in
the hot allocation path. See f.e. how min_unmapped_pages is handled in
mm/page_alloc.c
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-19 18:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 3:23 [RPC][PATCH 2.6.20-rc5] limit total vfs page cache Aubrey Li
2007-01-18 3:23 ` Aubrey Li
2007-01-19 14:44 ` Vaidyanathan Srinivasan
2007-01-19 14:44 ` Vaidyanathan Srinivasan
2007-01-19 15:40 ` Aubrey Li
2007-01-19 15:40 ` Aubrey Li
2007-01-24 5:30 ` Vaidyanathan Srinivasan
2007-01-24 5:30 ` Vaidyanathan Srinivasan
2007-01-24 5:53 ` Aubrey Li
2007-01-24 5:53 ` Aubrey Li
2007-01-19 14:52 ` Vaidyanathan Srinivasan
2007-01-19 14:52 ` Vaidyanathan Srinivasan
2007-01-19 16:05 ` Aubrey Li
2007-01-19 16:05 ` Aubrey Li
2007-01-19 18:49 ` Vaidyanathan Srinivasan
2007-01-19 18:49 ` Vaidyanathan Srinivasan
2007-01-19 19:01 ` Christoph Lameter
2007-01-19 19:01 ` Christoph Lameter
2007-01-20 2:04 ` Aubrey Li
2007-01-20 2:04 ` Aubrey Li
2007-01-20 2:24 ` Nick Piggin
2007-01-20 2:24 ` Nick Piggin
2007-01-20 2:35 ` Mike Frysinger
2007-01-20 2:35 ` Mike Frysinger
2007-01-20 2:49 ` Nick Piggin
2007-01-20 2:49 ` Nick Piggin
2007-01-20 3:40 ` Mike Frysinger
2007-01-20 3:40 ` Mike Frysinger
2007-01-20 3:08 ` Aubrey Li
2007-01-20 3:08 ` Aubrey Li
2007-01-20 4:03 ` Nick Piggin
2007-01-20 4:03 ` Nick Piggin
2007-01-20 4:26 ` Aubrey Li
2007-01-20 4:26 ` Aubrey Li
2007-01-22 19:22 ` Christoph Lameter
2007-01-22 19:22 ` Christoph Lameter
2007-01-22 19:15 ` Christoph Lameter
2007-01-22 19:15 ` Christoph Lameter
2007-01-19 18:21 ` Christoph Lameter [this message]
2007-01-19 18:21 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701191014250.15317@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=aubreylee@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-os@analogic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rgetz@blackfin.uclinux.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.