From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> To: Arnd Bergmann <arnd@arndb.de> Cc: Simon Horman <horms@verge.net.au>, linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Markus Pargmann <mpa@pengutronix.de> Subject: Re: [PATCH v4 03/13] mmc: provide a standard MMC device-tree binding parser centrally Date: Sat, 16 Feb 2013 14:02:36 +0000 [thread overview] Message-ID: <Pine.LNX.4.64.1302161457140.20044@axis700.grange> (raw) In-Reply-To: <201302161054.36492.arnd@arndb.de> On Sat, 16 Feb 2013, Arnd Bergmann wrote: > On Saturday 16 February 2013, Simon Horman wrote: > > > +void mmc_of_parse(struct mmc_host *host) > > > +{ > > > + struct device_node *np; > > > + u32 bus_width; > > > + bool explicit_inv_wp, gpio_inv_wp = false; > > > + enum of_gpio_flags flags; > > > + int len, ret, gpio; > > > + > > > + if (!host->parent || !host->parent->of_node) > > > + return; > > > + > > > + np = host->parent->of_node; > > > + > > > + /* "bus-width" is translated to MMC_CAP_*_BIT_DATA flags */ > > > + if (of_property_read_u32_array(np, "bus-width", &bus_width, 1) < 0) > > > + dev_dbg(host->parent, > > > + "\"bus-width\" property is missing, assuming 1 bit.\n"); > > > + > > > + switch (bus_width) { > > > > kbuild tells me that gcc thinks that bus_width is used without being > > initialised here. Assuming that of_property_read_u32_array always > > initialises bus_width if it returns zero then perhaps it would be worth > > considering using uninitialized_var(). > > I think this is a false positive that I encountered before and that should be gone > with gcc-4.7 or higher when using -O2 instead of -Os. I have a patch to disable > -Wmaybe-uninitialized when builing with -Os. If that gets rid of the warning, > I'd prefer not annotating it here. Unfortunately, this does seem to be a real bug, I lost the default initialisation to one somewhere along the way... I'll send a trivial update. Stupidly, my cross-toolchain doesn't report this error. Thanks Guennadi > There was some discussion about removing uninitialized_var() recently after it > was found to hide some real bugs. > > Arnd --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de> To: Arnd Bergmann <arnd@arndb.de> Cc: Simon Horman <horms@verge.net.au>, linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>, Markus Pargmann <mpa@pengutronix.de> Subject: Re: [PATCH v4 03/13] mmc: provide a standard MMC device-tree binding parser centrally Date: Sat, 16 Feb 2013 15:02:36 +0100 (CET) [thread overview] Message-ID: <Pine.LNX.4.64.1302161457140.20044@axis700.grange> (raw) In-Reply-To: <201302161054.36492.arnd@arndb.de> On Sat, 16 Feb 2013, Arnd Bergmann wrote: > On Saturday 16 February 2013, Simon Horman wrote: > > > +void mmc_of_parse(struct mmc_host *host) > > > +{ > > > + struct device_node *np; > > > + u32 bus_width; > > > + bool explicit_inv_wp, gpio_inv_wp = false; > > > + enum of_gpio_flags flags; > > > + int len, ret, gpio; > > > + > > > + if (!host->parent || !host->parent->of_node) > > > + return; > > > + > > > + np = host->parent->of_node; > > > + > > > + /* "bus-width" is translated to MMC_CAP_*_BIT_DATA flags */ > > > + if (of_property_read_u32_array(np, "bus-width", &bus_width, 1) < 0) > > > + dev_dbg(host->parent, > > > + "\"bus-width\" property is missing, assuming 1 bit.\n"); > > > + > > > + switch (bus_width) { > > > > kbuild tells me that gcc thinks that bus_width is used without being > > initialised here. Assuming that of_property_read_u32_array always > > initialises bus_width if it returns zero then perhaps it would be worth > > considering using uninitialized_var(). > > I think this is a false positive that I encountered before and that should be gone > with gcc-4.7 or higher when using -O2 instead of -Os. I have a patch to disable > -Wmaybe-uninitialized when builing with -Os. If that gets rid of the warning, > I'd prefer not annotating it here. Unfortunately, this does seem to be a real bug, I lost the default initialisation to one somewhere along the way... I'll send a trivial update. Stupidly, my cross-toolchain doesn't report this error. Thanks Guennadi > There was some discussion about removing uninitialized_var() recently after it > was found to hide some real bugs. > > Arnd --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/
next prev parent reply other threads:[~2013-02-16 14:02 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-15 15:13 [PATCH v4 00/13] mmc: core and driver DT and related development Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 01/13] mmc: sdhi, tmio: only check flags in tmio-mmc driver proper Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 02/13] mmc: detailed definition of CD and WP MMC line polarities in DT Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 03/13] mmc: provide a standard MMC device-tree binding parser centrally Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-16 6:05 ` Simon Horman 2013-02-16 6:05 ` Simon Horman 2013-02-16 10:54 ` Arnd Bergmann 2013-02-16 11:41 ` Simon Horman 2013-02-16 11:41 ` Simon Horman 2013-02-16 14:02 ` Guennadi Liakhovetski [this message] 2013-02-16 14:02 ` Guennadi Liakhovetski 2013-02-16 15:21 ` [PATCH v5 " Guennadi Liakhovetski 2013-02-16 15:21 ` Guennadi Liakhovetski 2013-02-16 16:58 ` Sascha Hauer 2013-02-16 16:58 ` Sascha Hauer 2013-02-17 7:52 ` Simon Horman 2013-02-17 7:52 ` Simon Horman 2013-02-17 7:58 ` Simon Horman 2013-02-17 7:58 ` Simon Horman 2013-02-18 8:54 ` Guennadi Liakhovetski 2013-02-18 8:54 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 04/13] mmc: (cosmetic) remove "extern" from function declarations Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 05/13] mmc: sh-mmcif: use mmc_of_parse() to parse standard MMC DT bindings Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 06/13] mmc: tmio-mmc: define device-tree bindings Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 07/13] mmc: tmio-mmc: parse " Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 08/13] mmc: sh_mobile_sdhi: remove unused .pdata field Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 09/13] mmc: sh_mobile_sdhi: use managed resource allocations Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:13 ` [PATCH v4 10/13] mmc: tmio: remove unused and deprecated symbols Guennadi Liakhovetski 2013-02-15 15:13 ` Guennadi Liakhovetski 2013-02-15 15:14 ` [PATCH v4 11/13] mmc: tmio: add support for the VccQ regulator Guennadi Liakhovetski 2013-02-15 15:14 ` Guennadi Liakhovetski 2013-02-15 15:14 ` [PATCH v4 12/13] mmc: add DT bindings for more MMC capability flags Guennadi Liakhovetski 2013-02-15 15:14 ` Guennadi Liakhovetski 2013-02-16 22:58 ` Sergei Shtylyov 2013-02-16 23:58 ` Sergei Shtylyov [not found] ` <51201D32.20006-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2013-02-18 8:52 ` Guennadi Liakhovetski 2013-02-18 8:52 ` Guennadi Liakhovetski 2013-06-06 1:55 ` Olof Johansson 2013-06-06 1:55 ` Olof Johansson 2013-02-15 15:14 ` [PATCH v4 13/13] mmc: tmio: add barriers to IO operations Guennadi Liakhovetski 2013-02-15 15:14 ` Guennadi Liakhovetski 2013-02-18 15:05 ` Arnd Bergmann 2013-02-18 15:56 ` Guennadi Liakhovetski 2013-02-18 15:56 ` Guennadi Liakhovetski 2013-02-18 16:34 ` Arnd Bergmann 2013-02-18 17:20 ` Guennadi Liakhovetski 2013-02-18 17:20 ` Guennadi Liakhovetski 2013-02-18 22:11 ` Arnd Bergmann [not found] ` <201302182211.46697.arnd-r2nGTMty4D4@public.gmane.org> 2013-02-19 21:59 ` Guennadi Liakhovetski 2013-02-19 21:59 ` Guennadi Liakhovetski 2013-02-16 2:26 ` [PATCH v4 00/13] mmc: core and driver DT and related development Simon Horman 2013-02-16 2:26 ` Simon Horman 2013-02-18 13:15 ` Chris Ball 2013-02-18 13:15 ` Chris Ball 2013-02-19 21:57 ` Guennadi Liakhovetski 2013-02-19 21:57 ` Guennadi Liakhovetski 2013-02-19 22:00 ` Chris Ball 2013-02-19 22:00 ` Chris Ball 2013-02-18 14:52 ` Arnd Bergmann 2013-02-19 19:20 ` Stephen Warren 2013-02-19 19:20 ` Stephen Warren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Pine.LNX.4.64.1302161457140.20044@axis700.grange \ --to=g.liakhovetski@gmx.de \ --cc=arnd@arndb.de \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=horms@verge.net.au \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mpa@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.