* [PATCH] net: dpaa2: build ptp clock driver in default
@ 2019-01-14 9:44 Yangbo Lu
2019-01-18 1:25 ` Richard Cochran
0 siblings, 1 reply; 4+ messages in thread
From: Yangbo Lu @ 2019-01-14 9:44 UTC (permalink / raw)
To: netdev, David S . Miller, Richard Cochran, Ioana Radulescu; +Cc: Yangbo Lu
This patch is to set "default y" for dpaa2 ptp driver building.
It will provide user an available ptp clock in default.
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
index 809a155..15351fc 100644
--- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
+++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
@@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK
tristate "Freescale DPAA2 PTP Clock"
depends on FSL_DPAA2_ETH && POSIX_TIMERS
select PTP_1588_CLOCK
+ default y
help
This driver adds support for using the DPAA2 1588 timer module
as a PTP clock.
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dpaa2: build ptp clock driver in default
2019-01-14 9:44 [PATCH] net: dpaa2: build ptp clock driver in default Yangbo Lu
@ 2019-01-18 1:25 ` Richard Cochran
2019-01-18 7:18 ` Y.b. Lu
0 siblings, 1 reply; 4+ messages in thread
From: Richard Cochran @ 2019-01-18 1:25 UTC (permalink / raw)
To: Yangbo Lu; +Cc: netdev, David S . Miller, Ioana Radulescu
On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote:
> This patch is to set "default y" for dpaa2 ptp driver building.
> It will provide user an available ptp clock in default.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> index 809a155..15351fc 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
> +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK
> tristate "Freescale DPAA2 PTP Clock"
> depends on FSL_DPAA2_ETH && POSIX_TIMERS
> select PTP_1588_CLOCK
We want to use "imply" instead of "select" here.
> + default y
I'm okay with the defaulting to yes.
Thanks,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] net: dpaa2: build ptp clock driver in default
2019-01-18 1:25 ` Richard Cochran
@ 2019-01-18 7:18 ` Y.b. Lu
2019-01-18 20:14 ` Richard Cochran
0 siblings, 1 reply; 4+ messages in thread
From: Y.b. Lu @ 2019-01-18 7:18 UTC (permalink / raw)
To: Richard Cochran; +Cc: netdev, David S . Miller, Ioana Ciocoi Radulescu
Hi Richard,
> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Friday, January 18, 2019 9:26 AM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; Ioana
> Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Subject: Re: [PATCH] net: dpaa2: build ptp clock driver in default
>
> On Mon, Jan 14, 2019 at 05:44:23PM +0800, Yangbo Lu wrote:
> > This patch is to set "default y" for dpaa2 ptp driver building.
> > It will provide user an available ptp clock in default.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > ---
> > drivers/net/ethernet/freescale/dpaa2/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/freescale/dpaa2/Kconfig
> b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > index 809a155..15351fc 100644
> > --- a/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > +++ b/drivers/net/ethernet/freescale/dpaa2/Kconfig
> > @@ -11,6 +11,7 @@ config FSL_DPAA2_PTP_CLOCK
> > tristate "Freescale DPAA2 PTP Clock"
> > depends on FSL_DPAA2_ETH && POSIX_TIMERS
> > select PTP_1588_CLOCK
>
> We want to use "imply" instead of "select" here.
[Y.b. Lu] Just learned the "imply" from the doc. I have a query here.
Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work.
Doesn't it matter?
Thanks.
>
> > + default y
>
> I'm okay with the defaulting to yes.
>
> Thanks,
> Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: dpaa2: build ptp clock driver in default
2019-01-18 7:18 ` Y.b. Lu
@ 2019-01-18 20:14 ` Richard Cochran
0 siblings, 0 replies; 4+ messages in thread
From: Richard Cochran @ 2019-01-18 20:14 UTC (permalink / raw)
To: Y.b. Lu; +Cc: netdev, David S . Miller, Ioana Ciocoi Radulescu
On Fri, Jan 18, 2019 at 07:18:32AM +0000, Y.b. Lu wrote:
> > We want to use "imply" instead of "select" here.
>
> [Y.b. Lu] Just learned the "imply" from the doc. I have a query here.
> Since this allows to configure PTP_1588_CLOCK out, the PHC APIs of FSL_DPAA2_PTP_CLOCK driver may not work.
> Doesn't it matter?
If PTP_1588_CLOCK is not compiled, then your driver should handle this
case:
* ptp_clock_register() - register a PTP hardware clock driver
* Returns a valid pointer on success or PTR_ERR on failure. If PHC
* support is missing at the configuration level, this function
* returns NULL, and drivers are expected to gracefully handle that
* case separately.
Thanks,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-18 20:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-14 9:44 [PATCH] net: dpaa2: build ptp clock driver in default Yangbo Lu
2019-01-18 1:25 ` Richard Cochran
2019-01-18 7:18 ` Y.b. Lu
2019-01-18 20:14 ` Richard Cochran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.