RE: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config

[Jun Li <jun.li@nxp.com>]

Hi
> -----Original Message-----
> From: kbuild test robot [mailto:lkp@intel.com]
> Sent: 2018年5月30日 12:26
> To: Jun Li <jun.li@nxp.com>
> Cc: kbuild-all@01.org; robh+dt@kernel.org; gregkh@linuxfoundation.org;
> heikki.krogerus@linux.intel.com; linux@roeck-us.net;
> cw00.choi@samsung.com; a.hajda@samsung.com; shufan_lee@richtek.com;
> Peter Chen <peter.chen@nxp.com>; garsilva@embeddedor.com;
> gsomlo@gmail.com; Jun Li <jun.li@nxp.com>; linux-usb@vger.kernel.org;
> devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power
> and data config
> 
> Hi Li,
> 
> Thank you for the patch! Yet something to improve:
> 
> [auto build test ERROR on usb/usb-testing] [also build test ERROR on v4.17-rc7
> next-20180529] [cannot apply to staging/staging-testing] [if your patch is
> applied to the wrong git tree, please drop us a note to help improve the
> system]
> 
> url:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithu
> b.com%2F0day-ci%2Flinux%2Fcommits%2FLi-Jun%2Fstaging-typec-tcpci-move-
> out-of-staging%2F20180530-110011&data=02%7C01%7Cjun.li%40nxp.com%7
> C56116c50269f48ac2af208d5c5e590b3%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C636632515483673101&sdata=0DFAYwcBjlLN1SmO%2BvCG
> s1YLoyjLCjlh89TTyHH1TFs%3D&reserved=0
> base:
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.ke
> rnel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fgregkh%2Fusb.git&data=
> 02%7C01%7Cjun.li%40nxp.com%7C56116c50269f48ac2af208d5c5e590b3%7C6
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636632515483673101&sd
> ata=OJnSzPSGMdKkV9w2wT8a7OjwKIME2g0VGmVxJerIhTc%3D&reserved=0
> usb-testing
> config: i386-randconfig-x017-201821 (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386
> 
> All error/warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/linkage.h:7:0,
>                     from include/linux/kernel.h:7,
>                     from include/linux/list.h:9,
>                     from include/linux/kobject.h:19,
>                     from include/linux/device.h:16,
>                     from drivers/usb/typec/class.c:9:
> >> drivers/usb/typec/class.c:1274:19: error: 'typec_find_power_type'
> undeclared here (not in a function); did you mean 'typec_find_power_role'?
>     EXPORT_SYMBOL_GPL(typec_find_power_type);
>                       ^
>    include/linux/export.h:65:16: note: in definition of macro
> '___EXPORT_SYMBOL'
>      extern typeof(sym) sym;      \
>                    ^~~
> >> drivers/usb/typec/class.c:1274:1: note: in expansion of macro
> 'EXPORT_SYMBOL_GPL'
>     EXPORT_SYMBOL_GPL(typec_find_power_type);
>     ^~~~~~~~~~~~~~~~~
> >> drivers/usb/typec/class.c:1288:19: error: 'typec_find_preferred_role'
> undeclared here (not in a function); did you mean 'typec_find_power_role'?
>     EXPORT_SYMBOL_GPL(typec_find_preferred_role);
>                       ^
>    include/linux/export.h:65:16: note: in definition of macro
> '___EXPORT_SYMBOL'
>      extern typeof(sym) sym;      \
>                    ^~~
>    drivers/usb/typec/class.c:1288:1: note: in expansion of macro
> 'EXPORT_SYMBOL_GPL'
>     EXPORT_SYMBOL_GPL(typec_find_preferred_role);
>     ^~~~~~~~~~~~~~~~~
> >> drivers/usb/typec/class.c:1303:19: error: 'typec_find_data_type' undeclared
> here (not in a function); did you mean 'typec_find_power_type'?
>     EXPORT_SYMBOL_GPL(typec_find_data_type);
>                       ^
>    include/linux/export.h:65:16: note: in definition of macro
> '___EXPORT_SYMBOL'
>      extern typeof(sym) sym;      \
>                    ^~~
>    drivers/usb/typec/class.c:1303:1: note: in expansion of macro
> 'EXPORT_SYMBOL_GPL'
>     EXPORT_SYMBOL_GPL(typec_find_data_type);
>     ^~~~~~~~~~~~~~~~~
> 
> vim +1274 drivers/usb/typec/class.c

Will fix all above 3 export symbol mismatch.

Li Jun
> 
>   1260
>   1261	/**
>   1262	 * typec_find_port_power_role - Get the typec port power capability
>   1263	 * @name: port power capability string
>   1264	 *
>   1265	 * This routine is used to find the typec_port_type by its string name.
>   1266	 *
>   1267	 * Returns typec_port_type if success, otherwise negative error
> code.
>   1268	 */
>   1269	int typec_find_port_power_role(const char *name)
>   1270	{
>   1271		return match_string(typec_port_types,
> ARRAY_SIZE(typec_port_types),
>   1272				    name);
>   1273	}
> > 1274	EXPORT_SYMBOL_GPL(typec_find_power_type);
>   1275
>   1276	/**
>   1277	 * typec_find_power_role - Find the typec one specific power role
>   1278	 * @name: power role string
>   1279	 *
>   1280	 * This routine is used to find the typec_role by its string name.
>   1281	 *
>   1282	 * Returns typec_role if success, otherwise negative error code.
>   1283	 */
>   1284	int typec_find_power_role(const char *name)
>   1285	{
>   1286		return match_string(typec_roles, ARRAY_SIZE(typec_roles),
> name);
>   1287	}
> > 1288	EXPORT_SYMBOL_GPL(typec_find_preferred_role);
>   1289
>   1290	/**
>   1291	 * typec_find_port_data_role - Get the typec port data capability
>   1292	 * @name: port data capability string
>   1293	 *
>   1294	 * This routine is used to find the typec_port_data by its string name.
>   1295	 *
>   1296	 * Returns typec_port_data if success, otherwise negative error
> code.
>   1297	 */
>   1298	int typec_find_port_data_role(const char *name)
>   1299	{
>   1300		return match_string(typec_data_caps,
> ARRAY_SIZE(typec_data_caps),
>   1301				    name);
>   1302	}
> > 1303	EXPORT_SYMBOL_GPL(typec_find_data_type);
>   1304
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology
> Center
> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.0
> 1.org%2Fpipermail%2Fkbuild-all&data=02%7C01%7Cjun.li%40nxp.com%7C561
> 16c50269f48ac2af208d5c5e590b3%7C686ea1d3bc2b4c6fa92cd99c5c301635%
> 7C0%7C0%7C636632515483673101&sdata=Dc5nz3r2TWU76saOKc03d2DBUe
> htMfokRBfKEbzFQ9s%3D&reserved=0                   Intel Corporation