From: Conor Dooley <conor@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Tom Joseph" <tjoseph@cadence.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Joyce Ooi" <joyce.ooi@intel.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes
Date: Tue, 25 Oct 2022 21:03:51 +0100 [thread overview]
Message-ID: <Y1hBJ+b4xmBRtrvF@spud> (raw)
In-Reply-To: <20221025185147.665365-1-helgaas@kernel.org>
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Many host controller drivers #include <linux/of_irq.h> even though they
> don't need it. Remove the unnecessary #includes.
>
> v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/
>
> Changes from v1 to v2:
> - Include <linux/irqdomain.h> explicitly in altera-msi and microchip,
> which don't need <linux/of_irq.h> itself, but relied on it to include
> <linux/irqdomain.h>
> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it
> and <linux/of_irq.h>
>
> Bjorn Helgaas (4):
> PCI: altera-msi: Include <linux/irqdomain.h> explicitly
> PCI: microchip: Include <linux/irqdomain.h> explicitly
> PCI: mvebu: Include <linux/irqdomain.h> explicitly
> PCI: Remove unnecessary <linux/of_irq.h> includes
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
Hey Bjorn, actually did the build this time rather than visually
inspecting... For the microchip bits:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Tom Joseph" <tjoseph@cadence.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Joyce Ooi" <joyce.ooi@intel.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes
Date: Tue, 25 Oct 2022 21:03:51 +0100 [thread overview]
Message-ID: <Y1hBJ+b4xmBRtrvF@spud> (raw)
In-Reply-To: <20221025185147.665365-1-helgaas@kernel.org>
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Many host controller drivers #include <linux/of_irq.h> even though they
> don't need it. Remove the unnecessary #includes.
>
> v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/
>
> Changes from v1 to v2:
> - Include <linux/irqdomain.h> explicitly in altera-msi and microchip,
> which don't need <linux/of_irq.h> itself, but relied on it to include
> <linux/irqdomain.h>
> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it
> and <linux/of_irq.h>
>
> Bjorn Helgaas (4):
> PCI: altera-msi: Include <linux/irqdomain.h> explicitly
> PCI: microchip: Include <linux/irqdomain.h> explicitly
> PCI: mvebu: Include <linux/irqdomain.h> explicitly
> PCI: Remove unnecessary <linux/of_irq.h> includes
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
Hey Bjorn, actually did the build this time rather than visually
inspecting... For the microchip bits:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Tom Joseph" <tjoseph@cadence.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Joyce Ooi" <joyce.ooi@intel.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes
Date: Tue, 25 Oct 2022 21:03:51 +0100 [thread overview]
Message-ID: <Y1hBJ+b4xmBRtrvF@spud> (raw)
In-Reply-To: <20221025185147.665365-1-helgaas@kernel.org>
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Many host controller drivers #include <linux/of_irq.h> even though they
> don't need it. Remove the unnecessary #includes.
>
> v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/
>
> Changes from v1 to v2:
> - Include <linux/irqdomain.h> explicitly in altera-msi and microchip,
> which don't need <linux/of_irq.h> itself, but relied on it to include
> <linux/irqdomain.h>
> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it
> and <linux/of_irq.h>
>
> Bjorn Helgaas (4):
> PCI: altera-msi: Include <linux/irqdomain.h> explicitly
> PCI: microchip: Include <linux/irqdomain.h> explicitly
> PCI: mvebu: Include <linux/irqdomain.h> explicitly
> PCI: Remove unnecessary <linux/of_irq.h> includes
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
Hey Bjorn, actually did the build this time rather than visually
inspecting... For the microchip bits:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>,
"Heiko Stuebner" <heiko@sntech.de>,
linux-pci@vger.kernel.org,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Toan Le" <toan@os.amperecomputing.com>,
linux-riscv@lists.infradead.org,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Joyce Ooi" <joyce.ooi@intel.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
linux-rockchip@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Ray Jui" <rjui@broadcom.com>,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
"Michal Simek" <michal.simek@amd.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
linux-kernel@vger.kernel.org, "Tom Joseph" <tjoseph@cadence.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes
Date: Tue, 25 Oct 2022 21:03:51 +0100 [thread overview]
Message-ID: <Y1hBJ+b4xmBRtrvF@spud> (raw)
In-Reply-To: <20221025185147.665365-1-helgaas@kernel.org>
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Many host controller drivers #include <linux/of_irq.h> even though they
> don't need it. Remove the unnecessary #includes.
>
> v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/
>
> Changes from v1 to v2:
> - Include <linux/irqdomain.h> explicitly in altera-msi and microchip,
> which don't need <linux/of_irq.h> itself, but relied on it to include
> <linux/irqdomain.h>
> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it
> and <linux/of_irq.h>
>
> Bjorn Helgaas (4):
> PCI: altera-msi: Include <linux/irqdomain.h> explicitly
> PCI: microchip: Include <linux/irqdomain.h> explicitly
> PCI: mvebu: Include <linux/irqdomain.h> explicitly
> PCI: Remove unnecessary <linux/of_irq.h> includes
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
Hey Bjorn, actually did the build this time rather than visually
inspecting... For the microchip bits:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Tom Joseph" <tjoseph@cadence.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Minghuan Lian" <minghuan.Lian@nxp.com>,
"Mingkai Hu" <mingkai.hu@nxp.com>, "Roy Zang" <roy.zang@nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Toan Le" <toan@os.amperecomputing.com>,
"Joyce Ooi" <joyce.ooi@intel.com>, "Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Conor Dooley" <conor.dooley@microchip.com>,
"Daire McNamara" <daire.mcnamara@microchip.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Bharat Kumar Gogada" <bharat.kumar.gogada@amd.com>,
"Michal Simek" <michal.simek@amd.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-tegra@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>
Subject: Re: [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes
Date: Tue, 25 Oct 2022 21:03:51 +0100 [thread overview]
Message-ID: <Y1hBJ+b4xmBRtrvF@spud> (raw)
In-Reply-To: <20221025185147.665365-1-helgaas@kernel.org>
On Tue, Oct 25, 2022 at 01:51:43PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> Many host controller drivers #include <linux/of_irq.h> even though they
> don't need it. Remove the unnecessary #includes.
>
> v1: https://lore.kernel.org/all/20221019195452.37606-1-helgaas@kernel.org/
>
> Changes from v1 to v2:
> - Include <linux/irqdomain.h> explicitly in altera-msi and microchip,
> which don't need <linux/of_irq.h> itself, but relied on it to include
> <linux/irqdomain.h>
> - Include <linux/irqdomain.h> explicitly in mvebu, which needs both it
> and <linux/of_irq.h>
>
> Bjorn Helgaas (4):
> PCI: altera-msi: Include <linux/irqdomain.h> explicitly
> PCI: microchip: Include <linux/irqdomain.h> explicitly
> PCI: mvebu: Include <linux/irqdomain.h> explicitly
> PCI: Remove unnecessary <linux/of_irq.h> includes
> drivers/pci/controller/pcie-microchip-host.c | 2 +-
Hey Bjorn, actually did the build this time rather than visually
inspecting... For the microchip bits:
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-25 20:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 18:51 [PATCH v2 0/4] PCI: Remove unnecessary <linux/of_irq.h> includes Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` [PATCH v2 1/4] PCI: altera-msi: Include <linux/irqdomain.h> explicitly Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` [PATCH v2 2/4] PCI: microchip: " Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` [PATCH v2 3/4] PCI: mvebu: " Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 21:05 ` Thomas Petazzoni
2022-10-25 21:05 ` Thomas Petazzoni
2022-10-25 21:05 ` Thomas Petazzoni
2022-10-25 21:05 ` Thomas Petazzoni
2022-10-25 21:05 ` Thomas Petazzoni
2022-10-25 18:51 ` [PATCH v2 4/4] PCI: Remove unnecessary <linux/of_irq.h> includes Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-25 18:51 ` Bjorn Helgaas
2022-10-31 8:30 ` kernel test robot
2022-10-31 8:30 ` kernel test robot
2022-10-31 8:30 ` kernel test robot
2022-10-25 20:03 ` Conor Dooley [this message]
2022-10-25 20:03 ` [PATCH v2 0/4] " Conor Dooley
2022-10-25 20:03 ` Conor Dooley
2022-10-25 20:03 ` Conor Dooley
2022-10-25 20:03 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1hBJ+b4xmBRtrvF@spud \
--to=conor@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=heiko@sntech.de \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=joyce.ooi@intel.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lpieralisi@kernel.org \
--cc=michal.simek@amd.com \
--cc=minghuan.Lian@nxp.com \
--cc=mingkai.hu@nxp.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=roy.zang@nxp.com \
--cc=sbranden@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.