From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst
Date: Mon, 8 Mar 2021 16:01:45 -0800 [thread overview]
Message-ID: <YEa66ekikyuPWSyd@google.com> (raw)
In-Reply-To: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com>
On 03/05, Chao Yu wrote:
> On 2021/3/5 4:20, Jaegeuk Kim wrote:
> > On 02/27, Jaegeuk Kim wrote:
> > > On 02/04, Chao Yu wrote:
> > > > Jaegeuk,
> > > >
> > > > On 2021/2/2 16:00, Chao Yu wrote:
> > > > > - for (i = 0; i < dic->nr_cpages; i++) {
> > > > > + for (i = 0; i < cc->nr_cpages; i++) {
> > > > > struct page *page = dic->cpages[i];
> > > >
> > > > por_fsstress still hang in this line?
> > >
> > > I'm stuck on testing the patches, since the latest kernel is panicking somehow.
> > > Let me update later, once I can test a bit. :(
> >
> > It seems this works without error.
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9
>
> Ah, good news.
>
> Thanks for helping to test the patch. :)
Hmm, I hit this again. Let me check w/o compress_cache back. :(
[159210.201131] ------------[ cut here ]------------
[159210.204241] kernel BUG at fs/f2fs/compress.c:1082!
[159210.207321] invalid opcode: 0000 [#1] SMP PTI
[159210.209407] CPU: 4 PID: 2753477 Comm: kworker/u16:2 Tainted: G OE 5.12.0-rc1-custom #1
[159210.212737] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
[159210.224800] Workqueue: writeback wb_workfn (flush-252:16)
[159210.226851] RIP: 0010:prepare_compress_overwrite+0x4c0/0x760 [f2fs]
[159210.229506] Code: 8b bf 90 0a 00 00 be 40 0d 00 00 e8 4a 92 4f c4 49 89 44 24 18 48 85 c0 0f 84 85 02 00 00 41 8b 54 24 10 e9 c5 fb ff ff 0f 0b <0f> 0b 41 8b 44 24 20 85 c0 0f 84 2a ff ff ff 48 8
[159210.236311] RSP: 0018:ffff9fa782177858 EFLAGS: 00010246
[159210.238517] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[159210.240734] RDX: 000000000000001c RSI: 0000000000000000 RDI: 0000000000000000
[159210.242941] RBP: ffff9fa7821778f0 R08: ffff93b9c89cb232 R09: 0000000000000003
[159210.245107] R10: ffffffff86873420 R11: 0000000000000001 R12: ffff9fa782177900
[159210.247319] R13: ffff93b906dca578 R14: 000000000000031c R15: 0000000000000000
[159210.249492] FS: 0000000000000000(0000) GS:ffff93b9fbd00000(0000) knlGS:0000000000000000
[159210.254724] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[159210.258709] CR2: 00007f0367d33738 CR3: 000000012bc0c004 CR4: 0000000000370ee0
[159210.261608] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[159210.264614] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[159210.267476] Call Trace:
[159210.269075] ? f2fs_compress_write_end+0xa2/0x100 [f2fs]
[159210.271165] f2fs_prepare_compress_overwrite+0x5f/0x80 [f2fs]
[159210.273017] f2fs_write_cache_pages+0x468/0x8a0 [f2fs]
[159210.274848] f2fs_write_data_pages+0x2a4/0x2f0 [f2fs]
[159210.276612] ? from_kgid+0x12/0x20
[159210.277994] ? f2fs_update_inode+0x3cb/0x510 [f2fs]
[159210.279748] do_writepages+0x38/0xc0
[159210.281183] ? f2fs_write_inode+0x11c/0x300 [f2fs]
[159210.282877] __writeback_single_inode+0x44/0x2a0
[159210.284526] writeback_sb_inodes+0x223/0x4d0
[159210.286105] __writeback_inodes_wb+0x56/0xf0
[159210.287740] wb_writeback+0x1dd/0x290
[159210.289182] wb_workfn+0x309/0x500
[159210.290553] process_one_work+0x220/0x3c0
[159210.292048] worker_thread+0x53/0x420
[159210.293403] kthread+0x12f/0x150
[159210.294716] ? process_one_work+0x3c0/0x3c0
[159210.296204] ? __kthread_bind_mask+0x70/0x70
[159210.297702] ret_from_fork+0x22/0x30
>
> Thanks,
>
> >
> > >
> > > >
> > > > Thanks,
> > > >
> > > > > block_t blkaddr;
> > > > > struct bio_post_read_ctx *ctx;
> > > > > @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret,
> > > > > blkaddr = data_blkaddr(dn.inode, dn.node_page,
> > > > > dn.ofs_in_node + i + 1);
> > > > > + f2fs_wait_on_block_writeback(inode, blkaddr);
> > > > > +
> > > > > + if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
> > > > > + if (atomic_dec_and_test(&dic->remaining_pages))
> > > > > + f2fs_decompress_cluster(dic);
> > > > > + continue;
> > > > > + }
> > > > > +
> > >
> > >
> > > _______________________________________________
> > > Linux-f2fs-devel mailing list
> > > Linux-f2fs-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > .
> >
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst
Date: Mon, 8 Mar 2021 16:01:45 -0800 [thread overview]
Message-ID: <YEa66ekikyuPWSyd@google.com> (raw)
In-Reply-To: <01a0ff76-6fa7-3196-8760-e7f6f163ef64@huawei.com>
On 03/05, Chao Yu wrote:
> On 2021/3/5 4:20, Jaegeuk Kim wrote:
> > On 02/27, Jaegeuk Kim wrote:
> > > On 02/04, Chao Yu wrote:
> > > > Jaegeuk,
> > > >
> > > > On 2021/2/2 16:00, Chao Yu wrote:
> > > > > - for (i = 0; i < dic->nr_cpages; i++) {
> > > > > + for (i = 0; i < cc->nr_cpages; i++) {
> > > > > struct page *page = dic->cpages[i];
> > > >
> > > > por_fsstress still hang in this line?
> > >
> > > I'm stuck on testing the patches, since the latest kernel is panicking somehow.
> > > Let me update later, once I can test a bit. :(
> >
> > It seems this works without error.
> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=4e6e1364dccba80ed44925870b97fbcf989b96c9
>
> Ah, good news.
>
> Thanks for helping to test the patch. :)
Hmm, I hit this again. Let me check w/o compress_cache back. :(
[159210.201131] ------------[ cut here ]------------
[159210.204241] kernel BUG at fs/f2fs/compress.c:1082!
[159210.207321] invalid opcode: 0000 [#1] SMP PTI
[159210.209407] CPU: 4 PID: 2753477 Comm: kworker/u16:2 Tainted: G OE 5.12.0-rc1-custom #1
[159210.212737] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-2 04/01/2014
[159210.224800] Workqueue: writeback wb_workfn (flush-252:16)
[159210.226851] RIP: 0010:prepare_compress_overwrite+0x4c0/0x760 [f2fs]
[159210.229506] Code: 8b bf 90 0a 00 00 be 40 0d 00 00 e8 4a 92 4f c4 49 89 44 24 18 48 85 c0 0f 84 85 02 00 00 41 8b 54 24 10 e9 c5 fb ff ff 0f 0b <0f> 0b 41 8b 44 24 20 85 c0 0f 84 2a ff ff ff 48 8
[159210.236311] RSP: 0018:ffff9fa782177858 EFLAGS: 00010246
[159210.238517] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[159210.240734] RDX: 000000000000001c RSI: 0000000000000000 RDI: 0000000000000000
[159210.242941] RBP: ffff9fa7821778f0 R08: ffff93b9c89cb232 R09: 0000000000000003
[159210.245107] R10: ffffffff86873420 R11: 0000000000000001 R12: ffff9fa782177900
[159210.247319] R13: ffff93b906dca578 R14: 000000000000031c R15: 0000000000000000
[159210.249492] FS: 0000000000000000(0000) GS:ffff93b9fbd00000(0000) knlGS:0000000000000000
[159210.254724] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[159210.258709] CR2: 00007f0367d33738 CR3: 000000012bc0c004 CR4: 0000000000370ee0
[159210.261608] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[159210.264614] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[159210.267476] Call Trace:
[159210.269075] ? f2fs_compress_write_end+0xa2/0x100 [f2fs]
[159210.271165] f2fs_prepare_compress_overwrite+0x5f/0x80 [f2fs]
[159210.273017] f2fs_write_cache_pages+0x468/0x8a0 [f2fs]
[159210.274848] f2fs_write_data_pages+0x2a4/0x2f0 [f2fs]
[159210.276612] ? from_kgid+0x12/0x20
[159210.277994] ? f2fs_update_inode+0x3cb/0x510 [f2fs]
[159210.279748] do_writepages+0x38/0xc0
[159210.281183] ? f2fs_write_inode+0x11c/0x300 [f2fs]
[159210.282877] __writeback_single_inode+0x44/0x2a0
[159210.284526] writeback_sb_inodes+0x223/0x4d0
[159210.286105] __writeback_inodes_wb+0x56/0xf0
[159210.287740] wb_writeback+0x1dd/0x290
[159210.289182] wb_workfn+0x309/0x500
[159210.290553] process_one_work+0x220/0x3c0
[159210.292048] worker_thread+0x53/0x420
[159210.293403] kthread+0x12f/0x150
[159210.294716] ? process_one_work+0x3c0/0x3c0
[159210.296204] ? __kthread_bind_mask+0x70/0x70
[159210.297702] ret_from_fork+0x22/0x30
>
> Thanks,
>
> >
> > >
> > > >
> > > > Thanks,
> > > >
> > > > > block_t blkaddr;
> > > > > struct bio_post_read_ctx *ctx;
> > > > > @@ -2201,6 +2207,14 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret,
> > > > > blkaddr = data_blkaddr(dn.inode, dn.node_page,
> > > > > dn.ofs_in_node + i + 1);
> > > > > + f2fs_wait_on_block_writeback(inode, blkaddr);
> > > > > +
> > > > > + if (f2fs_load_compressed_page(sbi, page, blkaddr)) {
> > > > > + if (atomic_dec_and_test(&dic->remaining_pages))
> > > > > + f2fs_decompress_cluster(dic);
> > > > > + continue;
> > > > > + }
> > > > > +
> > >
> > >
> > > _______________________________________________
> > > Linux-f2fs-devel mailing list
> > > Linux-f2fs-devel@lists.sourceforge.net
> > > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-03-09 0:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:00 [PATCH v4] f2fs: compress: add compress_inode to cache compressed blockst Chao Yu
2021-02-02 8:00 ` [f2fs-dev] " Chao Yu
2021-02-04 3:25 ` Chao Yu
2021-02-04 3:25 ` [f2fs-dev] " Chao Yu
2021-02-28 5:09 ` Jaegeuk Kim
2021-02-28 5:09 ` [f2fs-dev] " Jaegeuk Kim
2021-03-04 20:20 ` Jaegeuk Kim
2021-03-04 20:20 ` Jaegeuk Kim
2021-03-05 3:07 ` Chao Yu
2021-03-05 3:07 ` Chao Yu
2021-03-09 0:01 ` Jaegeuk Kim [this message]
2021-03-09 0:01 ` Jaegeuk Kim
2021-03-09 2:49 ` Chao Yu
2021-03-09 2:49 ` Chao Yu
2021-03-10 20:52 ` Jaegeuk Kim
2021-03-10 20:52 ` Jaegeuk Kim
2021-04-21 9:08 ` Chao Yu
2021-04-21 9:08 ` Chao Yu
2021-04-22 3:59 ` Jaegeuk Kim
2021-04-22 3:59 ` Jaegeuk Kim
2021-04-22 6:07 ` Chao Yu
2021-04-22 6:07 ` Chao Yu
2021-05-10 9:05 ` Chao Yu
2021-05-10 9:05 ` Chao Yu
2021-05-10 14:35 ` Jaegeuk Kim
2021-05-10 14:35 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEa66ekikyuPWSyd@google.com \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.