From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jonathan Marek <jonathan@marek.ca> Cc: freedreno@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>, Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>, Swapnil Jakhade <sjakhade@cadence.com>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <linux-arm-msm@vger.kernel.org>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <dri-devel@lists.freedesktop.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v3 2/3] dt-bindings: msm: dsi: document phy-type property for 7nm dsi phy Date: Tue, 8 Jun 2021 23:47:02 +0300 [thread overview] Message-ID: <YL/XRsiShrCJOadW@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210608195342.18269-3-jonathan@marek.ca> Hi Jonathan, Thank you for the patch. On Tue, Jun 08, 2021 at 03:53:28PM -0400, Jonathan Marek wrote: > Document a new phy-type property which will be used to determine whether > the phy should operate in D-PHY or C-PHY mode. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > .../devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 4 ++++ > include/dt-bindings/phy/phy.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index bf16b1c65e10..d447b517ea19 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -34,6 +34,10 @@ properties: > description: | > Connected to VDD_A_DSI_PLL_0P9 pin (or VDDA_DSI{0,1}_PLL_0P9 for sm8150) > > + phy-type: > + description: | > + D-PHY (default) or C-PHY mode: PHY_TYPE_DSI_DPHY or PHY_TYPE_DSI_CPHY > + > required: > - compatible > - reg > diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h > index 887a31b250a8..b978dac16bb8 100644 > --- a/include/dt-bindings/phy/phy.h > +++ b/include/dt-bindings/phy/phy.h > @@ -20,5 +20,7 @@ > #define PHY_TYPE_XPCS 7 > #define PHY_TYPE_SGMII 8 > #define PHY_TYPE_QSGMII 9 > +#define PHY_TYPE_DSI_DPHY 10 > +#define PHY_TYPE_DSI_CPHY 11 The MIPI D-PHY and C-PHY apply to both DSI and CSI. I'd name this PHY_TYPE_DPHY and PHY_TYPE_CPHY, or possibly, PHY_TYPE_MIPI_DPHY and PHY_TYPE_MIPI_CPHY, without a DSI prefix. With this addressed and the DT bindings updated accordingly, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (You may be asked to split this in two patches though, not sure) > #endif /* _DT_BINDINGS_PHY */ -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Jonathan Marek <jonathan@marek.ca> Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>, David Airlie <airlied@linux.ie>, freedreno@lists.freedesktop.org, "open list:DRM DRIVER FOR MSM ADRENO GPU" <linux-arm-msm@vger.kernel.org>, Vinod Koul <vkoul@kernel.org>, "open list:DRM DRIVER FOR MSM ADRENO GPU" <dri-devel@lists.freedesktop.org>, open list <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Swapnil Jakhade <sjakhade@cadence.com>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH v3 2/3] dt-bindings: msm: dsi: document phy-type property for 7nm dsi phy Date: Tue, 8 Jun 2021 23:47:02 +0300 [thread overview] Message-ID: <YL/XRsiShrCJOadW@pendragon.ideasonboard.com> (raw) In-Reply-To: <20210608195342.18269-3-jonathan@marek.ca> Hi Jonathan, Thank you for the patch. On Tue, Jun 08, 2021 at 03:53:28PM -0400, Jonathan Marek wrote: > Document a new phy-type property which will be used to determine whether > the phy should operate in D-PHY or C-PHY mode. > > Signed-off-by: Jonathan Marek <jonathan@marek.ca> > --- > .../devicetree/bindings/display/msm/dsi-phy-7nm.yaml | 4 ++++ > include/dt-bindings/phy/phy.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > index bf16b1c65e10..d447b517ea19 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-7nm.yaml > @@ -34,6 +34,10 @@ properties: > description: | > Connected to VDD_A_DSI_PLL_0P9 pin (or VDDA_DSI{0,1}_PLL_0P9 for sm8150) > > + phy-type: > + description: | > + D-PHY (default) or C-PHY mode: PHY_TYPE_DSI_DPHY or PHY_TYPE_DSI_CPHY > + > required: > - compatible > - reg > diff --git a/include/dt-bindings/phy/phy.h b/include/dt-bindings/phy/phy.h > index 887a31b250a8..b978dac16bb8 100644 > --- a/include/dt-bindings/phy/phy.h > +++ b/include/dt-bindings/phy/phy.h > @@ -20,5 +20,7 @@ > #define PHY_TYPE_XPCS 7 > #define PHY_TYPE_SGMII 8 > #define PHY_TYPE_QSGMII 9 > +#define PHY_TYPE_DSI_DPHY 10 > +#define PHY_TYPE_DSI_CPHY 11 The MIPI D-PHY and C-PHY apply to both DSI and CSI. I'd name this PHY_TYPE_DPHY and PHY_TYPE_CPHY, or possibly, PHY_TYPE_MIPI_DPHY and PHY_TYPE_MIPI_CPHY, without a DSI prefix. With this addressed and the DT bindings updated accordingly, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> (You may be asked to split this in two patches though, not sure) > #endif /* _DT_BINDINGS_PHY */ -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2021-06-08 20:47 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-08 19:53 [PATCH v3 0/3] drm/msm/dsi: support CPHY mode for 7nm pll/phy Jonathan Marek 2021-06-08 19:53 ` Jonathan Marek 2021-06-08 19:53 ` [PATCH v3 1/3] dt-bindings: msm: dsi: add missing 7nm bindings Jonathan Marek 2021-06-08 19:53 ` Jonathan Marek 2021-06-09 16:16 ` Rob Herring 2021-06-09 16:16 ` Rob Herring 2021-06-08 19:53 ` [PATCH v3 2/3] dt-bindings: msm: dsi: document phy-type property for 7nm dsi phy Jonathan Marek 2021-06-08 19:53 ` Jonathan Marek 2021-06-08 20:47 ` Laurent Pinchart [this message] 2021-06-08 20:47 ` Laurent Pinchart 2021-06-09 21:57 ` Rob Herring 2021-06-09 21:57 ` Rob Herring 2021-06-08 19:53 ` [PATCH v3 3/3] drm/msm/dsi: support CPHY mode for 7nm pll/phy Jonathan Marek 2021-06-08 19:53 ` Jonathan Marek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YL/XRsiShrCJOadW@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=anurag.kumar.vulisha@xilinx.com \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean@poorly.run \ --cc=sjakhade@cadence.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.