* [PATCH v21 RESEND 0/4] add power control in i2c
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v20:
- fix regulator check logic in suspend/resume.
Changes since v19:
- resend v19 with fix tag added.
Changes since v18:
- Fix a function name conflict with drivers/gpu/drm/i915/selftests/i915_gem.c
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (3):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++
include/linux/i2c.h | 2 +
7 files changed, 117 insertions(+)
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 0/4] add power control in i2c
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v20:
- fix regulator check logic in suspend/resume.
Changes since v19:
- resend v19 with fix tag added.
Changes since v18:
- Fix a function name conflict with drivers/gpu/drm/i915/selftests/i915_gem.c
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (3):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++
include/linux/i2c.h | 2 +
7 files changed, 117 insertions(+)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 0/4] add power control in i2c
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Although in the most platforms, the power of eeprom
and i2c are alway on, some platforms disable the
eeprom and i2c power in order to meet low power request.
This patch add the pm_runtime ops to control power to
support all platforms.
Changes since v20:
- fix regulator check logic in suspend/resume.
Changes since v19:
- resend v19 with fix tag added.
Changes since v18:
- Fix a function name conflict with drivers/gpu/drm/i915/selftests/i915_gem.c
Changes since v17:
- Add a patch to fix unbalanced regulator disabling.
- Add dts patch.
Changes since v16:
- request regulator in device instead of in the core.
- control regulator only if it's provided.
Changes since v15:
- Squash the fix[1] for v15.
[1] https://patchwork.ozlabs.org/project/linux-i2c/patch/20200522101327.13456-1-m.szyprowski@samsung.com/
Changes since v14:
- change the return value in normal condition
- access the variable after NULL pointer checking
- add ack tag
Changes since v13:
- fixup some logic error
Changes since v12:
- rebase onto v5.7-rc1
- change the property description in binding
Changes since v11:
- use suspend_late/resume_early instead of suspend/resume
- rebase onto v5.6-rc1
Changes since v10:
- fixup some worng codes
Changes since v9:
- fixup build error
- remove redundant code
Changes since v8:
- fixup some wrong code
- remove redundant message
[... snip ...]
Bibby Hsieh (1):
i2c: core: support bus regulator controlling in adapter
Hsin-Yi Wang (3):
dt-binding: i2c: mt65xx: add vbus-supply property
i2c: mediatek: mt65xx: add optional vbus-supply
arm64: dts: mt8183: add supply name for eeprom
.../devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
.../dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 +
.../dts/mediatek/mt8183-kukui-kodama.dtsi | 4 +
.../boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 +
drivers/i2c/busses/i2c-mt65xx.c | 7 ++
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++
include/linux/i2c.h | 2 +
7 files changed, 117 insertions(+)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-27 7:55 ` Hsin-Yi Wang
-1 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 97 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 5a97e4a02fa2..23bc7c269184 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,86 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ if (client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+ return 0;
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +768,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 97 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 5a97e4a02fa2..23bc7c269184 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,86 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ if (client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+ return 0;
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +768,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
From: Bibby Hsieh <bibby.hsieh@mediatek.com>
Although in the most platforms, the bus power of i2c
are alway on, some platforms disable the i2c bus power
in order to meet low power request.
We can control bulk regulator if it is provided in i2c
adapter device.
Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
---
drivers/i2c/i2c-core-base.c | 95 +++++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 2 +
2 files changed, 97 insertions(+)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 5a97e4a02fa2..23bc7c269184 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -461,12 +461,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client)
static int i2c_device_probe(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
int status;
if (!client)
return 0;
+ adap = client->adapter;
client->irq = client->init_irq;
if (!client->irq) {
@@ -532,6 +534,14 @@ static int i2c_device_probe(struct device *dev)
dev_dbg(dev, "probe\n");
+ if (adap->bus_regulator) {
+ status = regulator_enable(adap->bus_regulator);
+ if (status < 0) {
+ dev_err(&adap->dev, "Failed to enable bus regulator\n");
+ goto err_clear_wakeup_irq;
+ }
+ }
+
status = of_clk_set_defaults(dev->of_node, false);
if (status < 0)
goto err_clear_wakeup_irq;
@@ -589,8 +599,10 @@ static int i2c_device_probe(struct device *dev)
static int i2c_device_remove(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
+ struct i2c_adapter *adap;
struct i2c_driver *driver;
+ adap = client->adapter;
driver = to_i2c_driver(dev->driver);
if (driver->remove) {
int status;
@@ -605,6 +617,8 @@ static int i2c_device_remove(struct device *dev)
devres_release_group(&client->dev, client->devres_group_id);
dev_pm_domain_detach(&client->dev, true);
+ if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator)
+ regulator_disable(adap->bus_regulator);
dev_pm_clear_wake_irq(&client->dev);
device_init_wakeup(&client->dev, false);
@@ -617,6 +631,86 @@ static int i2c_device_remove(struct device *dev)
return 0;
}
+#ifdef CONFIG_PM_SLEEP
+static int i2c_resume_early(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_resume_early(&client->dev);
+}
+
+static int i2c_suspend_late(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_suspend_late(&client->dev);
+ if (err)
+ return err;
+
+ if (!pm_runtime_status_suspended(&client->dev) &&
+ client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+
+ return 0;
+}
+#endif
+
+#ifdef CONFIG_PM
+static int i2c_runtime_resume(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ if (client->adapter->bus_regulator) {
+ err = regulator_enable(client->adapter->bus_regulator);
+ if (err)
+ return err;
+ }
+
+ return pm_generic_runtime_resume(&client->dev);
+}
+
+static int i2c_runtime_suspend(struct device *dev)
+{
+ struct i2c_client *client = i2c_verify_client(dev);
+ int err;
+
+ if (!client)
+ return 0;
+
+ err = pm_generic_runtime_suspend(&client->dev);
+ if (err)
+ return err;
+
+ if (client->adapter->bus_regulator)
+ return regulator_disable(client->adapter->bus_regulator);
+ return 0;
+}
+#endif
+
+static const struct dev_pm_ops i2c_device_pm = {
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early)
+ SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL)
+};
+
static void i2c_device_shutdown(struct device *dev)
{
struct i2c_client *client = i2c_verify_client(dev);
@@ -674,6 +768,7 @@ struct bus_type i2c_bus_type = {
.probe = i2c_device_probe,
.remove = i2c_device_remove,
.shutdown = i2c_device_shutdown,
+ .pm = &i2c_device_pm,
};
EXPORT_SYMBOL_GPL(i2c_bus_type);
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index e8f2ac8c9c3d..953a4eecb88f 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -15,6 +15,7 @@
#include <linux/device.h> /* for struct device */
#include <linux/sched.h> /* for completion */
#include <linux/mutex.h>
+#include <linux/regulator/consumer.h>
#include <linux/rtmutex.h>
#include <linux/irqdomain.h> /* for Host Notify IRQ */
#include <linux/of.h> /* for struct device_node */
@@ -729,6 +730,7 @@ struct i2c_adapter {
const struct i2c_adapter_quirks *quirks;
struct irq_domain *host_notify_domain;
+ struct regulator *bus_regulator;
};
#define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-27 7:55 ` Hsin-Yi Wang
-1 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply property for mt65xx. The regulator can be passed into
core and turned off during suspend/sleep to reduce power consumption.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Acked-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
index 7f0194fdd0cc..2c45647e9f0b 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
@@ -32,6 +32,7 @@ Optional properties:
- mediatek,have-pmic: platform can control i2c form special pmic side.
Only mt6589 and mt8135 support this feature.
- mediatek,use-push-pull: IO config use push-pull mode.
+ - vbus-supply: phandle to the regulator that provides power to SCL/SDA.
Example:
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-27 7:55 ` Hsin-Yi Wang
-1 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..22d1d14b5de5 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..22d1d14b5de5 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add vbus-supply which provides power to SCL/SDA. Pass this regulator
into core so it can be turned on/off for low power mode support.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
---
drivers/i2c/busses/i2c-mt65xx.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 5ddfa4e56ee2..22d1d14b5de5 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -1220,6 +1220,13 @@ static int mtk_i2c_probe(struct platform_device *pdev)
i2c->adap.quirks = i2c->dev_comp->quirks;
i2c->adap.timeout = 2 * HZ;
i2c->adap.retries = 1;
+ i2c->adap.bus_regulator = devm_regulator_get_optional(&pdev->dev, "vbus");
+ if (IS_ERR(i2c->adap.bus_regulator)) {
+ if (PTR_ERR(i2c->adap.bus_regulator) == -ENODEV)
+ i2c->adap.bus_regulator = NULL;
+ else
+ return PTR_ERR(i2c->adap.bus_regulator);
+ }
ret = mtk_i2c_parse_dt(pdev->dev.of_node, i2c);
if (ret)
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-27 7:55 ` Hsin-Yi Wang
-1 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.818.g46aad6cb9e-goog
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 32+ messages in thread
* [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-05-27 7:55 ` Hsin-Yi Wang
0 siblings, 0 replies; 32+ messages in thread
From: Hsin-Yi Wang @ 2021-05-27 7:55 UTC (permalink / raw)
To: Wolfram Sang, Matthias Brugger, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
Add supplies for eeprom for mt8183 boards.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
3 files changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
index b442e38a3156..28966a65391b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
@@ -88,11 +88,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -101,11 +103,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
index 2f5234a16ead..3aa79403c0c2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
@@ -62,11 +62,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c64";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcamio_reg>;
};
};
@@ -75,11 +77,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c64";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
index fbc471ccf805..30c183c96a54 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
@@ -71,11 +71,13 @@ &i2c2 {
pinctrl-0 = <&i2c2_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcamio_reg>;
eeprom@58 {
compatible = "atmel,24c32";
reg = <0x58>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcama2_reg>;
};
};
@@ -84,11 +86,13 @@ &i2c4 {
pinctrl-0 = <&i2c4_pins>;
status = "okay";
clock-frequency = <400000>;
+ vbus-supply = <&mt6358_vcn18_reg>;
eeprom@54 {
compatible = "atmel,24c32";
reg = <0x54>;
pagesize = <32>;
+ vcc-supply = <&mt6358_vcn18_reg>;
};
};
--
2.31.1.818.g46aad6cb9e-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
(?)
@ 2021-05-27 18:46 ` kernel test robot
-1 siblings, 0 replies; 32+ messages in thread
From: kernel test robot @ 2021-05-27 18:46 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 8193 bytes --]
Hi Hsin-Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on robh/for-next mediatek/for-next v5.13-rc3 next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/add-power-control-in-i2c/20210527-155826
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-randconfig-a012-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6505c630407c5feec818f0bb1c284f9eeebf2071)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/e76ae7334b07a6721160299cf30e55b200bb5466
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hsin-Yi-Wang/add-power-control-in-i2c/20210527-155826
git checkout e76ae7334b07a6721160299cf30e55b200bb5466
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_gem.c:1250:
>> drivers/gpu/drm/i915/selftests/i915_gem.c:97:13: error: conflicting types for 'pm_suspend'
static void pm_suspend(struct drm_i915_private *i915)
^
include/linux/suspend.h:345:19: note: previous definition is here
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
^
In file included from drivers/gpu/drm/i915/i915_gem.c:1250:
>> drivers/gpu/drm/i915/selftests/i915_gem.c:155:13: error: incompatible pointer to integer conversion passing 'struct drm_i915_private *' to parameter of type 'suspend_state_t' (aka 'int') [-Werror,-Wint-conversion]
pm_suspend(i915);
^~~~
include/linux/suspend.h:345:46: note: passing argument to parameter 'state' here
static inline int pm_suspend(suspend_state_t state) { return -ENOSYS; }
^
2 errors generated.
vim +/pm_suspend +97 drivers/gpu/drm/i915/selftests/i915_gem.c
3f51b7e1f36a37 Chris Wilson 2018-08-30 96
3f51b7e1f36a37 Chris Wilson 2018-08-30 @97 static void pm_suspend(struct drm_i915_private *i915)
3f51b7e1f36a37 Chris Wilson 2018-08-30 98 {
c9d08cc3e3393e Chris Wilson 2019-01-14 99 intel_wakeref_t wakeref;
c9d08cc3e3393e Chris Wilson 2019-01-14 100
c447ff7db34807 Daniele Ceraolo Spurio 2019-06-13 101 with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
e986209c67024c Chris Wilson 2020-01-30 102 i915_ggtt_suspend(&i915->ggtt);
3f51b7e1f36a37 Chris Wilson 2018-08-30 103 i915_gem_suspend_late(i915);
d4225a535b3b08 Chris Wilson 2019-01-14 104 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 105 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 106
3f51b7e1f36a37 Chris Wilson 2018-08-30 107 static void pm_hibernate(struct drm_i915_private *i915)
3f51b7e1f36a37 Chris Wilson 2018-08-30 108 {
c9d08cc3e3393e Chris Wilson 2019-01-14 109 intel_wakeref_t wakeref;
c9d08cc3e3393e Chris Wilson 2019-01-14 110
c447ff7db34807 Daniele Ceraolo Spurio 2019-06-13 111 with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
e986209c67024c Chris Wilson 2020-01-30 112 i915_ggtt_suspend(&i915->ggtt);
3f51b7e1f36a37 Chris Wilson 2018-08-30 113
3f51b7e1f36a37 Chris Wilson 2018-08-30 114 i915_gem_freeze(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 115 i915_gem_freeze_late(i915);
d4225a535b3b08 Chris Wilson 2019-01-14 116 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 117 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 118
3f51b7e1f36a37 Chris Wilson 2018-08-30 119 static void pm_resume(struct drm_i915_private *i915)
3f51b7e1f36a37 Chris Wilson 2018-08-30 120 {
c9d08cc3e3393e Chris Wilson 2019-01-14 121 intel_wakeref_t wakeref;
c9d08cc3e3393e Chris Wilson 2019-01-14 122
3f51b7e1f36a37 Chris Wilson 2018-08-30 123 /*
3f51b7e1f36a37 Chris Wilson 2018-08-30 124 * Both suspend and hibernate follow the same wakeup path and assume
3f51b7e1f36a37 Chris Wilson 2018-08-30 125 * that runtime-pm just works.
3f51b7e1f36a37 Chris Wilson 2018-08-30 126 */
c447ff7db34807 Daniele Ceraolo Spurio 2019-06-13 127 with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
e986209c67024c Chris Wilson 2020-01-30 128 i915_ggtt_resume(&i915->ggtt);
3f51b7e1f36a37 Chris Wilson 2018-08-30 129 i915_gem_resume(i915);
d4225a535b3b08 Chris Wilson 2019-01-14 130 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 131 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 132
3f51b7e1f36a37 Chris Wilson 2018-08-30 133 static int igt_gem_suspend(void *arg)
3f51b7e1f36a37 Chris Wilson 2018-08-30 134 {
3f51b7e1f36a37 Chris Wilson 2018-08-30 135 struct drm_i915_private *i915 = arg;
3f51b7e1f36a37 Chris Wilson 2018-08-30 136 struct i915_gem_context *ctx;
a8c9a7f52ec5a4 Chris Wilson 2019-11-07 137 struct file *file;
3f51b7e1f36a37 Chris Wilson 2018-08-30 138 int err;
3f51b7e1f36a37 Chris Wilson 2018-08-30 139
3f51b7e1f36a37 Chris Wilson 2018-08-30 140 file = mock_file(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 141 if (IS_ERR(file))
3f51b7e1f36a37 Chris Wilson 2018-08-30 142 return PTR_ERR(file);
3f51b7e1f36a37 Chris Wilson 2018-08-30 143
3f51b7e1f36a37 Chris Wilson 2018-08-30 144 err = -ENOMEM;
3f51b7e1f36a37 Chris Wilson 2018-08-30 145 ctx = live_context(i915, file);
3f51b7e1f36a37 Chris Wilson 2018-08-30 146 if (!IS_ERR(ctx))
c31c9e82ee8ae0 Chris Wilson 2019-10-22 147 err = switch_to_context(ctx);
3f51b7e1f36a37 Chris Wilson 2018-08-30 148 if (err)
3f51b7e1f36a37 Chris Wilson 2018-08-30 149 goto out;
3f51b7e1f36a37 Chris Wilson 2018-08-30 150
3f51b7e1f36a37 Chris Wilson 2018-08-30 151 err = pm_prepare(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 152 if (err)
3f51b7e1f36a37 Chris Wilson 2018-08-30 153 goto out;
3f51b7e1f36a37 Chris Wilson 2018-08-30 154
3f51b7e1f36a37 Chris Wilson 2018-08-30 @155 pm_suspend(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 156
3f51b7e1f36a37 Chris Wilson 2018-08-30 157 /* Here be dragons! Note that with S3RST any S3 may become S4! */
3f51b7e1f36a37 Chris Wilson 2018-08-30 158 simulate_hibernate(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 159
3f51b7e1f36a37 Chris Wilson 2018-08-30 160 pm_resume(i915);
3f51b7e1f36a37 Chris Wilson 2018-08-30 161
c31c9e82ee8ae0 Chris Wilson 2019-10-22 162 err = switch_to_context(ctx);
3f51b7e1f36a37 Chris Wilson 2018-08-30 163 out:
a8c9a7f52ec5a4 Chris Wilson 2019-11-07 164 fput(file);
3f51b7e1f36a37 Chris Wilson 2018-08-30 165 return err;
3f51b7e1f36a37 Chris Wilson 2018-08-30 166 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 167
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 43557 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
2021-05-27 7:55 ` Hsin-Yi Wang
` (2 preceding siblings ...)
(?)
@ 2021-05-27 20:32 ` kernel test robot
-1 siblings, 0 replies; 32+ messages in thread
From: kernel test robot @ 2021-05-27 20:32 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3620 bytes --]
Hi Hsin-Yi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on robh/for-next mediatek/for-next v5.13-rc3 next-20210527]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hsin-Yi-Wang/add-power-control-in-i2c/20210527-155826
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: x86_64-randconfig-a011-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6505c630407c5feec818f0bb1c284f9eeebf2071)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/e76ae7334b07a6721160299cf30e55b200bb5466
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Hsin-Yi-Wang/add-power-control-in-i2c/20210527-155826
git checkout e76ae7334b07a6721160299cf30e55b200bb5466
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/i915_gem.c:1250:
>> drivers/gpu/drm/i915/selftests/i915_gem.c:97:13: error: static declaration of 'pm_suspend' follows non-static declaration
static void pm_suspend(struct drm_i915_private *i915)
^
include/linux/suspend.h:331:12: note: previous declaration is here
extern int pm_suspend(suspend_state_t state);
^
In file included from drivers/gpu/drm/i915/i915_gem.c:1250:
drivers/gpu/drm/i915/selftests/i915_gem.c:155:13: error: incompatible pointer to integer conversion passing 'struct drm_i915_private *' to parameter of type 'suspend_state_t' (aka 'int') [-Werror,-Wint-conversion]
pm_suspend(i915);
^~~~
include/linux/suspend.h:331:39: note: passing argument to parameter 'state' here
extern int pm_suspend(suspend_state_t state);
^
2 errors generated.
vim +/pm_suspend +97 drivers/gpu/drm/i915/selftests/i915_gem.c
3f51b7e1f36a37 Chris Wilson 2018-08-30 96
3f51b7e1f36a37 Chris Wilson 2018-08-30 @97 static void pm_suspend(struct drm_i915_private *i915)
3f51b7e1f36a37 Chris Wilson 2018-08-30 98 {
c9d08cc3e3393e Chris Wilson 2019-01-14 99 intel_wakeref_t wakeref;
c9d08cc3e3393e Chris Wilson 2019-01-14 100
c447ff7db34807 Daniele Ceraolo Spurio 2019-06-13 101 with_intel_runtime_pm(&i915->runtime_pm, wakeref) {
e986209c67024c Chris Wilson 2020-01-30 102 i915_ggtt_suspend(&i915->ggtt);
3f51b7e1f36a37 Chris Wilson 2018-08-30 103 i915_gem_suspend_late(i915);
d4225a535b3b08 Chris Wilson 2019-01-14 104 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 105 }
3f51b7e1f36a37 Chris Wilson 2018-08-30 106
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 37007 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-28 19:05 ` Wolfram Sang
-1 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:05 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Thu, May 27, 2021 at 03:55:53PM +0800, Hsin-Yi Wang wrote:
> From: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> Although in the most platforms, the bus power of i2c
> are alway on, some platforms disable the i2c bus power
> in order to meet low power request.
>
> We can control bulk regulator if it is provided in i2c
> adapter device.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
It looks good to me. I have to admit, though, that I am not a PM expert,
but I trust you guys here. Let's apply it and see what happens.
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
@ 2021-05-28 19:05 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:05 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]
On Thu, May 27, 2021 at 03:55:53PM +0800, Hsin-Yi Wang wrote:
> From: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> Although in the most platforms, the bus power of i2c
> are alway on, some platforms disable the i2c bus power
> in order to meet low power request.
>
> We can control bulk regulator if it is provided in i2c
> adapter device.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
It looks good to me. I have to admit, though, that I am not a PM expert,
but I trust you guys here. Let's apply it and see what happens.
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter
@ 2021-05-28 19:05 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:05 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]
On Thu, May 27, 2021 at 03:55:53PM +0800, Hsin-Yi Wang wrote:
> From: Bibby Hsieh <bibby.hsieh@mediatek.com>
>
> Although in the most platforms, the bus power of i2c
> are alway on, some platforms disable the i2c bus power
> in order to meet low power request.
>
> We can control bulk regulator if it is provided in i2c
> adapter device.
>
> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
It looks good to me. I have to admit, though, that I am not a PM expert,
but I trust you guys here. Let's apply it and see what happens.
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-28 19:07 ` Wolfram Sang
-1 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
On Thu, May 27, 2021 at 03:55:54PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply property for mt65xx. The regulator can be passed into
> core and turned off during suspend/sleep to reduce power consumption.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-05-28 19:07 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
On Thu, May 27, 2021 at 03:55:54PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply property for mt65xx. The regulator can be passed into
> core and turned off during suspend/sleep to reduce power consumption.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property
@ 2021-05-28 19:07 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 343 bytes --]
On Thu, May 27, 2021 at 03:55:54PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply property for mt65xx. The regulator can be passed into
> core and turned off during suspend/sleep to reduce power consumption.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Acked-by: Rob Herring <robh@kernel.org>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-28 19:07 ` Wolfram Sang
-1 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
On Thu, May 27, 2021 at 03:55:55PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply which provides power to SCL/SDA. Pass this regulator
> into core so it can be turned on/off for low power mode support.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-05-28 19:07 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]
On Thu, May 27, 2021 at 03:55:55PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply which provides power to SCL/SDA. Pass this regulator
> into core so it can be turned on/off for low power mode support.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply
@ 2021-05-28 19:07 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:07 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]
On Thu, May 27, 2021 at 03:55:55PM +0800, Hsin-Yi Wang wrote:
> Add vbus-supply which provides power to SCL/SDA. Pass this regulator
> into core so it can be turned on/off for low power mode support.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Applied to for-next, thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-05-28 19:08 ` Wolfram Sang
-1 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:08 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1: Type: text/plain, Size: 241 bytes --]
On Thu, May 27, 2021 at 03:55:56PM +0800, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
I dont' take DTS patches, but this can now go into -next via arm-soc.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-05-28 19:08 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:08 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 241 bytes --]
On Thu, May 27, 2021 at 03:55:56PM +0800, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
I dont' take DTS patches, but this can now go into -next via arm-soc.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-05-28 19:08 ` Wolfram Sang
0 siblings, 0 replies; 32+ messages in thread
From: Wolfram Sang @ 2021-05-28 19:08 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Jean Delvare, Rob Herring, Bartosz Golaszewski,
linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
[-- Attachment #1.1: Type: text/plain, Size: 241 bytes --]
On Thu, May 27, 2021 at 03:55:56PM +0800, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
I dont' take DTS patches, but this can now go into -next via arm-soc.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
2021-05-27 7:55 ` Hsin-Yi Wang
(?)
@ 2021-06-02 12:23 ` Matthias Brugger
-1 siblings, 0 replies; 32+ messages in thread
From: Matthias Brugger @ 2021-06-02 12:23 UTC (permalink / raw)
To: Hsin-Yi Wang, Wolfram Sang, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
On 27/05/2021 09:55, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Applied to v5.13-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> index b442e38a3156..28966a65391b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> @@ -88,11 +88,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -101,11 +103,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> index 2f5234a16ead..3aa79403c0c2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> @@ -62,11 +62,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c64";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcamio_reg>;
> };
> };
>
> @@ -75,11 +77,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c64";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> index fbc471ccf805..30c183c96a54 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> @@ -71,11 +71,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -84,11 +86,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
>
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-06-02 12:23 ` Matthias Brugger
0 siblings, 0 replies; 32+ messages in thread
From: Matthias Brugger @ 2021-06-02 12:23 UTC (permalink / raw)
To: Hsin-Yi Wang, Wolfram Sang, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
On 27/05/2021 09:55, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Applied to v5.13-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> index b442e38a3156..28966a65391b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> @@ -88,11 +88,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -101,11 +103,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> index 2f5234a16ead..3aa79403c0c2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> @@ -62,11 +62,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c64";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcamio_reg>;
> };
> };
>
> @@ -75,11 +77,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c64";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> index fbc471ccf805..30c183c96a54 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> @@ -71,11 +71,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -84,11 +86,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom
@ 2021-06-02 12:23 ` Matthias Brugger
0 siblings, 0 replies; 32+ messages in thread
From: Matthias Brugger @ 2021-06-02 12:23 UTC (permalink / raw)
To: Hsin-Yi Wang, Wolfram Sang, Jean Delvare, Rob Herring,
Bartosz Golaszewski
Cc: linux-i2c, Qii Wang, devicetree, linux-arm-kernel,
linux-mediatek, linux-kernel, Greg Kroah-Hartman, Mark Brown,
Marek Szyprowski, Bibby Hsieh, Arnd Bergmann
On 27/05/2021 09:55, Hsin-Yi Wang wrote:
> Add supplies for eeprom for mt8183 boards.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Applied to v5.13-next/dts64
Thanks!
> ---
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi | 4 ++++
> arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi | 4 ++++
> 3 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> index b442e38a3156..28966a65391b 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kakadu.dtsi
> @@ -88,11 +88,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -101,11 +103,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> index 2f5234a16ead..3aa79403c0c2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-kodama.dtsi
> @@ -62,11 +62,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c64";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcamio_reg>;
> };
> };
>
> @@ -75,11 +77,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c64";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> index fbc471ccf805..30c183c96a54 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-krane.dtsi
> @@ -71,11 +71,13 @@ &i2c2 {
> pinctrl-0 = <&i2c2_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcamio_reg>;
>
> eeprom@58 {
> compatible = "atmel,24c32";
> reg = <0x58>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcama2_reg>;
> };
> };
>
> @@ -84,11 +86,13 @@ &i2c4 {
> pinctrl-0 = <&i2c4_pins>;
> status = "okay";
> clock-frequency = <400000>;
> + vbus-supply = <&mt6358_vcn18_reg>;
>
> eeprom@54 {
> compatible = "atmel,24c32";
> reg = <0x54>;
> pagesize = <32>;
> + vcc-supply = <&mt6358_vcn18_reg>;
> };
> };
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 32+ messages in thread
end of thread, other threads:[~2021-06-02 12:43 UTC | newest]
Thread overview: 32+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 7:55 [PATCH v21 RESEND 0/4] add power control in i2c Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` [PATCH v21 RESEND 1/4] i2c: core: support bus regulator controlling in adapter Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 18:46 ` kernel test robot
2021-05-27 20:32 ` kernel test robot
2021-05-28 19:05 ` Wolfram Sang
2021-05-28 19:05 ` Wolfram Sang
2021-05-28 19:05 ` Wolfram Sang
2021-05-27 7:55 ` [PATCH v21 RESEND 2/4] dt-binding: i2c: mt65xx: add vbus-supply property Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-28 19:07 ` Wolfram Sang
2021-05-28 19:07 ` Wolfram Sang
2021-05-28 19:07 ` Wolfram Sang
2021-05-27 7:55 ` [PATCH v21 RESEND 3/4] i2c: mediatek: mt65xx: add optional vbus-supply Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-28 19:07 ` Wolfram Sang
2021-05-28 19:07 ` Wolfram Sang
2021-05-28 19:07 ` Wolfram Sang
2021-05-27 7:55 ` [PATCH v21 RESEND 4/4] arm64: dts: mt8183: add supply name for eeprom Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-27 7:55 ` Hsin-Yi Wang
2021-05-28 19:08 ` Wolfram Sang
2021-05-28 19:08 ` Wolfram Sang
2021-05-28 19:08 ` Wolfram Sang
2021-06-02 12:23 ` Matthias Brugger
2021-06-02 12:23 ` Matthias Brugger
2021-06-02 12:23 ` Matthias Brugger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.