From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Baruch Siach <baruch@tkos.co.il>, Rob Herring <robh+dt@kernel.org> Cc: Thierry Reding <thierry.reding@gmail.com>, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>, Andy Gross <agross@kernel.org>, Balaji Prakash J <bjagadee@codeaurora.org>, Robert Marko <robert.marko@sartura.hr>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: add IPQ6018 binding Date: Wed, 2 Jun 2021 18:05:52 -0500 [thread overview] Message-ID: <YLgO0Aj1d4w9EcPv@yoga> (raw) In-Reply-To: <249bddc521b15e992d0846edf1813aeb577458b9.1621851644.git.baruch@tkos.co.il> On Mon 24 May 05:20 CDT 2021, Baruch Siach wrote: > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > v2: Make #pwm-cells const (Rob Herring) > --- > .../devicetree/bindings/pwm/ipq-pwm.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > new file mode 100644 > index 000000000000..f85ce808a14e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ6018 PWM controller > + > +maintainers: > + - Baruch Siach <baruch@tkos.co.il> > + > +properties: > + "#pwm-cells": > + const: 2 > + > + compatible: > + const: qcom,pwm-ipq6018 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: core > + > +required: > + - "#pwm-cells" > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-ipq6018.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pwm@1941010 { > + #pwm-cells = <2>; > + compatible = "qcom,pwm-ipq6018"; > + reg = <0x0 0x1941010 0x0 0x20>; These 32 bytes are in the middle of the TCSR block, which is already partially described by the &tcsr_q6 node, which is described as only compatible = "syscon" - something no longer accepted by the DT maintainers. As such, I think we should adjust the &tcsr_q6 definition to cover the entire TCSR: 0x01937000 of size 0x21000. @Rob, should we represent the entire tcsr as a simple-mfd and then have the pwm and q6 region as children of that? Or can we make the whole thing as a simple-mfd and a syscon and only describe the pwm as a child? Regards, Bjorn > + clocks = <&gcc GCC_ADSS_PWM_CLK>; > + clock-names = "core"; > + }; > + }; > -- > 2.30.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Baruch Siach <baruch@tkos.co.il>, Rob Herring <robh+dt@kernel.org> Cc: Thierry Reding <thierry.reding@gmail.com>, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>, Andy Gross <agross@kernel.org>, Balaji Prakash J <bjagadee@codeaurora.org>, Robert Marko <robert.marko@sartura.hr>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: add IPQ6018 binding Date: Wed, 2 Jun 2021 18:05:52 -0500 [thread overview] Message-ID: <YLgO0Aj1d4w9EcPv@yoga> (raw) In-Reply-To: <249bddc521b15e992d0846edf1813aeb577458b9.1621851644.git.baruch@tkos.co.il> On Mon 24 May 05:20 CDT 2021, Baruch Siach wrote: > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > Signed-off-by: Baruch Siach <baruch@tkos.co.il> > --- > v2: Make #pwm-cells const (Rob Herring) > --- > .../devicetree/bindings/pwm/ipq-pwm.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > new file mode 100644 > index 000000000000..f85ce808a14e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ6018 PWM controller > + > +maintainers: > + - Baruch Siach <baruch@tkos.co.il> > + > +properties: > + "#pwm-cells": > + const: 2 > + > + compatible: > + const: qcom,pwm-ipq6018 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: core > + > +required: > + - "#pwm-cells" > + - compatible > + - reg > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-ipq6018.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + pwm@1941010 { > + #pwm-cells = <2>; > + compatible = "qcom,pwm-ipq6018"; > + reg = <0x0 0x1941010 0x0 0x20>; These 32 bytes are in the middle of the TCSR block, which is already partially described by the &tcsr_q6 node, which is described as only compatible = "syscon" - something no longer accepted by the DT maintainers. As such, I think we should adjust the &tcsr_q6 definition to cover the entire TCSR: 0x01937000 of size 0x21000. @Rob, should we represent the entire tcsr as a simple-mfd and then have the pwm and q6 region as children of that? Or can we make the whole thing as a simple-mfd and a syscon and only describe the pwm as a child? Regards, Bjorn > + clocks = <&gcc GCC_ADSS_PWM_CLK>; > + clock-names = "core"; > + }; > + }; > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-02 23:05 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-24 10:20 [PATCH v2 1/3] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach 2021-05-24 10:20 ` Baruch Siach 2021-05-24 10:20 ` [PATCH v2 2/3] dt-bindings: pwm: add IPQ6018 binding Baruch Siach 2021-05-24 10:20 ` Baruch Siach 2021-06-02 19:47 ` Rob Herring 2021-06-02 19:47 ` Rob Herring 2021-06-02 23:05 ` Bjorn Andersson [this message] 2021-06-02 23:05 ` Bjorn Andersson 2021-06-30 14:46 ` Kathiravan T 2021-05-24 10:20 ` [PATCH v2 3/3] arm64: dts: ipq6018: add pwm node Baruch Siach 2021-05-24 10:20 ` Baruch Siach 2021-05-24 14:48 ` [PATCH v2 1/3] pwm: driver for qualcomm ipq6018 pwm block kernel test robot 2021-05-24 14:48 ` kernel test robot 2021-05-24 16:08 ` kernel test robot 2021-05-24 16:08 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YLgO0Aj1d4w9EcPv@yoga \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=baruch@tkos.co.il \ --cc=bjagadee@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=robert.marko@sartura.hr \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.