From: Ming Lei <ming.lei@redhat.com> To: Jan Kara <jack@suse.cz> Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>, Dave Chinner <david@fromorbit.com>, ceph-devel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>, Damien Le Moal <damien.lemoal@wdc.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jaegeuk Kim <jaegeuk@kernel.org>, Jeff Layton <jlayton@kernel.org>, Johannes Thumshirn <jth@kernel.org>, linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>, Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>, Matthew Wilcox <willy@infradead.org>, Christoph Hellwig <hch@lst.de>, Hugh Dickins <hughd@google.com> Subject: Re: [PATCH 01/14] mm: Fix comments mentioning i_mutex Date: Thu, 10 Jun 2021 17:06:41 +0800 [thread overview] Message-ID: <YMHWIcbnLPW5AfiC@T590> (raw) In-Reply-To: <20210607145236.31852-1-jack@suse.cz> On Mon, Jun 07, 2021 at 04:52:11PM +0200, Jan Kara wrote: > inode->i_mutex has been replaced with inode->i_rwsem long ago. Fix > comments still mentioning i_mutex. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Hugh Dickins <hughd@google.com> > Signed-off-by: Jan Kara <jack@suse.cz> > --- ... > diff --git a/mm/rmap.c b/mm/rmap.c > index 693a610e181d..a35cbbbded0d 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -20,9 +20,9 @@ > /* > * Lock ordering in mm: > * > - * inode->i_mutex (while writing or truncating, not reading or faulting) > + * inode->i_rwsem (while writing or truncating, not reading or faulting) > * mm->mmap_lock > - * page->flags PG_locked (lock_page) * (see huegtlbfs below) > + * page->flags PG_locked (lock_page) * (see hugetlbfs below) > * hugetlbfs_i_mmap_rwsem_key (in huge_pmd_share) > * mapping->i_mmap_rwsem > * hugetlb_fault_mutex (hugetlbfs specific page fault mutex) > @@ -41,7 +41,7 @@ > * in arch-dependent flush_dcache_mmap_lock, > * within bdi.wb->list_lock in __sync_single_inode) > * > - * anon_vma->rwsem,mapping->i_mutex (memory_failure, collect_procs_anon) > + * anon_vma->rwsem,mapping->i_mmap_rwsem (memory_failure, collect_procs_anon) This one looks a typo. -- Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jan Kara <jack@suse.cz> Cc: linux-cifs@vger.kernel.org, Damien Le Moal <damien.lemoal@wdc.com>, linux-ext4@vger.kernel.org, Ted Tso <tytso@mit.edu>, Hugh Dickins <hughd@google.com>, "Darrick J. Wong" <darrick.wong@oracle.com>, Jeff Layton <jlayton@kernel.org>, Steve French <sfrench@samba.org>, Dave Chinner <david@fromorbit.com>, Matthew Wilcox <willy@infradead.org>, linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig <hch@infradead.org>, linux-mm@kvack.org, Miklos Szeredi <miklos@szeredi.hu>, linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>, ceph-devel@vger.kernel.org, Johannes Thumshirn <jth@kernel.org>, Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH 01/14] mm: Fix comments mentioning i_mutex Date: Thu, 10 Jun 2021 17:06:41 +0800 [thread overview] Message-ID: <YMHWIcbnLPW5AfiC@T590> (raw) In-Reply-To: <20210607145236.31852-1-jack@suse.cz> On Mon, Jun 07, 2021 at 04:52:11PM +0200, Jan Kara wrote: > inode->i_mutex has been replaced with inode->i_rwsem long ago. Fix > comments still mentioning i_mutex. > > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Hugh Dickins <hughd@google.com> > Signed-off-by: Jan Kara <jack@suse.cz> > --- ... > diff --git a/mm/rmap.c b/mm/rmap.c > index 693a610e181d..a35cbbbded0d 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -20,9 +20,9 @@ > /* > * Lock ordering in mm: > * > - * inode->i_mutex (while writing or truncating, not reading or faulting) > + * inode->i_rwsem (while writing or truncating, not reading or faulting) > * mm->mmap_lock > - * page->flags PG_locked (lock_page) * (see huegtlbfs below) > + * page->flags PG_locked (lock_page) * (see hugetlbfs below) > * hugetlbfs_i_mmap_rwsem_key (in huge_pmd_share) > * mapping->i_mmap_rwsem > * hugetlb_fault_mutex (hugetlbfs specific page fault mutex) > @@ -41,7 +41,7 @@ > * in arch-dependent flush_dcache_mmap_lock, > * within bdi.wb->list_lock in __sync_single_inode) > * > - * anon_vma->rwsem,mapping->i_mutex (memory_failure, collect_procs_anon) > + * anon_vma->rwsem,mapping->i_mmap_rwsem (memory_failure, collect_procs_anon) This one looks a typo. -- Ming _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-10 9:07 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 14:52 [PATCH 0/14 v7] fs: Hole punch vs page cache filling races Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:31 ` Darrick J. Wong 2021-06-07 15:31 ` [f2fs-dev] " Darrick J. Wong 2021-06-10 9:06 ` Ming Lei [this message] 2021-06-10 9:06 ` Ming Lei 2021-06-10 10:40 ` Jan Kara 2021-06-10 10:40 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 02/14] documentation: Sync file_operations members with reality Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 03/14] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 16:09 ` Darrick J. Wong 2021-06-07 16:09 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 12:19 ` Jan Kara 2021-06-08 12:19 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 04/14] mm: Add functions to lock invalidate_lock for two mappings Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:46 ` Darrick J. Wong 2021-06-07 15:46 ` [f2fs-dev] " Darrick J. Wong 2021-06-07 14:52 ` [PATCH 05/14] ext4: Convert to use mapping->invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 06/14] ext2: Convert to using invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 07/14] xfs: Refactor xfs_isilocked() Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:49 ` Darrick J. Wong 2021-06-07 15:49 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 22:18 ` Dave Chinner 2021-06-08 22:18 ` [f2fs-dev] " Dave Chinner 2021-06-07 14:52 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:56 ` Darrick J. Wong 2021-06-07 15:56 ` [f2fs-dev] " Darrick J. Wong 2021-06-08 12:23 ` Jan Kara 2021-06-08 12:23 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 15:57 ` Darrick J. Wong 2021-06-07 15:57 ` [f2fs-dev] " Darrick J. Wong 2021-06-07 14:52 ` [PATCH 10/14] zonefs: Convert to using invalidate_lock Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 11/14] f2fs: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 12/14] fuse: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-10 12:42 ` Miklos Szeredi 2021-06-10 12:42 ` [f2fs-dev] " Miklos Szeredi 2021-06-10 12:42 ` Miklos Szeredi 2021-06-07 14:52 ` [PATCH 13/14] ceph: Fix race between hole punch and page fault Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-07 14:52 ` [PATCH 14/14] cifs: " Jan Kara 2021-06-07 14:52 ` [f2fs-dev] " Jan Kara 2021-06-08 11:54 ` [PATCH 0/14 v7] fs: Hole punch vs page cache filling races Jan Kara 2021-06-08 11:54 ` [f2fs-dev] " Jan Kara 2021-06-15 9:17 [PATCH 0/14 v8] " Jan Kara 2021-06-15 9:17 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara 2021-07-12 16:55 [PATCH 0/14 v9] fs: Hole punch vs page cache filling races Jan Kara 2021-07-12 16:55 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara 2021-07-15 13:40 [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Jan Kara 2021-07-15 13:40 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YMHWIcbnLPW5AfiC@T590 \ --to=ming.lei@redhat.com \ --cc=ceph-devel@vger.kernel.org \ --cc=damien.lemoal@wdc.com \ --cc=darrick.wong@oracle.com \ --cc=david@fromorbit.com \ --cc=hch@infradead.org \ --cc=hch@lst.de \ --cc=hughd@google.com \ --cc=jack@suse.cz \ --cc=jaegeuk@kernel.org \ --cc=jlayton@kernel.org \ --cc=jth@kernel.org \ --cc=linux-cifs@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux-xfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ --cc=sfrench@samba.org \ --cc=tytso@mit.edu \ --cc=willy@infradead.org \ --cc=yuchao0@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.