All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Daniel Axtens <dja@axtens.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kasan-dev@googlegroups.com, elver@google.com,
	akpm@linux-foundation.org, andreyknvl@gmail.com,
	linuxppc-dev@lists.ozlabs.org, christophe.leroy@csgroup.eu,
	aneesh.kumar@linux.ibm.com
Subject: Re: [PATCH v15 0/4] KASAN core changes for ppc64 radix KASAN
Date: Fri, 18 Jun 2021 00:04:31 +1000	[thread overview]
Message-ID: <YMtWb2HJx44HdgQC@balbir-desktop> (raw)
In-Reply-To: <20210617093032.103097-1-dja@axtens.net>

On Thu, Jun 17, 2021 at 07:30:28PM +1000, Daniel Axtens wrote:
> Building on the work of Christophe, Aneesh and Balbir, I've ported
> KASAN to 64-bit Book3S kernels running on the Radix MMU. I've been
> trying this for a while, but we keep having collisions between the
> kasan code in the mm tree and the code I want to put in to the ppc
> tree.
> 
> This series just contains the kasan core changes that we need. These
> can go in via the mm tree. I will then propose the powerpc changes for
> a later cycle. (The most recent RFC for the powerpc changes is in the
> v12 series at
> https://lore.kernel.org/linux-mm/20210615014705.2234866-1-dja@axtens.net/
> )
> 
> v15 applies to next-20210611. There should be no noticeable changes to
> other platforms.
> 
> Changes since v14: Included a bunch of Reviewed-by:s, thanks
> Christophe and Marco. Cleaned up the build time error #ifdefs, thanks
> Christophe.
> 
> Changes since v13: move the MAX_PTR_PER_* definitions out of kasan and
> into pgtable.h. Add a build time error to hopefully prevent any
> confusion about when the new hook is applicable. Thanks Marco and
> Christophe.
> 
> Changes since v12: respond to Marco's review comments - clean up the
> help for ARCH_DISABLE_KASAN_INLINE, and add an arch readiness check to
> the new granule poisioning function. Thanks Marco.
> 
> Daniel Axtens (4):
>   kasan: allow an architecture to disable inline instrumentation
>   kasan: allow architectures to provide an outline readiness check
>   mm: define default MAX_PTRS_PER_* in include/pgtable.h
>   kasan: use MAX_PTRS_PER_* for early shadow tables
> 

The series seems reasonable

Reviewed-by: Balbir Singh <bsingharora@gmail.com>

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: Daniel Axtens <dja@axtens.net>
Cc: elver@google.com, aneesh.kumar@linux.ibm.com,
	linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-mm@kvack.org, akpm@linux-foundation.org,
	linuxppc-dev@lists.ozlabs.org, andreyknvl@gmail.com
Subject: Re: [PATCH v15 0/4] KASAN core changes for ppc64 radix KASAN
Date: Fri, 18 Jun 2021 00:04:31 +1000	[thread overview]
Message-ID: <YMtWb2HJx44HdgQC@balbir-desktop> (raw)
In-Reply-To: <20210617093032.103097-1-dja@axtens.net>

On Thu, Jun 17, 2021 at 07:30:28PM +1000, Daniel Axtens wrote:
> Building on the work of Christophe, Aneesh and Balbir, I've ported
> KASAN to 64-bit Book3S kernels running on the Radix MMU. I've been
> trying this for a while, but we keep having collisions between the
> kasan code in the mm tree and the code I want to put in to the ppc
> tree.
> 
> This series just contains the kasan core changes that we need. These
> can go in via the mm tree. I will then propose the powerpc changes for
> a later cycle. (The most recent RFC for the powerpc changes is in the
> v12 series at
> https://lore.kernel.org/linux-mm/20210615014705.2234866-1-dja@axtens.net/
> )
> 
> v15 applies to next-20210611. There should be no noticeable changes to
> other platforms.
> 
> Changes since v14: Included a bunch of Reviewed-by:s, thanks
> Christophe and Marco. Cleaned up the build time error #ifdefs, thanks
> Christophe.
> 
> Changes since v13: move the MAX_PTR_PER_* definitions out of kasan and
> into pgtable.h. Add a build time error to hopefully prevent any
> confusion about when the new hook is applicable. Thanks Marco and
> Christophe.
> 
> Changes since v12: respond to Marco's review comments - clean up the
> help for ARCH_DISABLE_KASAN_INLINE, and add an arch readiness check to
> the new granule poisioning function. Thanks Marco.
> 
> Daniel Axtens (4):
>   kasan: allow an architecture to disable inline instrumentation
>   kasan: allow architectures to provide an outline readiness check
>   mm: define default MAX_PTRS_PER_* in include/pgtable.h
>   kasan: use MAX_PTRS_PER_* for early shadow tables
> 

The series seems reasonable

Reviewed-by: Balbir Singh <bsingharora@gmail.com>

  parent reply	other threads:[~2021-06-17 14:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-17  9:30 [PATCH v15 0/4] KASAN core changes for ppc64 radix KASAN Daniel Axtens
2021-06-17  9:30 ` Daniel Axtens
2021-06-17  9:30 ` [PATCH v15 1/4] kasan: allow an architecture to disable inline instrumentation Daniel Axtens
2021-06-17  9:30   ` Daniel Axtens
2021-06-20 11:15   ` Andrey Konovalov
2021-06-20 11:15     ` Andrey Konovalov
2021-06-20 11:15     ` Andrey Konovalov
2021-06-17  9:30 ` [PATCH v15 2/4] kasan: allow architectures to provide an outline readiness check Daniel Axtens
2021-06-17  9:30   ` Daniel Axtens
2021-06-20 11:16   ` Andrey Konovalov
2021-06-20 11:16     ` Andrey Konovalov
2021-06-20 11:16     ` Andrey Konovalov
2021-06-23  9:25     ` Daniel Axtens
2021-06-23  9:25       ` Daniel Axtens
2021-06-17  9:30 ` [PATCH v15 3/4] mm: define default MAX_PTRS_PER_* in include/pgtable.h Daniel Axtens
2021-06-17  9:30   ` Daniel Axtens
2021-06-20 11:17   ` Andrey Konovalov
2021-06-20 11:17     ` Andrey Konovalov
2021-06-20 11:17     ` Andrey Konovalov
2021-06-17  9:30 ` [PATCH v15 4/4] kasan: use MAX_PTRS_PER_* for early shadow tables Daniel Axtens
2021-06-17  9:30   ` Daniel Axtens
2021-06-20 11:17   ` Andrey Konovalov
2021-06-20 11:17     ` Andrey Konovalov
2021-06-20 11:17     ` Andrey Konovalov
2021-06-17 14:04 ` Balbir Singh [this message]
2021-06-17 14:04   ` [PATCH v15 0/4] KASAN core changes for ppc64 radix KASAN Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMtWb2HJx44HdgQC@balbir-desktop \
    --to=bsingharora@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dja@axtens.net \
    --cc=elver@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.