Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats

From: David Matlack <dmatlack@google.com>
To: Jing Zhang <jingzhangos@google.com>
Cc: KVM <kvm@vger.kernel.org>, KVMPPC <kvm-ppc@vger.kernel.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>,
	Jim Mattson <jmattson@google.com>,
	Peter Shier <pshier@google.com>, Oliver Upton <oupton@google.com>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v1 4/4] KVM: stats: Add halt polling related histogram stats
Date: Fri, 9 Jul 2021 15:25:49 +0000	[thread overview]
Message-ID: <YOhqfXMVSaGkJkAe@google.com> (raw)
In-Reply-To: <CAAdAUti1C0s6b4acDeLHQqbFgswiwuUZNN+mVc4Zeh8_ZTRNzQ@mail.gmail.com>

On Fri, Jul 09, 2021 at 10:18:20AM -0500, Jing Zhang wrote:
> On Thu, Jul 8, 2021 at 4:42 PM David Matlack <dmatlack@google.com> wrote:
> >
> > On Tue, Jul 06, 2021 at 06:03:50PM +0000, Jing Zhang wrote:
> > >
> > > diff --git a/arch/powerpc/include/asm/kvm_host.h b/arch/powerpc/include/asm/kvm_host.h
> > > index 9f52f282b1aa..4931d03e5799 100644
> > > --- a/arch/powerpc/include/asm/kvm_host.h
> > > +++ b/arch/powerpc/include/asm/kvm_host.h
> > > @@ -103,7 +103,6 @@ struct kvm_vcpu_stat {
> > >       u64 emulated_inst_exits;
> > >       u64 dec_exits;
> > >       u64 ext_intr_exits;
> > > -     u64 halt_wait_ns;
> >
> > The halt_wait_ns refactor should be a separate patch.
> >
> How about putting it into a separate commit? Just want to keep all
> halt related change in the
> same patch series.

I think we're on the same page: move the halt_wait_ns changes to a
separate patch but still part of this series.