From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
Satya Tangirala <satyaprateek2357@gmail.com>,
Changheun Lee <nanich.lee@samsung.com>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>
Subject: Re: [PATCH 2/9] f2fs: remove allow_outplace_dio()
Date: Mon, 19 Jul 2021 09:41:11 +0100 [thread overview]
Message-ID: <YPU6pz2WoYAW3iDJ@infradead.org> (raw)
In-Reply-To: <20210716143919.44373-3-ebiggers@kernel.org>
On Fri, Jul 16, 2021 at 09:39:12AM -0500, Eric Biggers wrote:
> + do_opu = (rw == WRITE && f2fs_lfs_mode(sbi));
Nit: no need for the braces.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Satya Tangirala <satyaprateek2357@gmail.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
Changheun Lee <nanich.lee@samsung.com>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>
Subject: Re: [f2fs-dev] [PATCH 2/9] f2fs: remove allow_outplace_dio()
Date: Mon, 19 Jul 2021 09:41:11 +0100 [thread overview]
Message-ID: <YPU6pz2WoYAW3iDJ@infradead.org> (raw)
In-Reply-To: <20210716143919.44373-3-ebiggers@kernel.org>
On Fri, Jul 16, 2021 at 09:39:12AM -0500, Eric Biggers wrote:
> + do_opu = (rw == WRITE && f2fs_lfs_mode(sbi));
Nit: no need for the braces.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-07-19 9:08 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-16 14:39 [PATCH 0/9] f2fs: use iomap for direct I/O Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 1/9] f2fs: make f2fs_write_failed() take struct inode Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-25 10:00 ` Chao Yu
2021-07-25 10:00 ` [f2fs-dev] " Chao Yu
2021-07-16 14:39 ` [PATCH 2/9] f2fs: remove allow_outplace_dio() Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-19 8:41 ` Christoph Hellwig [this message]
2021-07-19 8:41 ` Christoph Hellwig
2021-07-16 14:39 ` [PATCH 3/9] f2fs: rework write preallocations Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-25 10:50 ` Chao Yu
2021-07-25 10:50 ` [f2fs-dev] " Chao Yu
2021-07-25 17:57 ` Eric Biggers
2021-07-25 17:57 ` [f2fs-dev] " Eric Biggers
2021-07-27 2:00 ` Jaegeuk Kim
2021-07-27 2:00 ` [f2fs-dev] " Jaegeuk Kim
2021-07-27 3:23 ` Chao Yu
2021-07-27 3:23 ` [f2fs-dev] " Chao Yu
2021-07-27 7:38 ` Eric Biggers
2021-07-27 7:38 ` [f2fs-dev] " Eric Biggers
2021-07-27 8:30 ` Chao Yu
2021-07-27 8:30 ` [f2fs-dev] " Chao Yu
2021-07-27 15:33 ` Darrick J. Wong
2021-07-27 15:33 ` [f2fs-dev] " Darrick J. Wong
2021-07-29 0:26 ` Chao Yu
2021-07-29 0:26 ` [f2fs-dev] " Chao Yu
2021-07-28 2:29 ` Jaegeuk Kim
2021-07-28 2:29 ` [f2fs-dev] " Jaegeuk Kim
2021-07-25 15:35 ` Jaegeuk Kim
2021-07-25 15:35 ` [f2fs-dev] " Jaegeuk Kim
2021-07-25 15:47 ` Jaegeuk Kim
2021-07-25 15:47 ` [f2fs-dev] " Jaegeuk Kim
2021-07-25 18:01 ` Eric Biggers
2021-07-25 18:01 ` [f2fs-dev] " Eric Biggers
2021-07-26 19:04 ` Jaegeuk Kim
2021-07-26 19:04 ` [f2fs-dev] " Jaegeuk Kim
2021-07-16 14:39 ` [PATCH 4/9] f2fs: reduce indentation in f2fs_file_write_iter() Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 5/9] f2fs: fix the f2fs_file_write_iter tracepoint Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 6/9] f2fs: implement iomap operations Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-19 8:59 ` Christoph Hellwig
2021-07-19 8:59 ` [f2fs-dev] " Christoph Hellwig
2021-07-22 20:47 ` Jaegeuk Kim
2021-07-22 20:47 ` [f2fs-dev] " Jaegeuk Kim
2021-07-22 20:49 ` Jaegeuk Kim
2021-07-22 20:49 ` [f2fs-dev] " Jaegeuk Kim
2021-07-22 20:54 ` Eric Biggers
2021-07-22 20:54 ` [f2fs-dev] " Eric Biggers
2021-07-22 21:57 ` Jaegeuk Kim
2021-07-22 21:57 ` [f2fs-dev] " Jaegeuk Kim
2021-07-23 1:52 ` Eric Biggers
2021-07-23 1:52 ` [f2fs-dev] " Eric Biggers
2021-07-23 5:00 ` Christoph Hellwig
2021-07-23 5:00 ` [f2fs-dev] " Christoph Hellwig
2021-07-23 8:05 ` Eric Biggers
2021-07-23 8:05 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 7/9] f2fs: use iomap for direct I/O reads Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 8/9] f2fs: use iomap for direct I/O writes Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
2021-07-16 14:39 ` [PATCH 9/9] f2fs: remove f2fs_direct_IO() Eric Biggers
2021-07-16 14:39 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPU6pz2WoYAW3iDJ@infradead.org \
--to=hch@infradead.org \
--cc=chao@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
--cc=nanich.lee@samsung.com \
--cc=satyaprateek2357@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.