All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] meson: fix dependencies for modinfo
@ 2021-07-21 16:52 Paolo Bonzini
  2021-07-21 16:53 ` Daniel P. Berrangé
  0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-07-21 16:52 UTC (permalink / raw)
  To: qemu-devel; +Cc: berrange

modinfo runs the preprocessor and therefore needs all generated input files
to be there.  Add a "depends" clause.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meson.build b/meson.build
index 8817706d08..18e6cb0a8c 100644
--- a/meson.build
+++ b/meson.build
@@ -2512,6 +2512,7 @@ foreach d, list : modules
                                        output: d + '-' + m + '.modinfo',
                                        input: module_ss.sources(),
                                        capture: true,
+                                       depends: genh,
                                        command: [modinfo_collect, '@INPUT@'])
       endif
     else
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] meson: fix dependencies for modinfo
  2021-07-21 16:52 [PATCH] meson: fix dependencies for modinfo Paolo Bonzini
@ 2021-07-21 16:53 ` Daniel P. Berrangé
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2021-07-21 16:53 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel

On Wed, Jul 21, 2021 at 06:52:06PM +0200, Paolo Bonzini wrote:
> modinfo runs the preprocessor and therefore needs all generated input files
> to be there.  Add a "depends" clause.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-21 16:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 16:52 [PATCH] meson: fix dependencies for modinfo Paolo Bonzini
2021-07-21 16:53 ` Daniel P. Berrangé

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.