From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>, Abhinav Kumar <abhinavk@codeaurora.org>, Jonathan Marek <jonathan@marek.ca>, Stephen Boyd <sboyd@kernel.org>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v4 6/7] drm/msm/dsi: stop calling set_encoder_mode callback Date: Sat, 24 Jul 2021 23:08:40 -0500 [thread overview] Message-ID: <YPzjyF0M6IzFVqh3@yoga> (raw) In-Reply-To: <20210717124016.316020-7-dmitry.baryshkov@linaro.org> On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/gpu/drm/msm/dsi/dsi.c | 2 -- > drivers/gpu/drm/msm/dsi/dsi.h | 1 - > drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 ------------ > 3 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 5201d7eb0490..77c8dba297d8 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -251,8 +251,6 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev, > goto fail; > } > > - msm_dsi_manager_setup_encoder(msm_dsi->id); > - > priv->bridges[priv->num_bridges++] = msm_dsi->bridge; > priv->connectors[priv->num_connectors++] = msm_dsi->connector; > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h > index 856a532850c0..e0c3c4409377 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.h > +++ b/drivers/gpu/drm/msm/dsi/dsi.h > @@ -80,7 +80,6 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id); > struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id); > int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg); > bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len); > -void msm_dsi_manager_setup_encoder(int id); > int msm_dsi_manager_register(struct msm_dsi *msm_dsi); > void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi); > bool msm_dsi_manager_validate_current_config(u8 id); > diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c > index 27d3b9ebf831..693078e68fd4 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c > @@ -216,18 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge) > return dsi_bridge->id; > } > > -void msm_dsi_manager_setup_encoder(int id) > -{ > - struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); > - struct msm_drm_private *priv = msm_dsi->dev->dev_private; > - struct msm_kms *kms = priv->kms; > - struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi); > - > - if (encoder && kms->funcs->set_encoder_mode) > - kms->funcs->set_encoder_mode(kms, encoder, > - msm_dsi_is_cmd_mode(msm_dsi)); > -} > - > static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) > { > struct msm_drm_private *priv = conn->dev->dev_private; > -- > 2.30.2 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: freedreno@lists.freedesktop.org, Jonathan Marek <jonathan@marek.ca>, Stephen Boyd <sboyd@kernel.org>, linux-arm-msm@vger.kernel.org, Abhinav Kumar <abhinavk@codeaurora.org>, David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org, Sean Paul <sean@poorly.run> Subject: Re: [PATCH v4 6/7] drm/msm/dsi: stop calling set_encoder_mode callback Date: Sat, 24 Jul 2021 23:08:40 -0500 [thread overview] Message-ID: <YPzjyF0M6IzFVqh3@yoga> (raw) In-Reply-To: <20210717124016.316020-7-dmitry.baryshkov@linaro.org> On Sat 17 Jul 07:40 CDT 2021, Dmitry Baryshkov wrote: > None of the display drivers now implement set_encoder_mode callback. > Stop calling it from the modeset init code. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/gpu/drm/msm/dsi/dsi.c | 2 -- > drivers/gpu/drm/msm/dsi/dsi.h | 1 - > drivers/gpu/drm/msm/dsi/dsi_manager.c | 12 ------------ > 3 files changed, 15 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c > index 5201d7eb0490..77c8dba297d8 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.c > +++ b/drivers/gpu/drm/msm/dsi/dsi.c > @@ -251,8 +251,6 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev, > goto fail; > } > > - msm_dsi_manager_setup_encoder(msm_dsi->id); > - > priv->bridges[priv->num_bridges++] = msm_dsi->bridge; > priv->connectors[priv->num_connectors++] = msm_dsi->connector; > > diff --git a/drivers/gpu/drm/msm/dsi/dsi.h b/drivers/gpu/drm/msm/dsi/dsi.h > index 856a532850c0..e0c3c4409377 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi.h > +++ b/drivers/gpu/drm/msm/dsi/dsi.h > @@ -80,7 +80,6 @@ struct drm_connector *msm_dsi_manager_connector_init(u8 id); > struct drm_connector *msm_dsi_manager_ext_bridge_init(u8 id); > int msm_dsi_manager_cmd_xfer(int id, const struct mipi_dsi_msg *msg); > bool msm_dsi_manager_cmd_xfer_trigger(int id, u32 dma_base, u32 len); > -void msm_dsi_manager_setup_encoder(int id); > int msm_dsi_manager_register(struct msm_dsi *msm_dsi); > void msm_dsi_manager_unregister(struct msm_dsi *msm_dsi); > bool msm_dsi_manager_validate_current_config(u8 id); > diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c > index 27d3b9ebf831..693078e68fd4 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c > @@ -216,18 +216,6 @@ static int dsi_mgr_bridge_get_id(struct drm_bridge *bridge) > return dsi_bridge->id; > } > > -void msm_dsi_manager_setup_encoder(int id) > -{ > - struct msm_dsi *msm_dsi = dsi_mgr_get_dsi(id); > - struct msm_drm_private *priv = msm_dsi->dev->dev_private; > - struct msm_kms *kms = priv->kms; > - struct drm_encoder *encoder = msm_dsi_get_encoder(msm_dsi); > - > - if (encoder && kms->funcs->set_encoder_mode) > - kms->funcs->set_encoder_mode(kms, encoder, > - msm_dsi_is_cmd_mode(msm_dsi)); > -} > - > static int msm_dsi_manager_panel_init(struct drm_connector *conn, u8 id) > { > struct msm_drm_private *priv = conn->dev->dev_private; > -- > 2.30.2 >
next prev parent reply other threads:[~2021-07-25 4:08 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-17 12:40 [PATCH v4 0/7] drm/msm/dpu: add support for independent DSI config Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-17 12:40 ` [PATCH v4 1/7] drm/msm/dsi: rename dual DSI to bonded DSI Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-23 3:07 ` Bjorn Andersson 2021-07-23 3:07 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 2/7] drm/msm/dsi: add three helper functions Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-19 10:31 ` kernel test robot 2021-07-19 10:31 ` kernel test robot 2021-07-25 4:05 ` Bjorn Andersson 2021-07-25 4:05 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 3/7] drm/msm/dpu: support setting up two independent DSI connectors Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-25 4:06 ` Bjorn Andersson 2021-07-25 4:06 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 4/7] drm/msm/mdp5: move mdp5_encoder_set_intf_mode after msm_dsi_modeset_init Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-25 4:07 ` Bjorn Andersson 2021-07-25 4:07 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 5/7] drm/msm/dp: stop calling set_encoder_mode callback Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-25 4:08 ` Bjorn Andersson 2021-07-25 4:08 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 6/7] drm/msm/dsi: " Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-25 4:08 ` Bjorn Andersson [this message] 2021-07-25 4:08 ` Bjorn Andersson 2021-07-17 12:40 ` [PATCH v4 7/7] drm/msm/kms: drop " Dmitry Baryshkov 2021-07-17 12:40 ` Dmitry Baryshkov 2021-07-25 4:09 ` Bjorn Andersson 2021-07-25 4:09 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YPzjyF0M6IzFVqh3@yoga \ --to=bjorn.andersson@linaro.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=sboyd@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.