From: Heiko Carstens <hca@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Hellwig <hch@infradead.org>,
Feng Tang <feng.tang@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls
Date: Tue, 27 Jul 2021 19:27:19 +0200 [thread overview]
Message-ID: <YQBB9yteAwtG2xyp@osiris> (raw)
In-Reply-To: <20210727144859.4150043-5-arnd@kernel.org>
On Tue, Jul 27, 2021 at 04:48:57PM +0200, Arnd Bergmann wrote:
> ---
> include/linux/compat.h | 17 ++--
> mm/mempolicy.c | 175 +++++++++++++----------------------------
> 2 files changed, 63 insertions(+), 129 deletions(-)
...
> +static int get_bitmap(unsigned long *mask, const unsigned long __user *nmask,
> + unsigned long maxnode)
> +{
> + unsigned long nlongs = BITS_TO_LONGS(maxnode);
> + int ret;
> +
> + if (in_compat_syscall())
> + ret = compat_get_bitmap(mask,
> + (const compat_ulong_t __user *)nmask,
> + maxnode);
compat_ptr() conversion for e.g. nmask is missing with the next patch
which removes the compat system calls.
Is that intended or am I missing something?
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Feng Tang <feng.tang@intel.com>,
linux-mips@vger.kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-mm@kvack.org, Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, Will Deacon <will@kernel.org>,
Christoph Hellwig <hch@lst.de>,
linux-arch@vger.kernel.org, linux-s390@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Helge Deller <deller@gmx.de>,
x86@kernel.org, Christoph Hellwig <hch@infradead.org>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Ingo Molnar <mingo@redhat.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vasily Gorbik <gor@linux.ibm.com>, Borislav Petkov <bp@alien8.de>,
Al Viro <viro@zeniv.linux.org.uk>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Eric W. Biederman" <ebiederm@xmission.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls
Date: Tue, 27 Jul 2021 19:27:19 +0200 [thread overview]
Message-ID: <YQBB9yteAwtG2xyp@osiris> (raw)
In-Reply-To: <20210727144859.4150043-5-arnd@kernel.org>
On Tue, Jul 27, 2021 at 04:48:57PM +0200, Arnd Bergmann wrote:
> ---
> include/linux/compat.h | 17 ++--
> mm/mempolicy.c | 175 +++++++++++++----------------------------
> 2 files changed, 63 insertions(+), 129 deletions(-)
...
> +static int get_bitmap(unsigned long *mask, const unsigned long __user *nmask,
> + unsigned long maxnode)
> +{
> + unsigned long nlongs = BITS_TO_LONGS(maxnode);
> + int ret;
> +
> + if (in_compat_syscall())
> + ret = compat_get_bitmap(mask,
> + (const compat_ulong_t __user *)nmask,
> + maxnode);
compat_ptr() conversion for e.g. nmask is missing with the next patch
which removes the compat system calls.
Is that intended or am I missing something?
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <hca@linux.ibm.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
Helge Deller <deller@gmx.de>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Christoph Hellwig <hch@infradead.org>,
Feng Tang <feng.tang@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 4/6] mm: simplify compat numa syscalls
Date: Tue, 27 Jul 2021 19:27:19 +0200 [thread overview]
Message-ID: <YQBB9yteAwtG2xyp@osiris> (raw)
In-Reply-To: <20210727144859.4150043-5-arnd@kernel.org>
On Tue, Jul 27, 2021 at 04:48:57PM +0200, Arnd Bergmann wrote:
> ---
> include/linux/compat.h | 17 ++--
> mm/mempolicy.c | 175 +++++++++++++----------------------------
> 2 files changed, 63 insertions(+), 129 deletions(-)
...
> +static int get_bitmap(unsigned long *mask, const unsigned long __user *nmask,
> + unsigned long maxnode)
> +{
> + unsigned long nlongs = BITS_TO_LONGS(maxnode);
> + int ret;
> +
> + if (in_compat_syscall())
> + ret = compat_get_bitmap(mask,
> + (const compat_ulong_t __user *)nmask,
> + maxnode);
compat_ptr() conversion for e.g. nmask is missing with the next patch
which removes the compat system calls.
Is that intended or am I missing something?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-27 17:29 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 14:48 [PATCH v5 0/6] compat: remove compat_alloc_user_space Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 1/6] kexec: move locking into do_kexec_load Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-28 16:09 ` Eric W. Biederman
2021-07-28 16:09 ` Eric W. Biederman
2021-07-28 16:09 ` Eric W. Biederman
2021-07-28 16:09 ` Eric W. Biederman
2021-07-27 14:48 ` [PATCH v5 2/6] kexec: avoid compat_alloc_user_space Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-28 16:10 ` Eric W. Biederman
2021-07-28 16:10 ` Eric W. Biederman
2021-07-28 16:10 ` Eric W. Biederman
2021-07-28 16:10 ` Eric W. Biederman
2021-07-27 14:48 ` [PATCH v5 3/6] mm: simplify compat_sys_move_pages Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 4/6] mm: simplify compat numa syscalls Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 17:27 ` Heiko Carstens [this message]
2021-07-27 17:27 ` Heiko Carstens
2021-07-27 17:27 ` Heiko Carstens
2021-07-27 17:40 ` Arnd Bergmann
2021-07-27 17:40 ` Arnd Bergmann
2021-07-27 17:40 ` Arnd Bergmann
2021-07-27 17:40 ` Arnd Bergmann
2021-07-27 18:38 ` Heiko Carstens
2021-07-27 18:38 ` Heiko Carstens
2021-07-27 18:38 ` Heiko Carstens
2021-07-27 18:49 ` Arnd Bergmann
2021-07-27 18:49 ` Arnd Bergmann
2021-07-27 18:49 ` Arnd Bergmann
2021-07-27 18:49 ` Arnd Bergmann
2021-07-27 19:15 ` Heiko Carstens
2021-07-27 19:15 ` Heiko Carstens
2021-07-27 19:15 ` Heiko Carstens
2021-07-27 14:48 ` [PATCH v5 5/6] compat: remove some compat entry points Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` [PATCH v5 6/6] arch: remove compat_alloc_user_space Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 14:48 ` Arnd Bergmann
2021-07-27 15:09 ` Christoph Hellwig
2021-07-27 15:09 ` Christoph Hellwig
2021-07-27 15:09 ` Christoph Hellwig
2021-07-27 14:59 ` [PATCH v5 0/6] compat: " Christoph Hellwig
2021-07-27 14:59 ` Christoph Hellwig
2021-07-27 14:59 ` Christoph Hellwig
2021-07-27 20:10 ` Andrew Morton
2021-07-27 20:10 ` Andrew Morton
2021-07-27 20:10 ` Andrew Morton
2021-07-27 20:42 ` Arnd Bergmann
2021-07-27 20:42 ` Arnd Bergmann
2021-07-27 20:42 ` Arnd Bergmann
2021-07-27 20:42 ` Arnd Bergmann
2021-07-30 9:49 ` Heiko Carstens
2021-07-30 9:49 ` Heiko Carstens
2021-07-30 9:49 ` Heiko Carstens
2021-07-30 13:35 ` Arnd Bergmann
2021-07-30 13:35 ` Arnd Bergmann
2021-07-30 13:35 ` Arnd Bergmann
2021-07-30 13:35 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQBB9yteAwtG2xyp@osiris \
--to=hca@linux.ibm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=gor@linux.ibm.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.