All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Michal Hocko <mhocko@kernel.org>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: unexport {,un}lock_page_memcg
Date: Fri, 20 Aug 2021 09:58:53 -0400	[thread overview]
Message-ID: <YR+1HfvIJ2K53flA@cmpxchg.org> (raw)
In-Reply-To: <20210820095815.445392-3-hch@lst.de>

On Fri, Aug 20, 2021 at 11:58:15AM +0200, Christoph Hellwig wrote:
> These are only used in built-in core mm code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Good catch.

It was initially exported for xfs dirtying, and is no longer needed
after that switched to iomap (and now __set_page_dirty_nobuffers).

Acked-by: Johannes Weiner <hannes@cmpxchg.org>


WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: Michal Hocko <mhocko-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Vladimir Davydov
	<vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH 2/2] mm: unexport {,un}lock_page_memcg
Date: Fri, 20 Aug 2021 09:58:53 -0400	[thread overview]
Message-ID: <YR+1HfvIJ2K53flA@cmpxchg.org> (raw)
In-Reply-To: <20210820095815.445392-3-hch-jcswGhMUV9g@public.gmane.org>

On Fri, Aug 20, 2021 at 11:58:15AM +0200, Christoph Hellwig wrote:
> These are only used in built-in core mm code.
> 
> Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>

Good catch.

It was initially exported for xfs dirtying, and is no longer needed
after that switched to iomap (and now __set_page_dirty_nobuffers).

Acked-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>

  reply	other threads:[~2021-08-20 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20  9:58 unexport memcg locking helpers Christoph Hellwig
2021-08-20  9:58 ` [PATCH 1/2] mm: unexport folio_memcg_{,un}lock Christoph Hellwig
2021-08-20  9:58   ` Christoph Hellwig
2021-08-20  9:58 ` [PATCH 2/2] mm: unexport {,un}lock_page_memcg Christoph Hellwig
2021-08-20  9:58   ` Christoph Hellwig
2021-08-20 13:58   ` Johannes Weiner [this message]
2021-08-20 13:58     ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR+1HfvIJ2K53flA@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@lst.de \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=vdavydov.dev@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.