From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
George McCollister <george.mccollister@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksij Rempel <linux@rempel-privat.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers
Date: Mon, 13 Sep 2021 15:10:31 +0200 [thread overview]
Message-ID: <YT9Nx9hvSnRYmJ4Q@lunn.ch> (raw)
In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com>
On Sun, Sep 12, 2021 at 03:09:28PM +0300, Vladimir Oltean wrote:
> MDIO-attached devices might have interrupts and other things that might
> need quiesced when we kexec into a new kernel. Things are even more
> creepy when those interrupt lines are shared, and in that case it is
> absolutely mandatory to disable all interrupt sources.
>
> Moreover, MDIO devices might be DSA switches, and DSA needs its own
> shutdown method to unlink from the DSA master, which is a new
> requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link
> interfaces with the DSA master to get rid of lockdep warnings").
>
> So introduce a ->shutdown method in the MDIO device driver structure.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
George McCollister <george.mccollister@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksij Rempel <linux@rempel-privat.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers
Date: Mon, 13 Sep 2021 15:10:31 +0200 [thread overview]
Message-ID: <YT9Nx9hvSnRYmJ4Q@lunn.ch> (raw)
In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com>
On Sun, Sep 12, 2021 at 03:09:28PM +0300, Vladimir Oltean wrote:
> MDIO-attached devices might have interrupts and other things that might
> need quiesced when we kexec into a new kernel. Things are even more
> creepy when those interrupt lines are shared, and in that case it is
> absolutely mandatory to disable all interrupt sources.
>
> Moreover, MDIO devices might be DSA switches, and DSA needs its own
> shutdown method to unlink from the DSA master, which is a new
> requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link
> interfaces with the DSA master to get rid of lockdep warnings").
>
> So introduce a ->shutdown method in the MDIO device driver structure.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Kurt Kanzenbach <kurt@linutronix.de>,
Hauke Mehrtens <hauke@hauke-m.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Sean Wang <sean.wang@mediatek.com>,
Landen Chao <Landen.Chao@mediatek.com>,
DENG Qingfang <dqfext@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Linus Walleij <linus.walleij@linaro.org>,
George McCollister <george.mccollister@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Oleksij Rempel <linux@rempel-privat.de>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Lino Sanfilippo <LinoSanfilippo@gmx.de>
Subject: Re: [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers
Date: Mon, 13 Sep 2021 15:10:31 +0200 [thread overview]
Message-ID: <YT9Nx9hvSnRYmJ4Q@lunn.ch> (raw)
In-Reply-To: <20210912120932.993440-2-vladimir.oltean@nxp.com>
On Sun, Sep 12, 2021 at 03:09:28PM +0300, Vladimir Oltean wrote:
> MDIO-attached devices might have interrupts and other things that might
> need quiesced when we kexec into a new kernel. Things are even more
> creepy when those interrupt lines are shared, and in that case it is
> absolutely mandatory to disable all interrupt sources.
>
> Moreover, MDIO devices might be DSA switches, and DSA needs its own
> shutdown method to unlink from the DSA master, which is a new
> requirement that appeared after commit 2f1e8ea726e9 ("net: dsa: link
> interfaces with the DSA master to get rid of lockdep warnings").
>
> So introduce a ->shutdown method in the MDIO device driver structure.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-13 13:11 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 12:09 [RFC PATCH net 0/5] Make DSA switch drivers compatible with masters which unregister on shutdown Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` [RFC PATCH net 1/5] net: mdio: introduce a shutdown method to mdio device drivers Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 16:14 ` Florian Fainelli
2021-09-12 16:14 ` Florian Fainelli
2021-09-12 16:14 ` Florian Fainelli
2021-09-13 13:10 ` Andrew Lunn [this message]
2021-09-13 13:10 ` Andrew Lunn
2021-09-13 13:10 ` Andrew Lunn
2021-09-12 12:09 ` [RFC PATCH net 2/5] net: dsa: be compatible with masters which unregister on shutdown Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 13:18 ` Vladimir Oltean
2021-09-12 13:18 ` Vladimir Oltean
2021-09-12 13:18 ` Vladimir Oltean
2021-09-13 13:23 ` Andrew Lunn
2021-09-13 13:23 ` Andrew Lunn
2021-09-13 13:23 ` Andrew Lunn
2021-09-13 13:31 ` Vladimir Oltean
2021-09-13 13:31 ` Vladimir Oltean
2021-09-13 13:31 ` Vladimir Oltean
2021-09-13 13:34 ` Andrew Lunn
2021-09-13 13:34 ` Andrew Lunn
2021-09-13 13:34 ` Andrew Lunn
2021-09-14 1:30 ` Andrew Lunn
2021-09-14 1:30 ` Andrew Lunn
2021-09-14 1:30 ` Andrew Lunn
2021-09-12 16:17 ` kernel test robot
2021-09-12 16:30 ` kernel test robot
2021-09-12 16:30 ` kernel test robot
2021-09-13 16:56 ` Florian Fainelli
2021-09-13 16:56 ` Florian Fainelli
2021-09-13 16:56 ` Florian Fainelli
2021-09-12 12:09 ` [RFC PATCH net 3/5] net: dsa: hellcreek: " Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-13 16:50 ` Florian Fainelli
2021-09-13 16:50 ` Florian Fainelli
2021-09-13 16:50 ` Florian Fainelli
2021-09-14 8:08 ` Kurt Kanzenbach
2021-09-14 8:08 ` Kurt Kanzenbach
2021-09-14 8:08 ` Kurt Kanzenbach
2021-09-12 12:09 ` [RFC PATCH net 4/5] net: dsa: microchip: ksz8863: " Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-13 16:51 ` Florian Fainelli
2021-09-13 16:51 ` Florian Fainelli
2021-09-13 16:51 ` Florian Fainelli
2021-09-12 12:09 ` [RFC PATCH net 5/5] net: dsa: xrs700x: " Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-12 12:09 ` Vladimir Oltean
2021-09-13 13:38 ` George McCollister
2021-09-13 13:38 ` George McCollister
2021-09-13 13:38 ` George McCollister
2021-09-13 16:51 ` Florian Fainelli
2021-09-13 16:51 ` Florian Fainelli
2021-09-13 16:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT9Nx9hvSnRYmJ4Q@lunn.ch \
--to=andrew@lunn.ch \
--cc=Landen.Chao@mediatek.com \
--cc=LinoSanfilippo@gmx.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=hauke@hauke-m.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rempel-privat.de \
--cc=m.grzeschik@pengutronix.de \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.