From: "Luck, Tony" <tony.luck@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] x86/mce: Get rid of msr_ops
Date: Sun, 19 Sep 2021 21:47:51 -0700 [thread overview]
Message-ID: <YUgSd6Sl/bFaGydO@agluck-desk2.amr.corp.intel.com> (raw)
In-Reply-To: <20210917105355.2368-4-bp@alien8.de>
On Fri, Sep 17, 2021 at 12:53:54PM +0200, Borislav Petkov wrote:
> + switch (reg) {
> + case MCA_CTL:
> + return mce_flags.smca ? MSR_AMD64_SMCA_MCx_CTL(bank)
> + : MSR_IA32_MCx_CTL(bank);
>
> -static inline u32 smca_ctl_reg(int bank)
> -{
> - return MSR_AMD64_SMCA_MCx_CTL(bank);
> -}
> + case MCA_STATUS:
> + return mce_flags.smca ? MSR_AMD64_SMCA_MCx_STATUS(bank)
> + : MSR_IA32_MCx_STATUS(bank);
>
> -static inline u32 smca_status_reg(int bank)
> -{
> - return MSR_AMD64_SMCA_MCx_STATUS(bank);
> -}
> + case MCA_ADDR:
> + return mce_flags.smca ? MSR_AMD64_SMCA_MCx_ADDR(bank)
> + : MSR_IA32_MCx_ADDR(bank);
>
> -static inline u32 smca_addr_reg(int bank)
> -{
> - return MSR_AMD64_SMCA_MCx_ADDR(bank);
> -}
> + case MCA_MISC:
> + return mce_flags.smca ? MSR_AMD64_SMCA_MCx_MISC(bank)
> + : MSR_IA32_MCx_MISC(bank);
> + default: break;
> + }
I think this would be easier on the eyeballs with
a couple of helper functions:
if (mce_flags.smca)
return smca_msr_number(bank, reg);
else
return msr_number(bank, reg);
with the switch (reg) in each of those helper functions.
-Tony
next prev parent reply other threads:[~2021-09-20 4:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 10:53 [PATCH 0/4] x86/mce: Remove indirect calls Borislav Petkov
2021-09-17 10:53 ` [PATCH 1/4] x86/mce: Get rid of the mce_severity function pointer Borislav Petkov
2021-09-17 10:53 ` [PATCH 2/4] x86/mce: Get rid of machine_check_vector Borislav Petkov
2021-09-20 4:57 ` Luck, Tony
2021-09-20 7:42 ` Rasmus Villemoes
2021-09-20 8:15 ` Borislav Petkov
2021-09-20 8:12 ` Borislav Petkov
2021-09-20 16:04 ` Luck, Tony
2021-09-20 16:32 ` Borislav Petkov
2021-09-17 10:53 ` [PATCH 3/4] x86/mce: Get rid of msr_ops Borislav Petkov
2021-09-20 4:47 ` Luck, Tony [this message]
2021-09-20 8:32 ` Borislav Petkov
2021-09-22 12:16 ` Borislav Petkov
2021-09-22 13:23 ` Luck, Tony
2021-09-22 13:55 ` Borislav Petkov
2021-09-22 15:22 ` Luck, Tony
2021-09-22 15:57 ` Borislav Petkov
2021-09-17 10:53 ` [PATCH 4/4] x86/mce: Get rid of the ->quirk_no_way_out() indirect call Borislav Petkov
2021-09-20 5:06 ` Luck, Tony
2021-09-20 8:34 ` Borislav Petkov
2021-09-23 14:51 ` Yazen Ghannam
2021-09-23 15:11 ` Borislav Petkov
2021-09-24 20:04 ` Yazen Ghannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUgSd6Sl/bFaGydO@agluck-desk2.amr.corp.intel.com \
--to=tony.luck@intel.com \
--cc=Yazen.Ghannam@amd.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.