* [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix condition in dc9-test
@ 2021-10-08 11:32 Jigar Bhatt
2021-10-08 11:47 ` Petri Latvala
0 siblings, 1 reply; 2+ messages in thread
From: Jigar Bhatt @ 2021-10-08 11:32 UTC (permalink / raw)
To: igt-dev; +Cc: jigar.bhatt, petri.latvala, nischal.varide
Inside dc9_wait_entry, we do not have DC9 counter,
so we rely on dc5/dc6 counter reset
to check if display engine was in DC9.
Test is passed if live counter is less
than the previous counter. Correcting condition
igt_wait(read_dc_counter(debugfs_fd, dc_target) <
prev_dc, seconds, 100);
Signed-off-by: Jigar Bhatt <jigar.bhatt@intel.com>
---
tests/i915/i915_pm_dc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index 4c9b871c..9db66ba2 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -404,7 +404,7 @@ static bool dc9_wait_entry(uint32_t debugfs_fd, int dc_target, int prev_dc, int
* since we do not have DC9 counter,
* so we rely on dc5/dc6 counter reset to check if display engine was in DC9.
*/
- return igt_wait(read_dc_counter(debugfs_fd, dc_target) >
+ return igt_wait(read_dc_counter(debugfs_fd, dc_target) <
prev_dc, seconds, 100);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix condition in dc9-test
2021-10-08 11:32 [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix condition in dc9-test Jigar Bhatt
@ 2021-10-08 11:47 ` Petri Latvala
0 siblings, 0 replies; 2+ messages in thread
From: Petri Latvala @ 2021-10-08 11:47 UTC (permalink / raw)
To: Jigar Bhatt; +Cc: igt-dev, nischal.varide
On Fri, Oct 08, 2021 at 05:02:30PM +0530, Jigar Bhatt wrote:
> Inside dc9_wait_entry, we do not have DC9 counter,
> so we rely on dc5/dc6 counter reset
> to check if display engine was in DC9.
> Test is passed if live counter is less
> than the previous counter. Correcting condition
> igt_wait(read_dc_counter(debugfs_fd, dc_target) <
> prev_dc, seconds, 100);
>
> Signed-off-by: Jigar Bhatt <jigar.bhatt@intel.com>
Yep, looks like this check was accidentally reversed in
2f4e6430a97f04284d1cafb1479e7c1b0b2d596a.
Are there bug reports that this commits should close with a Fixes:
line?
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> ---
> tests/i915/i915_pm_dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> index 4c9b871c..9db66ba2 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -404,7 +404,7 @@ static bool dc9_wait_entry(uint32_t debugfs_fd, int dc_target, int prev_dc, int
> * since we do not have DC9 counter,
> * so we rely on dc5/dc6 counter reset to check if display engine was in DC9.
> */
> - return igt_wait(read_dc_counter(debugfs_fd, dc_target) >
> + return igt_wait(read_dc_counter(debugfs_fd, dc_target) <
> prev_dc, seconds, 100);
> }
>
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-08 11:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-08 11:32 [igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Fix condition in dc9-test Jigar Bhatt
2021-10-08 11:47 ` Petri Latvala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.