From: Borislav Petkov <bp@alien8.de>
To: "Winiarska, Iwona" <iwona.winiarska@intel.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"jae.hyun.yoo@linux.intel.com" <jae.hyun.yoo@linux.intel.com>,
"d.mueller@elsoft.ch" <d.mueller@elsoft.ch>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"Luck, Tony" <tony.luck@intel.com>,
"Lutomirski, Andy" <luto@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"olof@lixom.net" <olof@lixom.net>,
"mingo@redhat.com" <mingo@redhat.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"zweiss@equinix.com" <zweiss@equinix.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 01/15] x86/cpu: Move intel-family to arch-independent headers
Date: Mon, 11 Oct 2021 22:06:38 +0200 [thread overview]
Message-ID: <YWSZTq8NWWcCMXtA@zn.tnic> (raw)
In-Reply-To: <58ef4107e9b2c60a2605aac0d2fb6670a95bc9e0.camel@intel.com>
On Mon, Oct 11, 2021 at 07:21:26PM +0000, Winiarska, Iwona wrote:
> Same reason why PECI can't just include arch/x86 directly (we're building for
> ARM, not x86).
Aha.
So what do you need those INTEL_FAM6* defines for?
I see peci_cpu_device_ids[] which are used to match the CPU so at least
that thing must be loading on x86 hardware... reading your 0th message,
it sounds like that peci-cpu thing is loaded on an x86 CPU and it then
exposes those interfaces which a PECI controller accesses.
And then I see in init_core_mask() the single usage of INTEL_FAM6* and
that drivers/hwmon/peci/cputemp.c is a CPU temp monitoring client so
that thing probably runs on x86 too.
Or?
If it does, then you don't need the code move.
But it looks like I'm missing something...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Winiarska, Iwona" <iwona.winiarska@intel.com>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"jae.hyun.yoo@linux.intel.com" <jae.hyun.yoo@linux.intel.com>,
"d.mueller@elsoft.ch" <d.mueller@elsoft.ch>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"Luck, Tony" <tony.luck@intel.com>,
"Lutomirski, Andy" <luto@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"olof@lixom.net" <olof@lixom.net>,
"mingo@redhat.com" <mingo@redhat.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"zweiss@equinix.com" <zweiss@equinix.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 01/15] x86/cpu: Move intel-family to arch-independent headers
Date: Mon, 11 Oct 2021 22:06:38 +0200 [thread overview]
Message-ID: <YWSZTq8NWWcCMXtA@zn.tnic> (raw)
In-Reply-To: <58ef4107e9b2c60a2605aac0d2fb6670a95bc9e0.camel@intel.com>
On Mon, Oct 11, 2021 at 07:21:26PM +0000, Winiarska, Iwona wrote:
> Same reason why PECI can't just include arch/x86 directly (we're building for
> ARM, not x86).
Aha.
So what do you need those INTEL_FAM6* defines for?
I see peci_cpu_device_ids[] which are used to match the CPU so at least
that thing must be loading on x86 hardware... reading your 0th message,
it sounds like that peci-cpu thing is loaded on an x86 CPU and it then
exposes those interfaces which a PECI controller accesses.
And then I see in init_core_mask() the single usage of INTEL_FAM6* and
that drivers/hwmon/peci/cputemp.c is a CPU temp monitoring client so
that thing probably runs on x86 too.
Or?
If it does, then you don't need the code move.
But it looks like I'm missing something...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Winiarska, Iwona" <iwona.winiarska@intel.com>
Cc: "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"zweiss@equinix.com" <zweiss@equinix.com>,
"jae.hyun.yoo@linux.intel.com" <jae.hyun.yoo@linux.intel.com>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"x86@kernel.org" <x86@kernel.org>,
"pierre-louis.bossart@linux.intel.com"
<pierre-louis.bossart@linux.intel.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Lutomirski, Andy" <luto@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"Luck, Tony" <tony.luck@intel.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yazen.ghannam@amd.com" <yazen.ghannam@amd.com>,
"olof@lixom.net" <olof@lixom.net>
Subject: Re: [PATCH v2 01/15] x86/cpu: Move intel-family to arch-independent headers
Date: Mon, 11 Oct 2021 22:06:38 +0200 [thread overview]
Message-ID: <YWSZTq8NWWcCMXtA@zn.tnic> (raw)
In-Reply-To: <58ef4107e9b2c60a2605aac0d2fb6670a95bc9e0.camel@intel.com>
On Mon, Oct 11, 2021 at 07:21:26PM +0000, Winiarska, Iwona wrote:
> Same reason why PECI can't just include arch/x86 directly (we're building for
> ARM, not x86).
Aha.
So what do you need those INTEL_FAM6* defines for?
I see peci_cpu_device_ids[] which are used to match the CPU so at least
that thing must be loading on x86 hardware... reading your 0th message,
it sounds like that peci-cpu thing is loaded on an x86 CPU and it then
exposes those interfaces which a PECI controller accesses.
And then I see in init_core_mask() the single usage of INTEL_FAM6* and
that drivers/hwmon/peci/cputemp.c is a CPU temp monitoring client so
that thing probably runs on x86 too.
Or?
If it does, then you don't need the code move.
But it looks like I'm missing something...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2021-10-11 20:06 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 11:31 [PATCH v2 00/15] Introduce PECI subsystem Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` [PATCH v2 01/15] x86/cpu: Move intel-family to arch-independent headers Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-10-04 19:03 ` Borislav Petkov
2021-10-04 19:03 ` Borislav Petkov
2021-10-04 19:03 ` Borislav Petkov
2021-10-11 19:21 ` Winiarska, Iwona
2021-10-11 19:21 ` Winiarska, Iwona
2021-10-11 19:21 ` Winiarska, Iwona
2021-10-11 19:40 ` Dave Hansen
2021-10-11 19:40 ` Dave Hansen
2021-10-11 19:40 ` Dave Hansen
2021-10-11 20:53 ` Winiarska, Iwona
2021-10-11 20:53 ` Winiarska, Iwona
2021-10-11 20:53 ` Winiarska, Iwona
2021-10-11 23:12 ` Dave Hansen
2021-10-11 23:12 ` Dave Hansen
2021-10-11 23:12 ` Dave Hansen
2021-10-11 20:06 ` Borislav Petkov [this message]
2021-10-11 20:06 ` Borislav Petkov
2021-10-11 20:06 ` Borislav Petkov
2021-10-11 20:38 ` Winiarska, Iwona
2021-10-11 20:38 ` Winiarska, Iwona
2021-10-11 20:38 ` Winiarska, Iwona
2021-10-11 21:31 ` Borislav Petkov
2021-10-11 21:31 ` Borislav Petkov
2021-10-11 21:31 ` Borislav Petkov
2021-10-12 23:15 ` Winiarska, Iwona
2021-10-12 23:15 ` Winiarska, Iwona
2021-10-12 23:15 ` Winiarska, Iwona
2021-10-13 6:42 ` Borislav Petkov
2021-10-13 6:42 ` Borislav Petkov
2021-10-13 6:42 ` Borislav Petkov
2021-08-03 11:31 ` [PATCH v2 02/15] x86/cpu: Extract cpuid helpers to arch-independent Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-10-04 19:08 ` Borislav Petkov
2021-10-04 19:08 ` Borislav Petkov
2021-10-04 19:08 ` Borislav Petkov
2021-10-11 19:32 ` Winiarska, Iwona
2021-10-11 19:32 ` Winiarska, Iwona
2021-10-11 19:32 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 03/15] dt-bindings: Add generic bindings for PECI Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-11 18:11 ` Rob Herring
2021-08-11 18:11 ` Rob Herring
2021-08-11 18:11 ` Rob Herring
2021-08-03 11:31 ` [PATCH v2 04/15] dt-bindings: Add bindings for peci-aspeed Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-11 18:11 ` Rob Herring
2021-08-11 18:11 ` Rob Herring
2021-08-11 18:11 ` Rob Herring
2021-08-03 11:31 ` [PATCH v2 05/15] ARM: dts: aspeed: Add PECI controller nodes Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` [PATCH v2 06/15] peci: Add core infrastructure Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-25 22:58 ` Dan Williams
2021-08-25 22:58 ` Dan Williams
2021-08-25 22:58 ` Dan Williams
2021-08-26 22:40 ` Winiarska, Iwona
2021-08-26 22:40 ` Winiarska, Iwona
2021-08-26 22:40 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 07/15] peci: Add peci-aspeed controller driver Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-26 1:35 ` Dan Williams
2021-08-26 1:35 ` Dan Williams
2021-08-26 1:35 ` Dan Williams
2021-08-26 23:54 ` Winiarska, Iwona
2021-08-26 23:54 ` Winiarska, Iwona
2021-08-26 23:54 ` Winiarska, Iwona
2021-08-27 16:24 ` Dan Williams
2021-08-27 16:24 ` Dan Williams
2021-08-27 16:24 ` Dan Williams
2021-08-29 19:42 ` Winiarska, Iwona
2021-08-29 19:42 ` Winiarska, Iwona
2021-08-29 19:42 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 08/15] peci: Add device detection Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-27 19:01 ` Dan Williams
2021-08-27 19:01 ` Dan Williams
2021-08-27 19:01 ` Dan Williams
2021-11-15 22:18 ` Winiarska, Iwona
2021-11-15 22:18 ` Winiarska, Iwona
2021-11-15 22:18 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 09/15] peci: Add sysfs interface for PECI bus Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-27 19:11 ` Dan Williams
2021-08-27 19:11 ` Dan Williams
2021-08-27 19:11 ` Dan Williams
2021-11-15 22:19 ` Winiarska, Iwona
2021-11-15 22:19 ` Winiarska, Iwona
2021-11-15 22:19 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 10/15] peci: Add support for PECI device drivers Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-27 21:19 ` Dan Williams
2021-08-27 21:19 ` Dan Williams
2021-08-27 21:19 ` Dan Williams
2021-11-15 22:20 ` Winiarska, Iwona
2021-11-15 22:20 ` Winiarska, Iwona
2021-11-15 22:20 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 11/15] peci: Add peci-cpu driver Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` [PATCH v2 12/15] hwmon: peci: Add cputemp driver Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 15:24 ` Guenter Roeck
2021-08-03 15:24 ` Guenter Roeck
2021-08-03 15:24 ` Guenter Roeck
2021-08-04 10:43 ` Winiarska, Iwona
2021-08-04 10:43 ` Winiarska, Iwona
2021-08-04 10:43 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 13/15] hwmon: peci: Add dimmtemp driver Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 15:39 ` Guenter Roeck
2021-08-03 15:39 ` Guenter Roeck
2021-08-03 15:39 ` Guenter Roeck
2021-08-04 10:46 ` Winiarska, Iwona
2021-08-04 10:46 ` Winiarska, Iwona
2021-08-04 10:46 ` Winiarska, Iwona
2021-08-04 17:33 ` Guenter Roeck
2021-08-04 17:33 ` Guenter Roeck
2021-08-04 17:33 ` Guenter Roeck
2021-08-05 21:48 ` Winiarska, Iwona
2021-08-05 21:48 ` Winiarska, Iwona
2021-08-05 21:48 ` Winiarska, Iwona
2021-08-03 11:31 ` [PATCH v2 14/15] docs: hwmon: Document PECI drivers Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` [PATCH v2 15/15] docs: Add PECI documentation Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-03 11:31 ` Iwona Winiarska
2021-08-05 12:17 ` [PATCH v2 00/15] Introduce PECI subsystem Greg Kroah-Hartman
2021-08-05 12:17 ` Greg Kroah-Hartman
2021-08-05 12:17 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWSZTq8NWWcCMXtA@zn.tnic \
--to=bp@alien8.de \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=d.mueller@elsoft.ch \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=iwona.winiarska@intel.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luto@kernel.org \
--cc=mchehab@kernel.org \
--cc=mingo@redhat.com \
--cc=olof@lixom.net \
--cc=openbmc@lists.ozlabs.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
--cc=zweiss@equinix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.