* [PATCH] mt76: mt7663: disable 4addr capability
@ 2021-12-02 19:35 Lorenzo Bianconi
2021-12-03 8:32 ` Felix Fietkau
0 siblings, 1 reply; 3+ messages in thread
From: Lorenzo Bianconi @ 2021-12-02 19:35 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless, lorenzo.bianconi
4addr is not supported by the driver/firmware yet
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index 47f23ac905a3..52182ab6d240 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
if (is_mt7663(&phy->dev->mt76)) {
wiphy->iface_combinations = if_comb;
wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
+ wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
} else {
wiphy->iface_combinations = if_comb_radar;
wiphy->n_iface_combinations = ARRAY_SIZE(if_comb_radar);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: mt7663: disable 4addr capability
2021-12-02 19:35 [PATCH] mt76: mt7663: disable 4addr capability Lorenzo Bianconi
@ 2021-12-03 8:32 ` Felix Fietkau
2021-12-03 10:07 ` Lorenzo Bianconi
0 siblings, 1 reply; 3+ messages in thread
From: Felix Fietkau @ 2021-12-03 8:32 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: linux-wireless, lorenzo.bianconi
On 2021-12-02 20:35, Lorenzo Bianconi wrote:
> 4addr is not supported by the driver/firmware yet
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> index 47f23ac905a3..52182ab6d240 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
> if (is_mt7663(&phy->dev->mt76)) {
> wiphy->iface_combinations = if_comb;
> wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
> + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
Shouldn't this be done for the offload firmware only?
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: mt7663: disable 4addr capability
2021-12-03 8:32 ` Felix Fietkau
@ 2021-12-03 10:07 ` Lorenzo Bianconi
0 siblings, 0 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2021-12-03 10:07 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless, lorenzo.bianconi
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
>
> On 2021-12-02 20:35, Lorenzo Bianconi wrote:
> > 4addr is not supported by the driver/firmware yet
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > index 47f23ac905a3..52182ab6d240 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
> > @@ -378,6 +378,7 @@ mt7615_init_wiphy(struct ieee80211_hw *hw)
> > if (is_mt7663(&phy->dev->mt76)) {
> > wiphy->iface_combinations = if_comb;
> > wiphy->n_iface_combinations = ARRAY_SIZE(if_comb);
> > + wiphy->flags &= ~WIPHY_FLAG_4ADDR_STATION;
> Shouldn't this be done for the offload firmware only?
>
> - Felix
ack, right, I did not think about this combination. I tested with non-offload
fw and it works. I will post v2 to fix it.
Regards,
Lorenzo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-03 10:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 19:35 [PATCH] mt76: mt7663: disable 4addr capability Lorenzo Bianconi
2021-12-03 8:32 ` Felix Fietkau
2021-12-03 10:07 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.