[nft PATCH] build: remove scanner.c and parser_bison.c with `maintainer-clean`

[nft PATCH] build: remove scanner.c and parser_bison.c with `maintainer-clean`

[Jeremy Sowden]

automake recommends shipping the output of bison and lex in distribution
tar-balls and runs bison and lex during `make dist` (this has the
advantage that end-users don't need to have bison or lex installed to
compile the software).  Accordingly, automake also recommends removing
these files with `make maintainer-clean` and generates rules to do so.
Therefore, remove scanner.c and parser_bison.c from `CLEANFILES`.

Signed-off-by: Jeremy Sowden <jeremy@azazel.net>
---
 src/Makefile.am | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 01c12c81bce7..6ab0752337b2 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -2,8 +2,6 @@ include $(top_srcdir)/Make_global.am
 
 sbin_PROGRAMS = nft
 
-CLEANFILES = scanner.c parser_bison.c
-
 AM_CPPFLAGS = -I$(top_srcdir)/include
 AM_CPPFLAGS += -DDEFAULT_INCLUDE_PATH="\"${sysconfdir}\"" \
 		${LIBMNL_CFLAGS} ${LIBNFTNL_CFLAGS}
-- 
2.34.1

Re: [nft PATCH] build: remove scanner.c and parser_bison.c with `maintainer-clean`

[Pablo Neira Ayuso]

On Thu, Dec 16, 2021 at 04:37:20PM +0000, Jeremy Sowden wrote:
> automake recommends shipping the output of bison and lex in distribution
> tar-balls and runs bison and lex during `make dist` (this has the
> advantage that end-users don't need to have bison or lex installed to
> compile the software).  Accordingly, automake also recommends removing
> these files with `make maintainer-clean` and generates rules to do so.
> Therefore, remove scanner.c and parser_bison.c from `CLEANFILES`.

Applied, thanks