From: Vinod Koul <vkoul@kernel.org> To: Bard Liao <yung-chuan.liao@linux.intel.com> Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, bard.liao@intel.com Subject: Re: [PATCH 6/7] soundwire: intel: remove unnecessary init Date: Thu, 23 Dec 2021 12:28:00 +0530 [thread overview] Message-ID: <YcQd+FTe+C4/Xpt1@matsya> (raw) In-Reply-To: <20211213054634.30088-7-yung-chuan.liao@linux.intel.com> On 13-12-21, 13:46, Bard Liao wrote: > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > cppcheck warning: > > drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a > value that is never used. [unreadVariable] > int ret = 0; > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> > Reviewed-by: Rander Wang <rander.wang@intel.com> > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- > drivers/soundwire/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index e946d1283892..45ea55a7d0c8 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev) > struct sdw_intel *sdw = cdns_to_intel(cdns); > struct sdw_bus *bus = &cdns->bus; > u32 clock_stop_quirks; > - int ret = 0; > + int ret; Ideally this should not be part of this series! If Mark wants to pick: Acked-By: Vinod Koul <vkoul@kernel.org> > > if (bus->prop.hw_disabled || !sdw->startup_done) { > dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n", > -- > 2.17.1 -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Bard Liao <yung-chuan.liao@linux.intel.com> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, sanyog.r.kale@intel.com, bard.liao@intel.com Subject: Re: [PATCH 6/7] soundwire: intel: remove unnecessary init Date: Thu, 23 Dec 2021 12:28:00 +0530 [thread overview] Message-ID: <YcQd+FTe+C4/Xpt1@matsya> (raw) In-Reply-To: <20211213054634.30088-7-yung-chuan.liao@linux.intel.com> On 13-12-21, 13:46, Bard Liao wrote: > From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > cppcheck warning: > > drivers/soundwire/intel.c:1487:10: style: Variable 'ret' is assigned a > value that is never used. [unreadVariable] > int ret = 0; > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com> > Reviewed-by: Rander Wang <rander.wang@intel.com> > Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- > drivers/soundwire/intel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c > index e946d1283892..45ea55a7d0c8 100644 > --- a/drivers/soundwire/intel.c > +++ b/drivers/soundwire/intel.c > @@ -1613,7 +1613,7 @@ static int __maybe_unused intel_pm_prepare(struct device *dev) > struct sdw_intel *sdw = cdns_to_intel(cdns); > struct sdw_bus *bus = &cdns->bus; > u32 clock_stop_quirks; > - int ret = 0; > + int ret; Ideally this should not be part of this series! If Mark wants to pick: Acked-By: Vinod Koul <vkoul@kernel.org> > > if (bus->prop.hw_disabled || !sdw->startup_done) { > dev_dbg(dev, "SoundWire master %d is disabled or not-started, ignoring\n", > -- > 2.17.1 -- ~Vinod
next prev parent reply other threads:[~2021-12-23 6:58 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-13 5:46 [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-13 5:46 ` [PATCH 1/7] ASOC: SOF: Intel: use snd_soc_dai_get_widget() Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-13 5:46 ` [PATCH 2/7] ASoC/soundwire: intel: simplify callbacks for params/hw_free Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-23 16:30 ` Vinod Koul 2021-12-23 16:30 ` Vinod Koul 2021-12-13 5:46 ` [PATCH 3/7] soundwire: intel: improve suspend flows Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-23 6:56 ` Vinod Koul 2021-12-23 6:56 ` Vinod Koul 2021-12-13 5:46 ` [PATCH 4/7] ASoC/SoundWire: dai: expand 'stream' concept beyond SoundWire Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-23 16:35 ` Vinod Koul 2021-12-23 16:35 ` Vinod Koul 2021-12-13 5:46 ` [PATCH 5/7] ASoC: Intel/SOF: use set_stream() instead of set_tdm_slots() for HDAudio Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-13 5:46 ` [PATCH 6/7] soundwire: intel: remove unnecessary init Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-23 6:58 ` Vinod Koul [this message] 2021-12-23 6:58 ` Vinod Koul 2021-12-13 5:46 ` [PATCH 7/7] soundwire: intel: remove PDM support Bard Liao 2021-12-13 5:46 ` Bard Liao 2021-12-23 6:59 ` Vinod Koul 2021-12-23 6:59 ` Vinod Koul 2021-12-23 7:46 ` Liao, Bard 2021-12-23 7:46 ` Liao, Bard 2021-12-23 11:05 ` Vinod Koul 2021-12-23 11:05 ` Vinod Koul 2021-12-23 12:29 ` Liao, Bard 2021-12-23 12:29 ` Liao, Bard 2022-01-10 16:32 ` Pierre-Louis Bossart 2021-12-23 16:35 ` Vinod Koul 2021-12-23 16:35 ` Vinod Koul 2021-12-23 18:26 ` Mark Brown 2021-12-23 18:26 ` Mark Brown 2021-12-24 1:38 ` Liao, Bard 2021-12-24 1:38 ` Liao, Bard 2021-12-21 18:09 ` [PATCH 0/7] ASoC/SoundWire: improve suspend flows and use set_stream() instead of set_tdm_slots() for HDAudio Mark Brown 2021-12-21 18:09 ` Mark Brown 2021-12-22 13:47 ` Liao, Bard 2021-12-22 13:47 ` Liao, Bard 2021-12-23 5:19 ` Vinod Koul 2021-12-23 5:19 ` Vinod Koul 2021-12-24 16:17 ` Mark Brown 2021-12-24 16:17 ` Mark Brown 2023-06-22 22:37 [PATCH 6/7] soundwire: intel: remove unnecessary init K Smart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YcQd+FTe+C4/Xpt1@matsya \ --to=vkoul@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bard.liao@intel.com \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=sanyog.r.kale@intel.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.