* [PATCH] ubifs: use default_groups in kobj_type
@ 2022-01-13 18:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-13 18:08 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Richard Weinberger, Stefan Schaeckeler, linux-mtd
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the AMD mce sysfs code to use default_groups field which
has been the preferred way since aa30f47cf666 ("kobject: Add support for
default attribute groups to kobj_type") so that we can soon get rid of
the obsolete default_attrs field.
Cc: Richard Weinberger <richard@nod.at>
Cc: Stefan Schaeckeler <schaecsn@gmx.net>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/ubifs/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
index 7acc5a74e5fa..06ad8fa1fcfb 100644
--- a/fs/ubifs/sysfs.c
+++ b/fs/ubifs/sysfs.c
@@ -42,6 +42,7 @@ static struct attribute *ubifs_attrs[] = {
ATTR_LIST(errors_crc),
NULL,
};
+ATTRIBUTE_GROUPS(ubifs);
static ssize_t ubifs_attr_show(struct kobject *kobj,
struct attribute *attr, char *buf)
@@ -74,7 +75,7 @@ static const struct sysfs_ops ubifs_attr_ops = {
};
static struct kobj_type ubifs_sb_ktype = {
- .default_attrs = ubifs_attrs,
+ .default_groups = ubifs_groups,
.sysfs_ops = &ubifs_attr_ops,
.release = ubifs_sb_release,
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ubifs: use default_groups in kobj_type
@ 2022-01-13 18:08 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-13 18:08 UTC (permalink / raw)
To: linux-kernel
Cc: Greg Kroah-Hartman, Richard Weinberger, Stefan Schaeckeler, linux-mtd
There are currently 2 ways to create a set of sysfs files for a
kobj_type, through the default_attrs field, and the default_groups
field. Move the AMD mce sysfs code to use default_groups field which
has been the preferred way since aa30f47cf666 ("kobject: Add support for
default attribute groups to kobj_type") so that we can soon get rid of
the obsolete default_attrs field.
Cc: Richard Weinberger <richard@nod.at>
Cc: Stefan Schaeckeler <schaecsn@gmx.net>
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
fs/ubifs/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
index 7acc5a74e5fa..06ad8fa1fcfb 100644
--- a/fs/ubifs/sysfs.c
+++ b/fs/ubifs/sysfs.c
@@ -42,6 +42,7 @@ static struct attribute *ubifs_attrs[] = {
ATTR_LIST(errors_crc),
NULL,
};
+ATTRIBUTE_GROUPS(ubifs);
static ssize_t ubifs_attr_show(struct kobject *kobj,
struct attribute *attr, char *buf)
@@ -74,7 +75,7 @@ static const struct sysfs_ops ubifs_attr_ops = {
};
static struct kobj_type ubifs_sb_ktype = {
- .default_attrs = ubifs_attrs,
+ .default_groups = ubifs_groups,
.sysfs_ops = &ubifs_attr_ops,
.release = ubifs_sb_release,
};
--
2.34.1
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ubifs: use default_groups in kobj_type
2022-01-13 18:08 ` Greg Kroah-Hartman
@ 2022-01-14 10:08 ` Michael Walle
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-01-14 10:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, Richard Weinberger, Stefan Schaeckeler, linux-mtd
Hi,
Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field. Move the AMD mce sysfs code to use default_groups field which
copy & paste mistake?
> has been the preferred way since aa30f47cf666 ("kobject: Add support
> for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ubifs: use default_groups in kobj_type
@ 2022-01-14 10:08 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-01-14 10:08 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, Richard Weinberger, Stefan Schaeckeler, linux-mtd
Hi,
Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> There are currently 2 ways to create a set of sysfs files for a
> kobj_type, through the default_attrs field, and the default_groups
> field. Move the AMD mce sysfs code to use default_groups field which
copy & paste mistake?
> has been the preferred way since aa30f47cf666 ("kobject: Add support
> for
> default attribute groups to kobj_type") so that we can soon get rid of
> the obsolete default_attrs field.
-michael
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ubifs: use default_groups in kobj_type
2022-01-14 10:08 ` Michael Walle
@ 2022-01-14 10:19 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-14 10:19 UTC (permalink / raw)
To: Michael Walle
Cc: linux-kernel, Richard Weinberger, Stefan Schaeckeler, linux-mtd
On Fri, Jan 14, 2022 at 11:08:03AM +0100, Michael Walle wrote:
> Hi,
>
> Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the AMD mce sysfs code to use default_groups field which
>
> copy & paste mistake?
Ugh, yes, sorry, will go fix this up, thanks...
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ubifs: use default_groups in kobj_type
@ 2022-01-14 10:19 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-01-14 10:19 UTC (permalink / raw)
To: Michael Walle
Cc: linux-kernel, Richard Weinberger, Stefan Schaeckeler, linux-mtd
On Fri, Jan 14, 2022 at 11:08:03AM +0100, Michael Walle wrote:
> Hi,
>
> Am 2022-01-13 19:08, schrieb Greg Kroah-Hartman:
> > There are currently 2 ways to create a set of sysfs files for a
> > kobj_type, through the default_attrs field, and the default_groups
> > field. Move the AMD mce sysfs code to use default_groups field which
>
> copy & paste mistake?
Ugh, yes, sorry, will go fix this up, thanks...
greg k-h
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-01-14 10:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-13 18:08 [PATCH] ubifs: use default_groups in kobj_type Greg Kroah-Hartman
2022-01-13 18:08 ` Greg Kroah-Hartman
2022-01-14 10:08 ` Michael Walle
2022-01-14 10:08 ` Michael Walle
2022-01-14 10:19 ` Greg Kroah-Hartman
2022-01-14 10:19 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.