From: conor dooley <mail@conchuod.ie> To: Rob Herring <robh@kernel.org> Cc: conor.dooley@microchip.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, a.zummo@towertech.it, alexandre.belloni@bootlin.com, broonie@kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org, krzysztof.kozlowski@canonical.com, geert@linux-m68k.org, bin.meng@windriver.com, heiko@sntech.de, lewis.hanly@microchip.com, daire.mcnamara@microchip.com, ivan.griffin@microchip.com, atish.patra@wdc.com Subject: Re: [PATCH v2 03/17] dt-bindings: soc/microchip: make systemcontroller a mfd Date: Tue, 21 Dec 2021 23:50:47 +0000 [thread overview] Message-ID: <YfGEPBe6qV6ieFoD_Xk-rEkBwvyWlVDCxk1PNycMfHsRYK1zMpawiDI25G1EZorczGJGj8e-epWgPs_UB8_-DP4keo1ivgfrLOXJNliFRxE=@conchuod.ie> (raw) In-Reply-To: <YcIVFZSqt/JSuk3J@robh.at.kernel.org> On Tuesday, December 21st, 2021 at 17:55, Rob Herring <robh@kernel.org> wrote: >On Fri, Dec 17, 2021 at 09:33:11AM +0000, conor.dooley@microchip.com wrote: >> From: Conor Dooley <conor.dooley@microchip.com> >> >> Make the system controller on the Polarfire SoC >> a "simple,mfd" so that the services can be child >> nodes of the system controller node. >> >> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> .../microchip,mpfs-sys-controller.yaml | 33 +++++++++++++++++-- >> 1 file changed, 30 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml b/>Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> index f699772fedf3..014cb44b8f31 100644 >> --- a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> @@ -13,13 +13,34 @@ description: | >> The PolarFire SoC system controller is communicated with via a mailbox. >> This document describes the bindings for the client portion of that mailbox. >> >> - >> properties: >> mboxes: >> maxItems: 1 >> >> compatible: >> - const: microchip,mpfs-sys-controller >> + items: >> + - const: microchip,mpfs-sys-controller >> + - const: simple-mfd > >'simple-mfd' means there is zero dependency on the parent for the child >nodes. Isn't 'mboxes' a dependency? I suppose it is. I was going off what had been done for the bcm2835 firmware for the rpi its also a mailbox providing "services". (arm/bcm/raspberrypi,bcm2835-firmware.yaml) > >> + >> + hwrandom: >> + type: object >> + >> + properties: >> + compatible: >> + const: microchip,mpfs-rng >> + >> + required: >> + - compatible >> + >> + sysserv: >> + type: object >> + >> + properties: >> + compatible: >> + const: microchip,mpfs-generic-service >> + >> + required: >> + - compatible > >There's not really any need to have child nodes which have no resources. >The driver for microchip,mpfs-sys-controller can create child devices. I am assuming by this you mean say, take a list of boolean properties and convert those into child devices? There's a fairly decent number of services provided by the system controller and these children just represent the subset that we've implemented so far. Conor > >Rob
WARNING: multiple messages have this Message-ID (diff)
From: conor dooley <mail@conchuod.ie> To: Rob Herring <robh@kernel.org> Cc: conor.dooley@microchip.com, linus.walleij@linaro.org, bgolaszewski@baylibre.com, jassisinghbrar@gmail.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, a.zummo@towertech.it, alexandre.belloni@bootlin.com, broonie@kernel.org, gregkh@linuxfoundation.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org, krzysztof.kozlowski@canonical.com, geert@linux-m68k.org, bin.meng@windriver.com, heiko@sntech.de, lewis.hanly@microchip.com, daire.mcnamara@microchip.com, ivan.griffin@microchip.com, atish.patra@wdc.com Subject: Re: [PATCH v2 03/17] dt-bindings: soc/microchip: make systemcontroller a mfd Date: Tue, 21 Dec 2021 23:50:47 +0000 [thread overview] Message-ID: <YfGEPBe6qV6ieFoD_Xk-rEkBwvyWlVDCxk1PNycMfHsRYK1zMpawiDI25G1EZorczGJGj8e-epWgPs_UB8_-DP4keo1ivgfrLOXJNliFRxE=@conchuod.ie> (raw) In-Reply-To: <YcIVFZSqt/JSuk3J@robh.at.kernel.org> On Tuesday, December 21st, 2021 at 17:55, Rob Herring <robh@kernel.org> wrote: >On Fri, Dec 17, 2021 at 09:33:11AM +0000, conor.dooley@microchip.com wrote: >> From: Conor Dooley <conor.dooley@microchip.com> >> >> Make the system controller on the Polarfire SoC >> a "simple,mfd" so that the services can be child >> nodes of the system controller node. >> >> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> >> --- >> .../microchip,mpfs-sys-controller.yaml | 33 +++++++++++++++++-- >> 1 file changed, 30 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml b/>Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> index f699772fedf3..014cb44b8f31 100644 >> --- a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-sys-controller.yaml >> @@ -13,13 +13,34 @@ description: | >> The PolarFire SoC system controller is communicated with via a mailbox. >> This document describes the bindings for the client portion of that mailbox. >> >> - >> properties: >> mboxes: >> maxItems: 1 >> >> compatible: >> - const: microchip,mpfs-sys-controller >> + items: >> + - const: microchip,mpfs-sys-controller >> + - const: simple-mfd > >'simple-mfd' means there is zero dependency on the parent for the child >nodes. Isn't 'mboxes' a dependency? I suppose it is. I was going off what had been done for the bcm2835 firmware for the rpi its also a mailbox providing "services". (arm/bcm/raspberrypi,bcm2835-firmware.yaml) > >> + >> + hwrandom: >> + type: object >> + >> + properties: >> + compatible: >> + const: microchip,mpfs-rng >> + >> + required: >> + - compatible >> + >> + sysserv: >> + type: object >> + >> + properties: >> + compatible: >> + const: microchip,mpfs-generic-service >> + >> + required: >> + - compatible > >There's not really any need to have child nodes which have no resources. >The driver for microchip,mpfs-sys-controller can create child devices. I am assuming by this you mean say, take a list of boolean properties and convert those into child devices? There's a fairly decent number of services provided by the system controller and these children just represent the subset that we've implemented so far. Conor > >Rob _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-12-21 23:50 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-12-17 9:33 [PATCH v2 00/17] Update the Icicle Kit device tree conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 9:33 ` [PATCH v2 01/17] dt-bindings: interrupt-controller: create a header for RISC-V interrupts conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-21 17:47 ` Rob Herring 2021-12-21 17:47 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 02/17] dt-bindings: soc/microchip: update syscontroller compatibles conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 13:24 ` Geert Uytterhoeven 2021-12-17 13:24 ` Geert Uytterhoeven 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 03/17] dt-bindings: soc/microchip: make systemcontroller a mfd conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-21 17:55 ` Rob Herring 2021-12-21 17:55 ` Rob Herring 2021-12-21 23:50 ` conor dooley [this message] 2021-12-21 23:50 ` conor dooley 2021-12-17 9:33 ` [PATCH v2 04/17] mailbox: change mailbox-mpfs compatible string conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 13:25 ` Geert Uytterhoeven 2021-12-17 13:25 ` Geert Uytterhoeven 2021-12-17 9:33 ` [PATCH v2 05/17] dt-bindings: i2c: add bindings for microchip mpfs i2c conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 06/17] dt-bindings: rng: add bindings for microchip mpfs rng conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:53 ` Krzysztof Kozlowski 2021-12-17 14:53 ` Krzysztof Kozlowski 2021-12-17 15:07 ` Krzysztof Kozlowski 2021-12-17 15:07 ` Krzysztof Kozlowski 2021-12-17 15:22 ` Conor.Dooley 2021-12-17 15:22 ` Conor.Dooley 2021-12-17 15:47 ` Krzysztof Kozlowski 2021-12-17 15:47 ` Krzysztof Kozlowski 2021-12-17 16:26 ` conor dooley 2021-12-17 16:26 ` conor dooley 2021-12-17 9:33 ` [PATCH v2 07/17] dt-bindings: rtc: add bindings for microchip mpfs rtc conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-20 14:37 ` Rob Herring 2021-12-20 14:37 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 08/17] dt-bindings: soc/microchip: add bindings for mpfs system services conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 9:33 ` [PATCH v2 09/17] dt-bindings: gpio: add bindings for microchip mpfs gpio conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 10/17] dt-bindings: spi: add bindings for microchip mpfs spi conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 11:17 ` Mark Brown 2021-12-17 11:17 ` Mark Brown 2021-12-17 11:40 ` Conor.Dooley 2021-12-17 11:40 ` Conor.Dooley 2021-12-17 11:43 ` Mark Brown 2021-12-17 11:43 ` Mark Brown 2021-12-20 8:05 ` Conor.Dooley 2021-12-20 8:05 ` Conor.Dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 11/17] dt-bindings: usb: add bindings for microchip mpfs musb conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-21 13:32 ` Rob Herring 2021-12-21 13:32 ` Rob Herring 2021-12-17 9:33 ` [PATCH v2 12/17] dt-bindings: pwm: add microchip corePWM binding conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:21 ` Rob Herring 2021-12-17 14:58 ` Krzysztof Kozlowski 2021-12-17 14:58 ` Krzysztof Kozlowski 2021-12-17 9:33 ` [PATCH v2 13/17] riscv: dts: microchip: use hart and clk defines for icicle kit conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 13:40 ` Geert Uytterhoeven 2021-12-17 13:40 ` Geert Uytterhoeven 2021-12-17 9:33 ` [PATCH v2 14/17] riscv: dts: microchip: add fpga fabric section to " conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 13:43 ` Geert Uytterhoeven 2021-12-17 13:43 ` Geert Uytterhoeven 2021-12-17 15:32 ` Conor.Dooley 2021-12-17 15:32 ` Conor.Dooley 2021-12-17 16:00 ` Geert Uytterhoeven 2021-12-17 16:00 ` Geert Uytterhoeven 2022-01-12 9:38 ` Conor.Dooley 2022-01-12 9:38 ` Conor.Dooley 2022-01-14 13:35 ` Conor.Dooley 2022-01-14 13:35 ` Conor.Dooley 2021-12-17 14:59 ` Krzysztof Kozlowski 2021-12-17 14:59 ` Krzysztof Kozlowski 2021-12-17 9:33 ` [PATCH v2 15/17] riscv: dts: microchip: refactor icicle kit device tree conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 15:04 ` Krzysztof Kozlowski 2021-12-17 15:04 ` Krzysztof Kozlowski 2021-12-17 15:23 ` Conor.Dooley 2021-12-17 15:23 ` Conor.Dooley 2021-12-17 9:33 ` [PATCH v2 16/17] riscv: dts: microchip: update peripherals in " conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 9:33 ` [PATCH v2 17/17] MAINTAINERS: update riscv/microchip entry conor.dooley 2021-12-17 9:33 ` conor.dooley 2021-12-17 15:09 ` Krzysztof Kozlowski 2021-12-17 15:09 ` Krzysztof Kozlowski 2021-12-23 14:56 ` Conor.Dooley 2021-12-23 14:56 ` Conor.Dooley 2021-12-23 17:36 ` Palmer Dabbelt 2021-12-23 17:36 ` Palmer Dabbelt 2022-01-12 13:32 ` Lewis.Hanly 2022-01-12 13:32 ` Lewis.Hanly 2021-12-17 9:48 ` [PATCH v2 00/17] Update the Icicle Kit device tree Geert Uytterhoeven 2021-12-17 9:48 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='YfGEPBe6qV6ieFoD_Xk-rEkBwvyWlVDCxk1PNycMfHsRYK1zMpawiDI25G1EZorczGJGj8e-epWgPs_UB8_-DP4keo1ivgfrLOXJNliFRxE=@conchuod.ie' \ --to=mail@conchuod.ie \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=bgolaszewski@baylibre.com \ --cc=bin.meng@windriver.com \ --cc=broonie@kernel.org \ --cc=conor.dooley@microchip.com \ --cc=daire.mcnamara@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=geert@linux-m68k.org \ --cc=gregkh@linuxfoundation.org \ --cc=heiko@sntech.de \ --cc=ivan.griffin@microchip.com \ --cc=jassisinghbrar@gmail.com \ --cc=krzysztof.kozlowski@canonical.com \ --cc=lee.jones@linaro.org \ --cc=lewis.hanly@microchip.com \ --cc=linus.walleij@linaro.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-rtc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.