[PATCH] usb: host: {e|o}hci-dbg: kill useless 'ret' variable initializers

[PATCH] usb: host: {e|o}hci-dbg: kill useless 'ret' variable initializers

[Sergey Shtylyov]

The 'ret' local variables are often initialized to 0 but this value is
unused, thus we can kill those initializers...

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.

 drivers/usb/host/ehci-dbg.c |    4 ++--
 drivers/usb/host/ohci-dbg.c |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Index: usb/drivers/usb/host/ehci-dbg.c
===================================================================
--- usb.orig/drivers/usb/host/ehci-dbg.c
+++ usb/drivers/usb/host/ehci-dbg.c
@@ -931,7 +931,7 @@ static struct debug_buffer *alloc_buffer
 
 static int fill_buffer(struct debug_buffer *buf)
 {
-	int ret = 0;
+	int ret;
 
 	if (!buf->output_buf)
 		buf->output_buf = vmalloc(buf->alloc_size);
@@ -956,7 +956,7 @@ static ssize_t debug_output(struct file
 		size_t len, loff_t *offset)
 {
 	struct debug_buffer *buf = file->private_data;
-	int ret = 0;
+	int ret;
 
 	mutex_lock(&buf->mutex);
 	if (buf->count == 0) {
Index: usb/drivers/usb/host/ohci-dbg.c
===================================================================
--- usb.orig/drivers/usb/host/ohci-dbg.c
+++ usb/drivers/usb/host/ohci-dbg.c
@@ -680,7 +680,7 @@ static struct debug_buffer *alloc_buffer
 
 static int fill_buffer(struct debug_buffer *buf)
 {
-	int ret = 0;
+	int ret;
 
 	if (!buf->page)
 		buf->page = (char *)get_zeroed_page(GFP_KERNEL);
@@ -705,7 +705,7 @@ static ssize_t debug_output(struct file
 			size_t len, loff_t *offset)
 {
 	struct debug_buffer *buf = file->private_data;
-	int ret = 0;
+	int ret;
 
 	mutex_lock(&buf->mutex);
 	if (buf->count == 0) {

Re: [PATCH] usb: host: {e|o}hci-dbg: kill useless 'ret' variable initializers

[Alan Stern]

On Mon, Feb 14, 2022 at 10:56:16PM +0300, Sergey Shtylyov wrote:
> The 'ret' local variables are often initialized to 0 but this value is
> unused, thus we can kill those initializers...
> 
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> 
> ---

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> This patch is against the 'usb-next' branch of Greg KH's 'usb.git' repo.
> 
>  drivers/usb/host/ehci-dbg.c |    4 ++--
>  drivers/usb/host/ohci-dbg.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> Index: usb/drivers/usb/host/ehci-dbg.c
> ===================================================================
> --- usb.orig/drivers/usb/host/ehci-dbg.c
> +++ usb/drivers/usb/host/ehci-dbg.c
> @@ -931,7 +931,7 @@ static struct debug_buffer *alloc_buffer
>  
>  static int fill_buffer(struct debug_buffer *buf)
>  {
> -	int ret = 0;
> +	int ret;
>  
>  	if (!buf->output_buf)
>  		buf->output_buf = vmalloc(buf->alloc_size);
> @@ -956,7 +956,7 @@ static ssize_t debug_output(struct file
>  		size_t len, loff_t *offset)
>  {
>  	struct debug_buffer *buf = file->private_data;
> -	int ret = 0;
> +	int ret;
>  
>  	mutex_lock(&buf->mutex);
>  	if (buf->count == 0) {
> Index: usb/drivers/usb/host/ohci-dbg.c
> ===================================================================
> --- usb.orig/drivers/usb/host/ohci-dbg.c
> +++ usb/drivers/usb/host/ohci-dbg.c
> @@ -680,7 +680,7 @@ static struct debug_buffer *alloc_buffer
>  
>  static int fill_buffer(struct debug_buffer *buf)
>  {
> -	int ret = 0;
> +	int ret;
>  
>  	if (!buf->page)
>  		buf->page = (char *)get_zeroed_page(GFP_KERNEL);
> @@ -705,7 +705,7 @@ static ssize_t debug_output(struct file
>  			size_t len, loff_t *offset)
>  {
>  	struct debug_buffer *buf = file->private_data;
> -	int ret = 0;
> +	int ret;
>  
>  	mutex_lock(&buf->mutex);
>  	if (buf->count == 0) {
>