From: Lee Jones <lee.jones@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use
Date: Mon, 14 Mar 2022 12:47:50 +0000 [thread overview]
Message-ID: <Yi85dls3CCc2i1iK@google.com> (raw)
In-Reply-To: <20220314072137-mutt-send-email-mst@kernel.org>
On Mon, 14 Mar 2022, Michael S. Tsirkin wrote:
> On Mon, Mar 14, 2022 at 08:43:02AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virtqueue clean-up and we mitigate the reported issues.
> >
> > Also WARN() as a precautionary measure. The purpose of this is to
> > capture possible future race conditions which may pop up over time.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Pls refer to my previous responses to this patch. I'd like to see an
> argument for why this will make future bugs less and not more likely.
If you think the previous 'check owner' patch fixes all of the
concurrency issues, then this patch can be dropped.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use
Date: Mon, 14 Mar 2022 12:47:50 +0000 [thread overview]
Message-ID: <Yi85dls3CCc2i1iK@google.com> (raw)
In-Reply-To: <20220314072137-mutt-send-email-mst@kernel.org>
On Mon, 14 Mar 2022, Michael S. Tsirkin wrote:
> On Mon, Mar 14, 2022 at 08:43:02AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do here is take the same lock
> > during virtqueue clean-up and we mitigate the reported issues.
> >
> > Also WARN() as a precautionary measure. The purpose of this is to
> > capture possible future race conditions which may pop up over time.
> >
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Pls refer to my previous responses to this patch. I'd like to see an
> argument for why this will make future bugs less and not more likely.
If you think the previous 'check owner' patch fixes all of the
concurrency issues, then this patch can be dropped.
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-03-14 12:48 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 8:43 [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use Lee Jones
2022-03-14 8:43 ` Lee Jones
2022-03-14 8:56 ` Greg KH
2022-03-14 8:56 ` Greg KH
2022-03-14 11:49 ` Michael S. Tsirkin
2022-03-14 11:49 ` Michael S. Tsirkin
2022-03-14 12:47 ` Lee Jones [this message]
2022-03-14 12:47 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 19:17 Lee Jones
2022-03-07 19:17 ` Lee Jones
2022-03-07 19:33 ` Greg KH
2022-03-07 19:33 ` Greg KH
2022-03-07 22:39 ` Michael S. Tsirkin
2022-03-07 22:39 ` Michael S. Tsirkin
2022-03-08 8:10 ` Lee Jones
2022-03-08 8:10 ` Lee Jones
2022-03-08 8:11 ` Lee Jones
2022-03-08 8:11 ` Lee Jones
2022-03-08 8:57 ` Greg KH
2022-03-08 8:57 ` Greg KH
2022-03-08 9:15 ` Lee Jones
2022-03-08 9:15 ` Lee Jones
2022-03-08 9:57 ` Greg KH
2022-03-08 9:57 ` Greg KH
2022-03-08 10:08 ` Lee Jones
2022-03-08 10:08 ` Lee Jones
2022-03-08 10:55 ` Michael S. Tsirkin
2022-03-08 10:55 ` Michael S. Tsirkin
2022-03-08 11:45 ` Greg KH
2022-03-08 11:45 ` Greg KH
2022-03-08 12:27 ` Michael S. Tsirkin
2022-03-08 12:27 ` Michael S. Tsirkin
2022-03-08 13:17 ` Lee Jones
2022-03-08 13:17 ` Lee Jones
2022-03-08 17:17 ` Michael S. Tsirkin
2022-03-08 17:17 ` Michael S. Tsirkin
2022-03-08 11:05 ` Michael S. Tsirkin
2022-03-08 11:05 ` Michael S. Tsirkin
2022-03-09 18:52 ` Leon Romanovsky
2022-03-09 18:52 ` Leon Romanovsky
2022-03-07 22:37 ` Michael S. Tsirkin
2022-03-07 22:37 ` Michael S. Tsirkin
2022-03-08 8:01 ` Lee Jones
2022-03-08 8:01 ` Lee Jones
2022-03-08 11:07 ` Michael S. Tsirkin
2022-03-08 11:07 ` Michael S. Tsirkin
2022-03-08 6:15 ` Jason Wang
2022-03-08 6:15 ` Jason Wang
2022-03-08 8:08 ` Lee Jones
2022-03-08 8:08 ` Lee Jones
2022-03-08 11:06 ` Michael S. Tsirkin
2022-03-08 11:06 ` Michael S. Tsirkin
2022-03-02 7:54 Lee Jones
2022-03-02 7:54 ` Lee Jones
2022-03-02 9:34 ` Stefano Garzarella
2022-03-02 9:34 ` Stefano Garzarella
2022-03-02 10:07 ` Lee Jones
2022-03-02 10:07 ` Lee Jones
2022-03-02 13:35 ` Michael S. Tsirkin
2022-03-02 13:35 ` Michael S. Tsirkin
2022-03-02 14:11 ` Stefano Garzarella
2022-03-02 14:11 ` Stefano Garzarella
2022-03-02 14:50 ` Michael S. Tsirkin
2022-03-02 14:50 ` Michael S. Tsirkin
2022-03-02 15:36 ` Stefano Garzarella
2022-03-02 15:36 ` Stefano Garzarella
2022-03-04 16:46 ` Michael S. Tsirkin
2022-03-04 16:46 ` Michael S. Tsirkin
2022-03-02 13:30 ` Michael S. Tsirkin
2022-03-02 13:30 ` Michael S. Tsirkin
2022-03-02 13:56 ` Lee Jones
2022-03-02 13:56 ` Lee Jones
2022-03-02 14:51 ` Michael S. Tsirkin
2022-03-02 14:51 ` Michael S. Tsirkin
2022-03-02 14:57 ` Lee Jones
2022-03-02 14:57 ` Lee Jones
2022-03-02 16:28 ` Stefano Garzarella
2022-03-02 16:28 ` Stefano Garzarella
2022-03-02 16:30 ` Michael S. Tsirkin
2022-03-02 16:30 ` Michael S. Tsirkin
2022-03-02 16:49 ` Lee Jones
2022-03-02 16:49 ` Lee Jones
2022-03-02 17:10 ` Stefano Garzarella
2022-03-02 17:10 ` Stefano Garzarella
2022-03-03 14:17 ` Lee Jones
2022-03-03 14:17 ` Lee Jones
2022-03-04 5:00 ` Michael S. Tsirkin
2022-03-04 5:00 ` Michael S. Tsirkin
2022-03-04 15:22 ` Lee Jones
2022-03-04 15:22 ` Lee Jones
2022-03-04 16:48 ` Michael S. Tsirkin
2022-03-04 16:48 ` Michael S. Tsirkin
2022-03-04 16:56 ` Lee Jones
2022-03-04 16:56 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yi85dls3CCc2i1iK@google.com \
--to=lee.jones@linaro.org \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.