From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: "Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
devicetree@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
robert.foss@linaro.org, "Rob Herring" <robh+dt@kernel.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
dri-devel@lists.freedesktop.org,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Sam Ravnborg" <sam@ravnborg.org>
Subject: Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory
Date: Tue, 5 Apr 2022 12:08:47 +0300 [thread overview]
Message-ID: <YkwHH6RXZ3jZ56Cz@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220404192105.12547-1-marex@denx.de>
Hi Marek,
Thank you for the patch.
On Mon, Apr 04, 2022 at 09:21:05PM +0200, Marek Vasut wrote:
> Make the width-mm/height-mm panel properties mandatory
> to correctly report the panel dimensions to the OS.
>
> Fixes: 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> index f29789994b180..c2df8d28aaf5f 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> @@ -83,6 +83,8 @@ properties:
> required:
> - compatible
> - reg
> + - width-mm
> + - height-mm
> - panel-timing
>
> unevaluatedProperties: false
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Marek Vasut <marex@denx.de>
Cc: dri-devel@lists.freedesktop.org, robert.foss@linaro.org,
"Christoph Niedermaier" <cniedermaier@dh-electronics.com>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Noralf Trønnes" <noralf@tronnes.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sam Ravnborg" <sam@ravnborg.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory
Date: Tue, 5 Apr 2022 12:08:47 +0300 [thread overview]
Message-ID: <YkwHH6RXZ3jZ56Cz@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220404192105.12547-1-marex@denx.de>
Hi Marek,
Thank you for the patch.
On Mon, Apr 04, 2022 at 09:21:05PM +0200, Marek Vasut wrote:
> Make the width-mm/height-mm panel properties mandatory
> to correctly report the panel dimensions to the OS.
>
> Fixes: 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Noralf Trønnes <noralf@tronnes.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Robert Foss <robert.foss@linaro.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> index f29789994b180..c2df8d28aaf5f 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> @@ -83,6 +83,8 @@ properties:
> required:
> - compatible
> - reg
> + - width-mm
> + - height-mm
> - panel-timing
>
> unevaluatedProperties: false
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-04-05 9:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 19:21 [PATCH] dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory Marek Vasut
2022-04-04 19:21 ` Marek Vasut
2022-04-05 8:35 ` Noralf Trønnes
2022-04-05 8:35 ` Noralf Trønnes
2022-04-05 9:08 ` Laurent Pinchart [this message]
2022-04-05 9:08 ` Laurent Pinchart
2022-04-06 18:06 ` Rob Herring
2022-04-06 18:06 ` Rob Herring
2022-04-08 14:50 ` Noralf Trønnes
2022-04-08 14:50 ` Noralf Trønnes
2022-04-08 17:55 ` Marek Vasut
2022-04-08 17:55 ` Marek Vasut
2022-04-08 20:38 ` Noralf Trønnes
2022-04-08 20:38 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkwHH6RXZ3jZ56Cz@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=cniedermaier@dh-electronics.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=marex@denx.de \
--cc=noralf@tronnes.org \
--cc=robert.foss@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.