* [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-13 2:08 ` Chao Liu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-13 2:08 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu, Jonathan Corbet
Cc: linux-f2fs-devel, linux-doc, linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
From: Chao Liu <liuchao@coolpad.com>
Since commit c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED
instead of using IMMUTABLE bit"), we no longer use the IMMUTABLE
bit to prevent writing data for compression. Let's correct the
corresponding documentation.
BTW, this patch fixes some alignment issues in the compress
metadata layout.
Signed-off-by: Chao Liu <liuchao@coolpad.com>
---
v2:
- s/file size/filesize/
Documentation/filesystems/f2fs.rst | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
index ad8dc8c040a2..531b0f8a3946 100644
--- a/Documentation/filesystems/f2fs.rst
+++ b/Documentation/filesystems/f2fs.rst
@@ -818,10 +818,11 @@ Compression implementation
Instead, the main goal is to reduce data writes to flash disk as much as
possible, resulting in extending disk life time as well as relaxing IO
congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
- interface to reclaim compressed space and show it to user after putting the
- immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
- on the file, until reserving compressed space via
- ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
+ interface to reclaim compressed space and show it to user after setting a
+ special flag to the inode. Once the compressed space is released, the flag
+ will block writing data to the file until either the compressed space is
+ reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
+ truncated to zero.
Compress metadata layout::
@@ -830,12 +831,12 @@ Compress metadata layout::
| cluster 1 | cluster 2 | ......... | cluster N |
+-----------------------------------------------+
. . . .
- . . . .
+ . . . .
. Compressed Cluster . . Normal Cluster .
+----------+---------+---------+---------+ +---------+---------+---------+---------+
|compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
+----------+---------+---------+---------+ +---------+---------+---------+---------+
- . .
+ . .
. .
. .
+-------------+-------------+----------+----------------------------+
--
2.36.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-13 2:08 ` Chao Liu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-13 2:08 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu, Jonathan Corbet
Cc: linux-doc, Chao Liu, linux-kernel, Wayne Zhang, Yue Hu, linux-f2fs-devel
From: Chao Liu <liuchao@coolpad.com>
Since commit c61404153eb6 ("f2fs: introduce FI_COMPRESS_RELEASED
instead of using IMMUTABLE bit"), we no longer use the IMMUTABLE
bit to prevent writing data for compression. Let's correct the
corresponding documentation.
BTW, this patch fixes some alignment issues in the compress
metadata layout.
Signed-off-by: Chao Liu <liuchao@coolpad.com>
---
v2:
- s/file size/filesize/
Documentation/filesystems/f2fs.rst | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
index ad8dc8c040a2..531b0f8a3946 100644
--- a/Documentation/filesystems/f2fs.rst
+++ b/Documentation/filesystems/f2fs.rst
@@ -818,10 +818,11 @@ Compression implementation
Instead, the main goal is to reduce data writes to flash disk as much as
possible, resulting in extending disk life time as well as relaxing IO
congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
- interface to reclaim compressed space and show it to user after putting the
- immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
- on the file, until reserving compressed space via
- ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
+ interface to reclaim compressed space and show it to user after setting a
+ special flag to the inode. Once the compressed space is released, the flag
+ will block writing data to the file until either the compressed space is
+ reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
+ truncated to zero.
Compress metadata layout::
@@ -830,12 +831,12 @@ Compress metadata layout::
| cluster 1 | cluster 2 | ......... | cluster N |
+-----------------------------------------------+
. . . .
- . . . .
+ . . . .
. Compressed Cluster . . Normal Cluster .
+----------+---------+---------+---------+ +---------+---------+---------+---------+
|compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
+----------+---------+---------+---------+ +---------+---------+---------+---------+
- . .
+ . .
. .
. .
+-------------+-------------+----------+----------------------------+
--
2.36.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
2022-06-13 2:08 ` [f2fs-dev] " Chao Liu
@ 2022-06-13 3:37 ` Matthew Wilcox
-1 siblings, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2022-06-13 3:37 UTC (permalink / raw)
To: Chao Liu
Cc: Jaegeuk Kim, Chao Yu, Jonathan Corbet, linux-f2fs-devel,
linux-doc, linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> v2:
> - s/file size/filesize/
Why would you change it to be wrong?
> Documentation/filesystems/f2fs.rst | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index ad8dc8c040a2..531b0f8a3946 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -818,10 +818,11 @@ Compression implementation
> Instead, the main goal is to reduce data writes to flash disk as much as
> possible, resulting in extending disk life time as well as relaxing IO
> congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
> - interface to reclaim compressed space and show it to user after putting the
> - immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
> - on the file, until reserving compressed space via
> - ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
> + interface to reclaim compressed space and show it to user after setting a
> + special flag to the inode. Once the compressed space is released, the flag
> + will block writing data to the file until either the compressed space is
> + reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
> + truncated to zero.
>
> Compress metadata layout::
>
> @@ -830,12 +831,12 @@ Compress metadata layout::
> | cluster 1 | cluster 2 | ......... | cluster N |
> +-----------------------------------------------+
> . . . .
> - . . . .
> + . . . .
> . Compressed Cluster . . Normal Cluster .
> +----------+---------+---------+---------+ +---------+---------+---------+---------+
> |compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
> +----------+---------+---------+---------+ +---------+---------+---------+---------+
> - . .
> + . .
> . .
> . .
> +-------------+-------------+----------+----------------------------+
> --
> 2.36.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-13 3:37 ` Matthew Wilcox
0 siblings, 0 replies; 12+ messages in thread
From: Matthew Wilcox @ 2022-06-13 3:37 UTC (permalink / raw)
To: Chao Liu
Cc: Jonathan Corbet, Chao Liu, linux-doc, linux-kernel,
linux-f2fs-devel, Yue Hu, Jaegeuk Kim, Wayne Zhang
On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> v2:
> - s/file size/filesize/
Why would you change it to be wrong?
> Documentation/filesystems/f2fs.rst | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> index ad8dc8c040a2..531b0f8a3946 100644
> --- a/Documentation/filesystems/f2fs.rst
> +++ b/Documentation/filesystems/f2fs.rst
> @@ -818,10 +818,11 @@ Compression implementation
> Instead, the main goal is to reduce data writes to flash disk as much as
> possible, resulting in extending disk life time as well as relaxing IO
> congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
> - interface to reclaim compressed space and show it to user after putting the
> - immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
> - on the file, until reserving compressed space via
> - ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
> + interface to reclaim compressed space and show it to user after setting a
> + special flag to the inode. Once the compressed space is released, the flag
> + will block writing data to the file until either the compressed space is
> + reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
> + truncated to zero.
>
> Compress metadata layout::
>
> @@ -830,12 +831,12 @@ Compress metadata layout::
> | cluster 1 | cluster 2 | ......... | cluster N |
> +-----------------------------------------------+
> . . . .
> - . . . .
> + . . . .
> . Compressed Cluster . . Normal Cluster .
> +----------+---------+---------+---------+ +---------+---------+---------+---------+
> |compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
> +----------+---------+---------+---------+ +---------+---------+---------+---------+
> - . .
> + . .
> . .
> . .
> +-------------+-------------+----------+----------------------------+
> --
> 2.36.1
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
2022-06-13 3:37 ` [f2fs-dev] " Matthew Wilcox
@ 2022-06-13 8:02 ` Chao Liu
-1 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-13 8:02 UTC (permalink / raw)
To: Matthew Wilcox, Chao Yu
Cc: Jaegeuk Kim, Jonathan Corbet, linux-f2fs-devel, linux-doc,
linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> > v2:
> > - s/file size/filesize/
>
> Why would you change it to be wrong?
>
This is a suggestion from Chao Yu. Maybe he has some other considerations.
Hi Chao,
Can you help with this question?
Thanks.
> > Documentation/filesystems/f2fs.rst | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> > index ad8dc8c040a2..531b0f8a3946 100644
> > --- a/Documentation/filesystems/f2fs.rst
> > +++ b/Documentation/filesystems/f2fs.rst
> > @@ -818,10 +818,11 @@ Compression implementation
> > Instead, the main goal is to reduce data writes to flash disk as much as
> > possible, resulting in extending disk life time as well as relaxing IO
> > congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
> > - interface to reclaim compressed space and show it to user after putting the
> > - immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
> > - on the file, until reserving compressed space via
> > - ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
> > + interface to reclaim compressed space and show it to user after setting a
> > + special flag to the inode. Once the compressed space is released, the flag
> > + will block writing data to the file until either the compressed space is
> > + reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
> > + truncated to zero.
> >
> > Compress metadata layout::
> >
> > @@ -830,12 +831,12 @@ Compress metadata layout::
> > | cluster 1 | cluster 2 | ......... | cluster N |
> > +-----------------------------------------------+
> > . . . .
> > - . . . .
> > + . . . .
> > . Compressed Cluster . . Normal Cluster .
> > +----------+---------+---------+---------+ +---------+---------+---------+---------+
> > |compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
> > +----------+---------+---------+---------+ +---------+---------+---------+---------+
> > - . .
> > + . .
> > . .
> > . .
> > +-------------+-------------+----------+----------------------------+
> > --
> > 2.36.1
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-13 8:02 ` Chao Liu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-13 8:02 UTC (permalink / raw)
To: Matthew Wilcox, Chao Yu
Cc: Chao Liu, linux-doc, Jonathan Corbet, linux-kernel,
linux-f2fs-devel, Yue Hu, Jaegeuk Kim, Wayne Zhang
On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> > v2:
> > - s/file size/filesize/
>
> Why would you change it to be wrong?
>
This is a suggestion from Chao Yu. Maybe he has some other considerations.
Hi Chao,
Can you help with this question?
Thanks.
> > Documentation/filesystems/f2fs.rst | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesystems/f2fs.rst
> > index ad8dc8c040a2..531b0f8a3946 100644
> > --- a/Documentation/filesystems/f2fs.rst
> > +++ b/Documentation/filesystems/f2fs.rst
> > @@ -818,10 +818,11 @@ Compression implementation
> > Instead, the main goal is to reduce data writes to flash disk as much as
> > possible, resulting in extending disk life time as well as relaxing IO
> > congestion. Alternatively, we've added ioctl(F2FS_IOC_RELEASE_COMPRESS_BLOCKS)
> > - interface to reclaim compressed space and show it to user after putting the
> > - immutable bit. Immutable bit, after release, it doesn't allow writing/mmaping
> > - on the file, until reserving compressed space via
> > - ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or truncating filesize to zero.
> > + interface to reclaim compressed space and show it to user after setting a
> > + special flag to the inode. Once the compressed space is released, the flag
> > + will block writing data to the file until either the compressed space is
> > + reserved via ioctl(F2FS_IOC_RESERVE_COMPRESS_BLOCKS) or the filesize is
> > + truncated to zero.
> >
> > Compress metadata layout::
> >
> > @@ -830,12 +831,12 @@ Compress metadata layout::
> > | cluster 1 | cluster 2 | ......... | cluster N |
> > +-----------------------------------------------+
> > . . . .
> > - . . . .
> > + . . . .
> > . Compressed Cluster . . Normal Cluster .
> > +----------+---------+---------+---------+ +---------+---------+---------+---------+
> > |compr flag| block 1 | block 2 | block 3 | | block 1 | block 2 | block 3 | block 4 |
> > +----------+---------+---------+---------+ +---------+---------+---------+---------+
> > - . .
> > + . .
> > . .
> > . .
> > +-------------+-------------+----------+----------------------------+
> > --
> > 2.36.1
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
2022-06-13 8:02 ` [f2fs-dev] " Chao Liu
@ 2022-06-13 17:23 ` Jonathan Corbet
-1 siblings, 0 replies; 12+ messages in thread
From: Jonathan Corbet @ 2022-06-13 17:23 UTC (permalink / raw)
To: Chao Liu, Matthew Wilcox, Chao Yu
Cc: linux-doc, Chao Liu, linux-kernel, Wayne Zhang, Yue Hu,
Jaegeuk Kim, linux-f2fs-devel
Chao Liu <chaoliu719@gmail.com> writes:
> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>> > v2:
>> > - s/file size/filesize/
>>
>> Why would you change it to be wrong?
>>
>
> This is a suggestion from Chao Yu. Maybe he has some other considerations.
Sorry, I should have replied to that. I disagree with that suggestion.
"Filesize" is not an English word, and there doesn't seem to be any
reason to use it in our docs.
<checks>
We have to occurrences now - one already in the f2fs docs. I think we
shouldn't add more. So my plan is to apply the first version of this
patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
from Chao Yu in the second version? Chao Yu: is that tag still
applicable even without the "filesize" change?
Thanks,
jon
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-13 17:23 ` Jonathan Corbet
0 siblings, 0 replies; 12+ messages in thread
From: Jonathan Corbet @ 2022-06-13 17:23 UTC (permalink / raw)
To: Chao Liu, Matthew Wilcox, Chao Yu
Cc: Jaegeuk Kim, linux-f2fs-devel, linux-doc, linux-kernel, Yue Hu,
Wayne Zhang, Chao Liu
Chao Liu <chaoliu719@gmail.com> writes:
> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>> > v2:
>> > - s/file size/filesize/
>>
>> Why would you change it to be wrong?
>>
>
> This is a suggestion from Chao Yu. Maybe he has some other considerations.
Sorry, I should have replied to that. I disagree with that suggestion.
"Filesize" is not an English word, and there doesn't seem to be any
reason to use it in our docs.
<checks>
We have to occurrences now - one already in the f2fs docs. I think we
shouldn't add more. So my plan is to apply the first version of this
patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
from Chao Yu in the second version? Chao Yu: is that tag still
applicable even without the "filesize" change?
Thanks,
jon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
2022-06-13 17:23 ` Jonathan Corbet
@ 2022-06-14 1:48 ` Chao Yu
-1 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2022-06-14 1:48 UTC (permalink / raw)
To: Jonathan Corbet, Chao Liu, Matthew Wilcox
Cc: Jaegeuk Kim, linux-f2fs-devel, linux-doc, linux-kernel, Yue Hu,
Wayne Zhang, Chao Liu
On 2022/6/14 1:23, Jonathan Corbet wrote:
> Chao Liu <chaoliu719@gmail.com> writes:
>
>> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>>>> v2:
>>>> - s/file size/filesize/
>>>
>>> Why would you change it to be wrong?
>>>
>>
>> This is a suggestion from Chao Yu. Maybe he has some other considerations.
>
> Sorry, I should have replied to that. I disagree with that suggestion.
> "Filesize" is not an English word, and there doesn't seem to be any
> reason to use it in our docs.
My bad, out of mind at that time, sorry for my wrong suggestion...
>
> <checks>
>
> We have to occurrences now - one already in the f2fs docs. I think we
> shouldn't add more. So my plan is to apply the first version of this
> patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
> from Chao Yu in the second version? Chao Yu: is that tag still
> applicable even without the "filesize" change?
Yes.
Thanks,
>
> Thanks,
>
> jon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-14 1:48 ` Chao Yu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Yu @ 2022-06-14 1:48 UTC (permalink / raw)
To: Jonathan Corbet, Chao Liu, Matthew Wilcox
Cc: linux-doc, Chao Liu, linux-kernel, Wayne Zhang, Yue Hu,
Jaegeuk Kim, linux-f2fs-devel
On 2022/6/14 1:23, Jonathan Corbet wrote:
> Chao Liu <chaoliu719@gmail.com> writes:
>
>> On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
>>> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
>>>> v2:
>>>> - s/file size/filesize/
>>>
>>> Why would you change it to be wrong?
>>>
>>
>> This is a suggestion from Chao Yu. Maybe he has some other considerations.
>
> Sorry, I should have replied to that. I disagree with that suggestion.
> "Filesize" is not an English word, and there doesn't seem to be any
> reason to use it in our docs.
My bad, out of mind at that time, sorry for my wrong suggestion...
>
> <checks>
>
> We have to occurrences now - one already in the f2fs docs. I think we
> shouldn't add more. So my plan is to apply the first version of this
> patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
> from Chao Yu in the second version? Chao Yu: is that tag still
> applicable even without the "filesize" change?
Yes.
Thanks,
>
> Thanks,
>
> jon
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [f2fs-dev] [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
2022-06-13 17:23 ` Jonathan Corbet
@ 2022-06-14 2:49 ` Chao Liu
-1 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-14 2:49 UTC (permalink / raw)
To: Jonathan Corbet, Chao Yu
Cc: linux-doc, Chao Liu, linux-kernel, Matthew Wilcox,
linux-f2fs-devel, Yue Hu, Jaegeuk Kim, Wayne Zhang
On Mon, Jun 13, 2022 at 11:23:07AM -0600, Jonathan Corbet wrote:
> Chao Liu <chaoliu719@gmail.com> writes:
>
> > On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
> >> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> >> > v2:
> >> > - s/file size/filesize/
> >>
> >> Why would you change it to be wrong?
> >>
> >
> > This is a suggestion from Chao Yu. Maybe he has some other considerations.
>
> Sorry, I should have replied to that. I disagree with that suggestion.
> "Filesize" is not an English word, and there doesn't seem to be any
> reason to use it in our docs.
>
> <checks>
>
> We have to occurrences now - one already in the f2fs docs. I think we
> shouldn't add more. So my plan is to apply the first version of this
> patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
> from Chao Yu in the second version?
Sorry for my carelessness. I should have added it.
Thanks,
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl
@ 2022-06-14 2:49 ` Chao Liu
0 siblings, 0 replies; 12+ messages in thread
From: Chao Liu @ 2022-06-14 2:49 UTC (permalink / raw)
To: Jonathan Corbet, Chao Yu
Cc: Matthew Wilcox, Jaegeuk Kim, linux-f2fs-devel, linux-doc,
linux-kernel, Yue Hu, Wayne Zhang, Chao Liu
On Mon, Jun 13, 2022 at 11:23:07AM -0600, Jonathan Corbet wrote:
> Chao Liu <chaoliu719@gmail.com> writes:
>
> > On Mon, Jun 13, 2022 at 04:37:01AM +0100, Matthew Wilcox wrote:
> >> On Mon, Jun 13, 2022 at 10:08:00AM +0800, Chao Liu wrote:
> >> > v2:
> >> > - s/file size/filesize/
> >>
> >> Why would you change it to be wrong?
> >>
> >
> > This is a suggestion from Chao Yu. Maybe he has some other considerations.
>
> Sorry, I should have replied to that. I disagree with that suggestion.
> "Filesize" is not an English word, and there doesn't seem to be any
> reason to use it in our docs.
>
> <checks>
>
> We have to occurrences now - one already in the f2fs docs. I think we
> shouldn't add more. So my plan is to apply the first version of this
> patch. Chao Liu: is there a reason why you didn't add the Reviewed-by
> from Chao Yu in the second version?
Sorry for my carelessness. I should have added it.
Thanks,
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-06-14 2:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-13 2:08 [PATCH v2] docs: filesystems: f2fs: fix description about compress ioctl Chao Liu
2022-06-13 2:08 ` [f2fs-dev] " Chao Liu
2022-06-13 3:37 ` Matthew Wilcox
2022-06-13 3:37 ` [f2fs-dev] " Matthew Wilcox
2022-06-13 8:02 ` Chao Liu
2022-06-13 8:02 ` [f2fs-dev] " Chao Liu
2022-06-13 17:23 ` Jonathan Corbet
2022-06-13 17:23 ` Jonathan Corbet
2022-06-14 1:48 ` Chao Yu
2022-06-14 1:48 ` [f2fs-dev] " Chao Yu
2022-06-14 2:49 ` Chao Liu
2022-06-14 2:49 ` Chao Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.