All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Waiman Long <longman@redhat.com>,
	Zefan Li <lizefan.x@bytedance.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Jonathan Corbet <corbet@lwn.net>, Shuah Khan <shuah@kernel.org>,
	cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Gushchin <guro@fb.com>, Phil Auld <pauld@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v11 7/8] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst
Date: Mon, 13 Jun 2022 08:00:56 -1000	[thread overview]
Message-ID: <Yqd7WMFj6AEyV3Cy@slm.duckdns.org> (raw)
In-Reply-To: <20220613175548.GB21665@blackbody.suse.cz>

Hello,

On Mon, Jun 13, 2022 at 07:55:49PM +0200, Michal Koutný wrote:
> On Mon, Jun 13, 2022 at 07:28:25AM -1000, Tejun Heo <tj@kernel.org> wrote:
> > I see. Is this part even necessary? All the .cpus files of the siblings are
> > owned by the parent who's responsible for configuring both the mode that the
> > cgroup subtree is gonna be in and their cpumasks. 
> 
> Do you mean such an example:
> 
>     parent	cpuset.cpus=SET (root)	cpuset.cpus.partition=isolated 
>     `- child_1	cpuset.cpus=partition_of(SET) (root)	cpuset.cpus.partition=isolated
>     `- ...
>     `- child_n	cpuset.cpus=partition_of(SET) (root)	cpuset.cpus.partition=isolated
> ?
> 
> I don't think child_*/cpuset.cpus must be owned by root.

I meant the parent.

> Actually, the root would only configure the parent, i.e.
> parent/cpuset.cpus (whose changes would be disallowed to the
> unprivileged tasks) and the distribution among siblings would up to the
> whatever runs below.
> 
> > Given that all the other errors it can make are notified through
> > "invalid (REASON)" in the mode file, wouldn't it fit better to notify
> > cpus configuration error the same way too?
> 
> Do you suggest that a write into child_*/cpuset.cpus that'd not be
> exclusive wrt a sibling would result in an error string in
> parent/cpuset.cpus.partition?

Yeah, I don't know why this part is different from any other errors that the
parent can make.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>
Cc: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Zefan Li <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
	Shuah Khan <shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Roman Gushchin <guro-b10kYP2dOMg@public.gmane.org>,
	Phil Auld <pauld-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Peter Zijlstra <peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Juri Lelli <juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Frederic Weisbecker
	<frederic-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Marcelo Tosatti
	<mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v11 7/8] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst
Date: Mon, 13 Jun 2022 08:00:56 -1000	[thread overview]
Message-ID: <Yqd7WMFj6AEyV3Cy@slm.duckdns.org> (raw)
In-Reply-To: <20220613175548.GB21665-9OudH3eul5jcvrawFnH+a6VXKuFTiq87@public.gmane.org>

Hello,

On Mon, Jun 13, 2022 at 07:55:49PM +0200, Michal Koutný wrote:
> On Mon, Jun 13, 2022 at 07:28:25AM -1000, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > I see. Is this part even necessary? All the .cpus files of the siblings are
> > owned by the parent who's responsible for configuring both the mode that the
> > cgroup subtree is gonna be in and their cpumasks. 
> 
> Do you mean such an example:
> 
>     parent	cpuset.cpus=SET (root)	cpuset.cpus.partition=isolated 
>     `- child_1	cpuset.cpus=partition_of(SET) (root)	cpuset.cpus.partition=isolated
>     `- ...
>     `- child_n	cpuset.cpus=partition_of(SET) (root)	cpuset.cpus.partition=isolated
> ?
> 
> I don't think child_*/cpuset.cpus must be owned by root.

I meant the parent.

> Actually, the root would only configure the parent, i.e.
> parent/cpuset.cpus (whose changes would be disallowed to the
> unprivileged tasks) and the distribution among siblings would up to the
> whatever runs below.
> 
> > Given that all the other errors it can make are notified through
> > "invalid (REASON)" in the mode file, wouldn't it fit better to notify
> > cpus configuration error the same way too?
> 
> Do you suggest that a write into child_*/cpuset.cpus that'd not be
> exclusive wrt a sibling would result in an error string in
> parent/cpuset.cpus.partition?

Yeah, I don't know why this part is different from any other errors that the
parent can make.

Thanks.

-- 
tejun

  reply	other threads:[~2022-06-13 19:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 15:34 [PATCH v11 0/8] cgroup/cpuset: cpu partition code enhancements Waiman Long
2022-05-10 15:34 ` [PATCH v11 1/8] cgroup/cpuset: Add top_cpuset check in update_tasks_cpumask() Waiman Long
2022-05-10 15:34   ` Waiman Long
2022-05-10 15:34 ` [PATCH v11 2/8] cgroup/cpuset: Miscellaneous cleanups & add helper functions Waiman Long
2022-05-10 15:34 ` [PATCH v11 3/8] cgroup/cpuset: Allow no-task partition to have empty cpuset.cpus.effective Waiman Long
2022-06-12 17:40   ` Tejun Heo
2022-06-12 17:41     ` Tejun Heo
2022-06-13  2:53       ` Waiman Long
2022-06-13  2:55         ` Tejun Heo
2022-06-13  3:04           ` Waiman Long
2022-06-13  3:04             ` Waiman Long
2022-06-13 14:02           ` Michal Koutný
2022-06-13 14:02             ` Michal Koutný
2022-06-13 16:47             ` Waiman Long
2022-06-13 16:47               ` Waiman Long
2022-06-13 17:23               ` Tejun Heo
2022-06-13  2:50     ` Waiman Long
2022-05-10 15:34 ` [PATCH v11 4/8] cgroup/cpuset: Relax constraints to partition & cpus changes Waiman Long
2022-05-10 15:34   ` Waiman Long
2022-05-10 15:34 ` [PATCH v11 5/8] cgroup/cpuset: Add a new isolated cpus.partition type Waiman Long
2022-05-10 15:34   ` Waiman Long
2022-05-10 15:34 ` [PATCH v11 6/8] cgroup/cpuset: Show invalid partition reason string Waiman Long
2022-05-10 15:34 ` [PATCH v11 7/8] cgroup/cpuset: Update description of cpuset.cpus.partition in cgroup-v2.rst Waiman Long
2022-06-12 17:49   ` Tejun Heo
2022-06-13  3:02     ` Waiman Long
2022-06-13  3:12       ` Tejun Heo
2022-06-13  3:12         ` Tejun Heo
2022-06-13 13:18         ` Waiman Long
2022-06-13 17:06           ` Waiman Long
2022-06-13 14:24         ` Michal Koutný
2022-06-13 14:24           ` Michal Koutný
2022-06-13 17:28           ` Tejun Heo
2022-06-13 17:55             ` Michal Koutný
2022-06-13 18:00               ` Tejun Heo [this message]
2022-06-13 18:00                 ` Tejun Heo
2022-06-14 11:53                 ` Michal Koutný
2022-06-14 11:53                   ` Michal Koutný
2022-06-27 19:10                   ` Tejun Heo
2022-06-27 19:10                     ` Tejun Heo
2022-06-30 14:32                     ` Michal Koutný
2022-06-30 22:53                       ` Tejun Heo
2022-05-10 15:34 ` [PATCH v11 8/8] kselftest/cgroup: Add cpuset v2 partition root state test Waiman Long
2022-05-21 10:24   ` Muhammad Usama Anjum
2022-05-21 10:24     ` Muhammad Usama Anjum
2022-05-22  2:40     ` Waiman Long
2022-05-20 16:00 ` [PATCH v11 0/8] cgroup/cpuset: cpu partition code enhancements Sebastian Andrzej Siewior
2022-05-20 16:46   ` Waiman Long
2022-05-24 16:48     ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yqd7WMFj6AEyV3Cy@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=frederic@kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=longman@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=mtosatti@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.