From: Daniel Vetter <daniel@ffwll.ch> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, "Jens Axboe" <axboe@kernel.dk>, linux-fsdevel@vger.kernel.org, "Sumit Semwal" <sumit.semwal@linaro.org>, dri-devel@lists.freedesktop.org, "Christian König" <christian.koenig@amd.com> Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Date: Mon, 27 Jun 2022 11:08:32 +0200 [thread overview] Message-ID: <YrlzkAlheCR0ZMuO@phenom.ffwll.local> (raw) In-Reply-To: <20220625110115.39956-8-Jason@zx2c4.com> On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Christian König <christian.koenig@amd.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: "Jason A. Donenfeld" <Jason@zx2c4.com> Cc: "Jens Axboe" <axboe@kernel.dk>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Christian König" <christian.koenig@amd.com>, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, "Sumit Semwal" <sumit.semwal@linaro.org> Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Date: Mon, 27 Jun 2022 11:08:32 +0200 [thread overview] Message-ID: <YrlzkAlheCR0ZMuO@phenom.ffwll.local> (raw) In-Reply-To: <20220625110115.39956-8-Jason@zx2c4.com> On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > This is already set by anon_inode_getfile(), since dma_buf_fops has > non-NULL ->llseek, so we don't need to set it here too. > > Suggested-by: Al Viro <viro@zeniv.linux.org.uk> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Christian König <christian.koenig@amd.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> I'm assuming this is part of a vfs cleanup and lands through that tree? For that: Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/dma-buf/dma-buf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 32f55640890c..3f08e0b960ec 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf_export_info *exp_info) > goto err_dmabuf; > } > > - file->f_mode |= FMODE_LSEEK; > dmabuf->file = file; > > mutex_init(&dmabuf->lock); > -- > 2.35.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
next prev parent reply other threads:[~2022-06-27 9:08 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-25 11:01 [PATCH v2 0/8] cleanup llseek and splice Jason A. Donenfeld 2022-06-25 11:01 ` [PATCH v2 1/8] ksmbd: use vfs_llseek instead of dereferencing NULL Jason A. Donenfeld 2022-06-25 22:15 ` Jason A. Donenfeld 2022-06-26 0:54 ` Steve French 2022-06-25 11:01 ` [PATCH v2 2/8] fs: do not set no_llseek in fops Jason A. Donenfeld 2022-06-25 11:01 ` [PATCH v2 3/8] fs: clear or set FMODE_LSEEK based on llseek function Jason A. Donenfeld 2022-06-25 13:07 ` Christoph Hellwig 2022-06-25 13:29 ` Al Viro 2022-06-25 13:39 ` Christoph Hellwig 2022-06-25 14:11 ` Al Viro 2022-06-25 11:01 ` [PATCH v2 4/8] fs: check FMODE_LSEEK to control internal pipe splicing Jason A. Donenfeld 2022-06-25 11:01 ` [PATCH v2 5/8] fs: do not compare against ->llseek Jason A. Donenfeld 2022-06-25 11:01 ` [PATCH v2 6/8] fs: remove no_llseek Jason A. Donenfeld 2022-06-25 13:10 ` Christoph Hellwig 2022-06-25 21:53 ` Jason A. Donenfeld 2022-06-25 11:01 ` [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag Jason A. Donenfeld 2022-06-25 11:01 ` Jason A. Donenfeld 2022-06-27 9:08 ` Daniel Vetter [this message] 2022-06-27 9:08 ` Daniel Vetter 2022-06-27 9:38 ` Jason A. Donenfeld 2022-06-29 10:30 ` Sumit Semwal 2022-06-25 11:01 ` [PATCH v2 8/8] vfio: do not set " Jason A. Donenfeld 2022-06-27 20:07 ` Alex Williamson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YrlzkAlheCR0ZMuO@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=Jason@zx2c4.com \ --cc=axboe@kernel.dk \ --cc=christian.koenig@amd.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.