From: Yury Norov <yury.norov@gmail.com> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com, vneethv@linux.ibm.com, oberpar@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, almaz.alexandrovich@paragon-software.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, linux-s390@vger.kernel.org, ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/4] s390/cio: Rename bitmap_size() as idset_bitmap_size() Date: Sat, 2 Jul 2022 13:46:31 -0700 [thread overview] Message-ID: <YsCup7Kjzm9QWeZ5@yury-laptop> (raw) In-Reply-To: <3f2ad7fb91948525f6c52e0d36ec223cd3049c88.1656785856.git.christophe.jaillet@wanadoo.fr> On Sat, Jul 02, 2022 at 08:29:09PM +0200, Christophe JAILLET wrote: > In order to introduce a bitmap_size() function in the bitmap API, we have > to rename functions with a similar name. > > Add a "idset_" prefix and change bitmap_size() into idset_bitmap_size(). > > No functional change. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/s390/cio/idset.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c > index 45f9c0736be4..e1e77fe080bf 100644 > --- a/drivers/s390/cio/idset.c > +++ b/drivers/s390/cio/idset.c > @@ -16,7 +16,7 @@ struct idset { > unsigned long bitmap[]; > }; > > -static inline unsigned long bitmap_size(int num_ssid, int num_id) > +static inline unsigned long idset_bitmap_size(int num_ssid, int num_id) > { > return BITS_TO_LONGS(num_ssid * num_id) * sizeof(unsigned long); > } > @@ -25,11 +25,11 @@ static struct idset *idset_new(int num_ssid, int num_id) > { > struct idset *set; > > - set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id)); > + set = vmalloc(sizeof(struct idset) + idset_bitmap_size(num_ssid, num_id)); > if (set) { > set->num_ssid = num_ssid; > set->num_id = num_id; > - memset(set->bitmap, 0, bitmap_size(num_ssid, num_id)); > + memset(set->bitmap, 0, idset_bitmap_size(num_ssid, num_id)); We don't need bitmap_size() here, we need to replace memset() with bitmap_zero(). > } > return set; > } > @@ -41,7 +41,7 @@ void idset_free(struct idset *set) > > void idset_fill(struct idset *set) > { > - memset(set->bitmap, 0xff, bitmap_size(set->num_ssid, set->num_id)); > + memset(set->bitmap, 0xff, idset_bitmap_size(set->num_ssid, set->num_id)); Same, but bitmap_fill(). > } > > static inline void idset_add(struct idset *set, int ssid, int id) > -- > 2.34.1
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov <yury.norov@gmail.com> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: linux-s390@vger.kernel.org, kernel-janitors@vger.kernel.org, andriy.shevchenko@linux.intel.com, gor@linux.ibm.com, linux@rasmusvillemoes.dk, hca@linux.ibm.com, ntfs3@lists.linux.dev, snitzer@kernel.org, oberpar@linux.ibm.com, linux-kernel@vger.kernel.org, almaz.alexandrovich@paragon-software.com, dm-devel@redhat.com, svens@linux.ibm.com, vneethv@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, agk@redhat.com Subject: Re: [dm-devel] [PATCH 1/4] s390/cio: Rename bitmap_size() as idset_bitmap_size() Date: Sat, 2 Jul 2022 13:46:31 -0700 [thread overview] Message-ID: <YsCup7Kjzm9QWeZ5@yury-laptop> (raw) In-Reply-To: <3f2ad7fb91948525f6c52e0d36ec223cd3049c88.1656785856.git.christophe.jaillet@wanadoo.fr> On Sat, Jul 02, 2022 at 08:29:09PM +0200, Christophe JAILLET wrote: > In order to introduce a bitmap_size() function in the bitmap API, we have > to rename functions with a similar name. > > Add a "idset_" prefix and change bitmap_size() into idset_bitmap_size(). > > No functional change. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/s390/cio/idset.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/s390/cio/idset.c b/drivers/s390/cio/idset.c > index 45f9c0736be4..e1e77fe080bf 100644 > --- a/drivers/s390/cio/idset.c > +++ b/drivers/s390/cio/idset.c > @@ -16,7 +16,7 @@ struct idset { > unsigned long bitmap[]; > }; > > -static inline unsigned long bitmap_size(int num_ssid, int num_id) > +static inline unsigned long idset_bitmap_size(int num_ssid, int num_id) > { > return BITS_TO_LONGS(num_ssid * num_id) * sizeof(unsigned long); > } > @@ -25,11 +25,11 @@ static struct idset *idset_new(int num_ssid, int num_id) > { > struct idset *set; > > - set = vmalloc(sizeof(struct idset) + bitmap_size(num_ssid, num_id)); > + set = vmalloc(sizeof(struct idset) + idset_bitmap_size(num_ssid, num_id)); > if (set) { > set->num_ssid = num_ssid; > set->num_id = num_id; > - memset(set->bitmap, 0, bitmap_size(num_ssid, num_id)); > + memset(set->bitmap, 0, idset_bitmap_size(num_ssid, num_id)); We don't need bitmap_size() here, we need to replace memset() with bitmap_zero(). > } > return set; > } > @@ -41,7 +41,7 @@ void idset_free(struct idset *set) > > void idset_fill(struct idset *set) > { > - memset(set->bitmap, 0xff, bitmap_size(set->num_ssid, set->num_id)); > + memset(set->bitmap, 0xff, idset_bitmap_size(set->num_ssid, set->num_id)); Same, but bitmap_fill(). > } > > static inline void idset_add(struct idset *set, int ssid, int id) > -- > 2.34.1 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-07-02 20:46 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-02 18:28 [PATCH 0/4] Introduce bitmap_size() Christophe JAILLET 2022-07-02 18:28 ` [dm-devel] " Christophe JAILLET 2022-07-02 18:29 ` [PATCH 1/4] s390/cio: Rename bitmap_size() as idset_bitmap_size() Christophe JAILLET 2022-07-02 18:29 ` [dm-devel] " Christophe JAILLET 2022-07-02 18:54 ` Andy Shevchenko 2022-07-02 18:54 ` [dm-devel] " Andy Shevchenko 2022-07-02 19:24 ` Christophe JAILLET 2022-07-02 19:24 ` [dm-devel] " Christophe JAILLET 2022-07-02 19:24 ` Christophe JAILLET 2022-07-02 19:32 ` Andy Shevchenko 2022-07-02 19:32 ` [dm-devel] " Andy Shevchenko 2022-07-02 19:42 ` Christophe JAILLET 2022-07-02 19:42 ` [dm-devel] " Christophe JAILLET 2022-07-02 19:42 ` Christophe JAILLET 2022-07-02 19:42 ` Christophe JAILLET 2022-07-02 20:46 ` Yury Norov [this message] 2022-07-02 20:46 ` [dm-devel] " Yury Norov 2022-07-04 4:28 ` Vineeth Vijayan 2022-07-04 4:28 ` [dm-devel] " Vineeth Vijayan 2022-07-02 18:29 ` [PATCH 2/4] fs/ntfs3: Rename bitmap_size() as ntfs3_bitmap_size() Christophe JAILLET 2022-07-02 18:29 ` [dm-devel] " Christophe JAILLET 2022-07-02 18:58 ` Andy Shevchenko 2022-07-02 18:58 ` [dm-devel] " Andy Shevchenko 2022-07-02 19:37 ` Christophe JAILLET 2022-07-02 19:37 ` [dm-devel] " Christophe JAILLET 2022-07-02 19:37 ` Christophe JAILLET 2022-07-02 20:57 ` Yury Norov 2022-07-02 20:57 ` [dm-devel] " Yury Norov 2022-07-02 18:29 ` [PATCH 3/4] bitmap: Introduce bitmap_size() Christophe JAILLET 2022-07-02 18:29 ` [dm-devel] " Christophe JAILLET 2022-07-02 18:59 ` Andy Shevchenko 2022-07-02 18:59 ` [dm-devel] " Andy Shevchenko 2022-07-02 21:09 ` Yury Norov 2022-07-02 21:09 ` [dm-devel] " Yury Norov 2022-07-03 6:50 ` Christophe JAILLET 2022-07-03 6:50 ` [dm-devel] " Christophe JAILLET 2022-07-03 6:50 ` Christophe JAILLET 2022-07-03 15:20 ` Andy Shevchenko 2022-07-03 15:20 ` [dm-devel] " Andy Shevchenko 2022-07-03 19:13 ` Yury Norov 2022-07-03 19:13 ` [dm-devel] " Yury Norov 2022-07-03 20:41 ` Christophe JAILLET 2022-07-03 20:41 ` [dm-devel] " Christophe JAILLET 2022-07-02 18:29 ` [PATCH 4/4] bitmap: Use bitmap_size() Christophe JAILLET 2022-07-02 18:29 ` [dm-devel] " Christophe JAILLET 2022-07-02 20:44 ` [PATCH 0/4] Introduce bitmap_size() Yury Norov 2022-07-02 20:44 ` [dm-devel] " Yury Norov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YsCup7Kjzm9QWeZ5@yury-laptop \ --to=yury.norov@gmail.com \ --cc=agk@redhat.com \ --cc=agordeev@linux.ibm.com \ --cc=almaz.alexandrovich@paragon-software.com \ --cc=andriy.shevchenko@linux.intel.com \ --cc=borntraeger@linux.ibm.com \ --cc=christophe.jaillet@wanadoo.fr \ --cc=dm-devel@redhat.com \ --cc=gor@linux.ibm.com \ --cc=hca@linux.ibm.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux@rasmusvillemoes.dk \ --cc=ntfs3@lists.linux.dev \ --cc=oberpar@linux.ibm.com \ --cc=snitzer@kernel.org \ --cc=svens@linux.ibm.com \ --cc=vneethv@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.