All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH stable 5.19] kbuild: Add skip_encoding_btf_enum64 option to pahole
@ 2022-09-16 17:12 Martin Rodriguez Reboredo
  2022-09-16 17:14 ` kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Rodriguez Reboredo @ 2022-09-16 17:12 UTC (permalink / raw)
  To: stable
  Cc: bpf, Arnaldo Carvalho de Melo, Daniel Borkmann, Jiri Olsa,
	Andrii Nakryiko, Thorsten Leemhuis

New pahole (version 1.24) generates by default new BTF_KIND_ENUM64 BTF tag,
which is not supported by stable kernel.

As a result the kernel with CONFIG_DEBUG_INFO_BTF option will fail to
compile with following error:

  BTFIDS  vmlinux
FAILED: load BTF from vmlinux: Invalid argument

New pahole provides --skip_encoding_btf_enum64 option to skip BTF_KIND_ENUM64
generation and produce BTF supported by stable kernel.

Adding this option to scripts/pahole-flags.sh.

This change does not have equivalent commit in linus tree, because linus tree
has support for BTF_KIND_ENUM64 tag, so it does not need to be disabled.

Signed-off-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 scripts/pahole-flags.sh | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/pahole-flags.sh b/scripts/pahole-flags.sh
index 0d99ef17e4a5..d4f3d63cb434 100755
--- a/scripts/pahole-flags.sh
+++ b/scripts/pahole-flags.sh
@@ -20,4 +20,8 @@ if [ "${pahole_ver}" -ge "122" ]; then
 	extra_paholeopt="${extra_paholeopt} -j"
 fi
 
+if [ "${pahole_ver}" -ge "124" ]; then
+	extra_paholeopt="${extra_paholeopt} --skip_encoding_btf_enum64"
+fi
+
 echo ${extra_paholeopt}
-- 
2.37.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH stable 5.19] kbuild: Add skip_encoding_btf_enum64 option to pahole
  2022-09-16 17:12 [PATCH stable 5.19] kbuild: Add skip_encoding_btf_enum64 option to pahole Martin Rodriguez Reboredo
@ 2022-09-16 17:14 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-09-16 17:14 UTC (permalink / raw)
  To: Martin Rodriguez Reboredo; +Cc: stable, kbuild-all

Hi,

Thanks for your patch.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.'
Subject: [PATCH stable 5.19] kbuild: Add skip_encoding_btf_enum64 option to pahole
Link: https://lore.kernel.org/stable/20220916171234.841556-1-yakoyoku%40gmail.com

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-16 17:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-16 17:12 [PATCH stable 5.19] kbuild: Add skip_encoding_btf_enum64 option to pahole Martin Rodriguez Reboredo
2022-09-16 17:14 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.