From: Michal Simek <michal.simek@xilinx.com> To: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>, <michal.simek@xilinx.com> Cc: <rajan.vaja@xilinx.com>, <manish.narani@xilinx.com>, <zou_wei@huawei.com>, <amit.sunil.dhamne@xilinx.com>, <lakshmi.sai.krishna.potthuri@xilinx.com>, <wendy.liang@xilinx.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/6] firmware: xilinx: add macros of node ids for error event Date: Mon, 21 Jun 2021 13:11:45 +0200 [thread overview] Message-ID: <a4d6b733-0cfc-4624-e46f-6d8c89c252a2@xilinx.com> (raw) In-Reply-To: <1622217566-1856-3-git-send-email-abhyuday.godhasara@xilinx.com> On 5/28/21 5:59 PM, Abhyuday Godhasara wrote: > Add macros for the Node-Id of Error events. > > Move supported api callback ids from zynqmp-power to zynqmp-firmware. > > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com> > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com> > --- > drivers/soc/xilinx/zynqmp_power.c | 6 ------ > include/linux/firmware/xlnx-zynqmp.h | 13 +++++++++++++ > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c > index c556623..76478fe 100644 > --- a/drivers/soc/xilinx/zynqmp_power.c > +++ b/drivers/soc/xilinx/zynqmp_power.c > @@ -46,12 +46,6 @@ static const char *const suspend_modes[] = { > > static enum pm_suspend_mode suspend_mode = PM_SUSPEND_MODE_STD; > > -enum pm_api_cb_id { > - PM_INIT_SUSPEND_CB = 30, > - PM_ACKNOWLEDGE_CB, > - PM_NOTIFY_CB, > -}; > - > static void zynqmp_pm_get_callback_data(u32 *buf) > { > zynqmp_pm_invoke_fn(GET_CALLBACK_DATA, 0, 0, 0, 0, buf); > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 6557832..c715756 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -60,6 +60,19 @@ > #define XILINX_ZYNQMP_PM_FPGA_FULL 0x0U > #define XILINX_ZYNQMP_PM_FPGA_PARTIAL BIT(0) > > +/* > + * Node IDs for the Error Events. > + */ > +#define EVENT_ERROR_PMC_ERR1 (0x28100000U) > +#define EVENT_ERROR_PMC_ERR2 (0x28104000U) > +#define EVENT_ERROR_PSM_ERR1 (0x28108000U) > +#define EVENT_ERROR_PSM_ERR2 (0x2810C000U) > + > +enum pm_api_cb_id { > + PM_INIT_SUSPEND_CB = 30, No information about why PM_ACKNOWLEDGE_CB was removed. Doing it via separate patch would be the best. M > + PM_NOTIFY_CB = 32, > +}; > + > enum pm_api_id { > PM_GET_API_VERSION = 1, > PM_REGISTER_NOTIFIER = 5, >
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@xilinx.com> To: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com>, <michal.simek@xilinx.com> Cc: <rajan.vaja@xilinx.com>, <manish.narani@xilinx.com>, <zou_wei@huawei.com>, <amit.sunil.dhamne@xilinx.com>, <lakshmi.sai.krishna.potthuri@xilinx.com>, <wendy.liang@xilinx.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 2/6] firmware: xilinx: add macros of node ids for error event Date: Mon, 21 Jun 2021 13:11:45 +0200 [thread overview] Message-ID: <a4d6b733-0cfc-4624-e46f-6d8c89c252a2@xilinx.com> (raw) In-Reply-To: <1622217566-1856-3-git-send-email-abhyuday.godhasara@xilinx.com> On 5/28/21 5:59 PM, Abhyuday Godhasara wrote: > Add macros for the Node-Id of Error events. > > Move supported api callback ids from zynqmp-power to zynqmp-firmware. > > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com> > Signed-off-by: Abhyuday Godhasara <abhyuday.godhasara@xilinx.com> > --- > drivers/soc/xilinx/zynqmp_power.c | 6 ------ > include/linux/firmware/xlnx-zynqmp.h | 13 +++++++++++++ > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c > index c556623..76478fe 100644 > --- a/drivers/soc/xilinx/zynqmp_power.c > +++ b/drivers/soc/xilinx/zynqmp_power.c > @@ -46,12 +46,6 @@ static const char *const suspend_modes[] = { > > static enum pm_suspend_mode suspend_mode = PM_SUSPEND_MODE_STD; > > -enum pm_api_cb_id { > - PM_INIT_SUSPEND_CB = 30, > - PM_ACKNOWLEDGE_CB, > - PM_NOTIFY_CB, > -}; > - > static void zynqmp_pm_get_callback_data(u32 *buf) > { > zynqmp_pm_invoke_fn(GET_CALLBACK_DATA, 0, 0, 0, 0, buf); > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 6557832..c715756 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -60,6 +60,19 @@ > #define XILINX_ZYNQMP_PM_FPGA_FULL 0x0U > #define XILINX_ZYNQMP_PM_FPGA_PARTIAL BIT(0) > > +/* > + * Node IDs for the Error Events. > + */ > +#define EVENT_ERROR_PMC_ERR1 (0x28100000U) > +#define EVENT_ERROR_PMC_ERR2 (0x28104000U) > +#define EVENT_ERROR_PSM_ERR1 (0x28108000U) > +#define EVENT_ERROR_PSM_ERR2 (0x2810C000U) > + > +enum pm_api_cb_id { > + PM_INIT_SUSPEND_CB = 30, No information about why PM_ACKNOWLEDGE_CB was removed. Doing it via separate patch would be the best. M > + PM_NOTIFY_CB = 32, > +}; > + > enum pm_api_id { > PM_GET_API_VERSION = 1, > PM_REGISTER_NOTIFIER = 5, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2021-06-21 11:11 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1622217566-1856-1-git-send-email-abhyuday.godhasara@xilinx.com> [not found] ` <1622217566-1856-3-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 11:11 ` Michal Simek [this message] 2021-06-21 11:11 ` [PATCH 2/6] firmware: xilinx: add macros of node ids for error event Michal Simek 2021-06-25 13:35 ` Abhyuday Godhasara 2021-06-25 13:35 ` Abhyuday Godhasara [not found] ` <1622217566-1856-2-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 11:45 ` [PATCH 1/6] firmware: xilinx: add register notifier in zynqmp firmware Michal Simek 2021-06-21 11:45 ` Michal Simek 2021-06-25 13:37 ` Abhyuday Godhasara 2021-06-25 13:37 ` Abhyuday Godhasara [not found] ` <1622217566-1856-4-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 11:46 ` [PATCH 3/6] firmware: xilinx: export the feature check of " Michal Simek 2021-06-21 11:46 ` Michal Simek [not found] ` <1622217566-1856-6-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 11:48 ` [PATCH 5/6] firmware: xilinx: instantiate xilinx event manager driver Michal Simek 2021-06-21 11:48 ` Michal Simek 2021-06-21 11:58 ` Michal Simek 2021-06-21 11:58 ` Michal Simek [not found] ` <1622217566-1856-5-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 11:55 ` [PATCH 4/6] drivers: soc: xilinx: add xilinx event management driver Michal Simek 2021-06-21 11:55 ` Michal Simek 2021-06-25 13:48 ` Abhyuday Godhasara 2021-06-25 13:48 ` Abhyuday Godhasara [not found] ` <1622217566-1856-7-git-send-email-abhyuday.godhasara@xilinx.com> 2021-06-21 12:00 ` [PATCH 6/6] driver: soc: xilinx: register for power events in zynqmp power driver Michal Simek 2021-06-21 12:00 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a4d6b733-0cfc-4624-e46f-6d8c89c252a2@xilinx.com \ --to=michal.simek@xilinx.com \ --cc=abhyuday.godhasara@xilinx.com \ --cc=amit.sunil.dhamne@xilinx.com \ --cc=lakshmi.sai.krishna.potthuri@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manish.narani@xilinx.com \ --cc=rajan.vaja@xilinx.com \ --cc=wendy.liang@xilinx.com \ --cc=zou_wei@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.