From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Liang He <windhl@126.com>, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: soc: sifive: Add missing of_node_put() in sifive_l2_cache.c Date: Thu, 16 Jun 2022 07:12:21 +0200 [thread overview] Message-ID: <a5f6f76d-efc1-b421-7623-ad46996f5b94@wanadoo.fr> (raw) In-Reply-To: <20220615122315.3965435-1-windhl@126.com> Le 15/06/2022 à 14:23, Liang He a écrit : > In sifive_l2_init(), of_find_matching_node() will return a node pointer > with refcount incremented. We should use of_node_put() in each fail path > or when it is not used anymore. > > Signed-off-by: Liang He <windhl@126.com> > --- > drivers/soc/sifive/sifive_l2_cache.c | 29 ++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/sifive_l2_cache.c > index 59640a1d0b28..2b9c9522ef21 100644 > --- a/drivers/soc/sifive/sifive_l2_cache.c > +++ b/drivers/soc/sifive/sifive_l2_cache.c > @@ -198,29 +198,41 @@ static int __init sifive_l2_init(void) > struct resource res; > int i, rc, intr_num; > Hi, this empty line is not needed. > + int ret; > + > np = of_find_matching_node(NULL, sifive_l2_ids); > if (!np) > return -ENODEV; > > if (of_address_to_resource(np, 0, &res)) > - return -ENODEV; > + { this should be at the end of the previous line. > + ret = -ENODEV; > + goto out_put; > + } > > l2_base = ioremap(res.start, resource_size(&res)); > if (!l2_base) > - return -ENOMEM; > + { > Same here. + ret = -ENOMEM; > + goto out_put; > + } > > intr_num = of_property_count_u32_elems(np, "interrupts"); > - if (!intr_num) { > + if (!intr_num) { > pr_err("L2CACHE: no interrupts property\n"); > - return -ENODEV; > + ret = -ENODEV Missing ";" as reported by the bot. > + goto out_put; > } > > for (i = 0; i < intr_num; i++) { > g_irq[i] = irq_of_parse_and_map(np, i); > rc = request_irq(g_irq[i], l2_int_handler, 0, "l2_ecc", NULL); > + > if (rc) { > + Why a new empty line here? > pr_err("L2CACHE: Could not request IRQ %d\n", g_irq[i]); > - return rc; > + ret = rc; > + goto out_put; > } > } > > @@ -232,6 +244,11 @@ static int __init sifive_l2_init(void) > #ifdef CONFIG_DEBUG_FS > setup_sifive_debug(); > #endif > - return 0; > + ret = 0; > + > + No need for 2 empty lines here. There are also some trailing white spaces on some lines. "./scripts/checkpatch <name_of_the_patch>" catches some of these tiny issues. Using --strict catches even more of these issues. You should also always at least compile test your patches, even if they look obvious, CJ > +out_put: > + of_node_put(np); > + return ret; > } > device_initcall(sifive_l2_init);
WARNING: multiple messages have this Message-ID (diff)
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> To: Liang He <windhl@126.com>, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: soc: sifive: Add missing of_node_put() in sifive_l2_cache.c Date: Thu, 16 Jun 2022 07:12:21 +0200 [thread overview] Message-ID: <a5f6f76d-efc1-b421-7623-ad46996f5b94@wanadoo.fr> (raw) In-Reply-To: <20220615122315.3965435-1-windhl@126.com> Le 15/06/2022 à 14:23, Liang He a écrit : > In sifive_l2_init(), of_find_matching_node() will return a node pointer > with refcount incremented. We should use of_node_put() in each fail path > or when it is not used anymore. > > Signed-off-by: Liang He <windhl@126.com> > --- > drivers/soc/sifive/sifive_l2_cache.c | 29 ++++++++++++++++++++++------ > 1 file changed, 23 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/sifive_l2_cache.c > index 59640a1d0b28..2b9c9522ef21 100644 > --- a/drivers/soc/sifive/sifive_l2_cache.c > +++ b/drivers/soc/sifive/sifive_l2_cache.c > @@ -198,29 +198,41 @@ static int __init sifive_l2_init(void) > struct resource res; > int i, rc, intr_num; > Hi, this empty line is not needed. > + int ret; > + > np = of_find_matching_node(NULL, sifive_l2_ids); > if (!np) > return -ENODEV; > > if (of_address_to_resource(np, 0, &res)) > - return -ENODEV; > + { this should be at the end of the previous line. > + ret = -ENODEV; > + goto out_put; > + } > > l2_base = ioremap(res.start, resource_size(&res)); > if (!l2_base) > - return -ENOMEM; > + { > Same here. + ret = -ENOMEM; > + goto out_put; > + } > > intr_num = of_property_count_u32_elems(np, "interrupts"); > - if (!intr_num) { > + if (!intr_num) { > pr_err("L2CACHE: no interrupts property\n"); > - return -ENODEV; > + ret = -ENODEV Missing ";" as reported by the bot. > + goto out_put; > } > > for (i = 0; i < intr_num; i++) { > g_irq[i] = irq_of_parse_and_map(np, i); > rc = request_irq(g_irq[i], l2_int_handler, 0, "l2_ecc", NULL); > + > if (rc) { > + Why a new empty line here? > pr_err("L2CACHE: Could not request IRQ %d\n", g_irq[i]); > - return rc; > + ret = rc; > + goto out_put; > } > } > > @@ -232,6 +244,11 @@ static int __init sifive_l2_init(void) > #ifdef CONFIG_DEBUG_FS > setup_sifive_debug(); > #endif > - return 0; > + ret = 0; > + > + No need for 2 empty lines here. There are also some trailing white spaces on some lines. "./scripts/checkpatch <name_of_the_patch>" catches some of these tiny issues. Using --strict catches even more of these issues. You should also always at least compile test your patches, even if they look obvious, CJ > +out_put: > + of_node_put(np); > + return ret; > } > device_initcall(sifive_l2_init); _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-06-16 5:12 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-15 12:23 [PATCH] drivers: soc: sifive: Add missing of_node_put() in sifive_l2_cache.c Liang He 2022-06-15 12:23 ` Liang He 2022-06-15 21:58 ` kernel test robot 2022-06-15 21:58 ` kernel test robot 2022-06-16 4:54 ` Liang He 2022-06-16 4:54 ` Liang He 2022-06-16 4:54 ` Liang He 2022-06-16 5:12 ` Christophe JAILLET [this message] 2022-06-16 5:12 ` Christophe JAILLET 2022-06-16 5:33 ` Liang He 2022-06-16 5:33 ` Liang He 2022-06-16 18:45 ` Christophe JAILLET 2022-06-16 18:45 ` Christophe JAILLET
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a5f6f76d-efc1-b421-7623-ad46996f5b94@wanadoo.fr \ --to=christophe.jaillet@wanadoo.fr \ --cc=aou@eecs.berkeley.edu \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=windhl@126.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.