* [PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls
[not found] <CGME20180319143010epcas2p25aa33888e29cc229adf272369b6e684b@epcas2p2.samsung.com>
@ 2018-03-19 14:29 ` Sylwester Nawrocki
2018-03-19 14:36 ` Hans Verkuil
0 siblings, 1 reply; 2+ messages in thread
From: Sylwester Nawrocki @ 2018-03-19 14:29 UTC (permalink / raw)
To: linux-media
Cc: hverkuil, smitha.t, a.hajda, linux-samsung-soc, Sylwester Nawrocki
Valid range for those controls is specified in documentation as [0, 51],
so initialize the controls to such range rather than [INT_MIN, INT_MAX].
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
index 810dabe2f1b9..7382b41f4f6d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
@@ -856,56 +856,56 @@ static struct mfc_control controls[] = {
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
{
.id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP,
.type = V4L2_CTRL_TYPE_INTEGER,
- .minimum = INT_MIN,
- .maximum = INT_MAX,
+ .minimum = 0,
+ .maximum = 51,
.step = 1,
.default_value = 0,
},
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls
2018-03-19 14:29 ` [PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls Sylwester Nawrocki
@ 2018-03-19 14:36 ` Hans Verkuil
0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2018-03-19 14:36 UTC (permalink / raw)
To: Sylwester Nawrocki, linux-media; +Cc: smitha.t, a.hajda, linux-samsung-soc
On 03/19/2018 03:29 PM, Sylwester Nawrocki wrote:
> Valid range for those controls is specified in documentation as [0, 51],
> so initialize the controls to such range rather than [INT_MIN, INT_MAX].
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Huh, I missed this when I reviewed this earlier. Thanks for catching this!
Regards,
Hans
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 28 ++++++++++++++--------------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index 810dabe2f1b9..7382b41f4f6d 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -856,56 +856,56 @@ static struct mfc_control controls[] = {
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L0_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L1_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L2_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L3_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L4_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L5_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
> {
> .id = V4L2_CID_MPEG_VIDEO_HEVC_HIER_CODING_L6_QP,
> .type = V4L2_CTRL_TYPE_INTEGER,
> - .minimum = INT_MIN,
> - .maximum = INT_MAX,
> + .minimum = 0,
> + .maximum = 51,
> .step = 1,
> .default_value = 0,
> },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-19 14:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180319143010epcas2p25aa33888e29cc229adf272369b6e684b@epcas2p2.samsung.com>
2018-03-19 14:29 ` [PATCH] s5p-mfc: Amend initial min, max values of HEVC hierarchical coding QP controls Sylwester Nawrocki
2018-03-19 14:36 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.