From: Florian Fainelli <f.fainelli@gmail.com>
To: Prasad Sodagudi <psodagud@codeaurora.org>,
rostedt@goodmis.org, mingo@redhat.com, keescook@chromium.org,
catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org,
will@kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, anton@enomsg.org, arnd@arndb.de,
ccross@android.com, jbaron@akamai.com, jim.cromie@gmail.com,
joe@perches.com, joel@joelfernandes.org
Subject: Re: [PATCH 2] Register read and writes tracing
Date: Thu, 5 Nov 2020 19:58:31 -0800 [thread overview]
Message-ID: <a9de1928-d709-896f-ffa6-febc5d6d34c6@gmail.com> (raw)
In-Reply-To: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org>
On 11/5/2020 6:56 PM, Prasad Sodagudi wrote:
> This patch series adds register read/write event tracing
> support. Qualcomm team tried upstreaming the register
> trace buffer solution - [1] with pstore and dynamic debug
> feature but that patch series didn't merge. I have followed
> Steve suggestion from -[2] and used tracepoint_enabled() API.
>
> [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/
> [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@oasis.local.home/
>
> Qualcomm teams uses these logs for debugging various issues
> in the product life cycle and hopping that this logging
> would help other silicon vendors as this is generic approach.
There is not anything arm64 specific here other than where you have
hooked into the low-level I/O accessors, you could consider adding this
as a generic facility to other architectures as well.
Also, have you looked at making mmiotrace less x86 specific and more
generic?
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Prasad Sodagudi <psodagud@codeaurora.org>,
rostedt@goodmis.org, mingo@redhat.com, keescook@chromium.org,
catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org,
will@kernel.org
Cc: arnd@arndb.de, jim.cromie@gmail.com,
linux-arm-msm@vger.kernel.org, anton@enomsg.org,
linux-kernel@vger.kernel.org, joel@joelfernandes.org,
jbaron@akamai.com, ccross@android.com,
gregkh@linuxfoundation.org, joe@perches.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2] Register read and writes tracing
Date: Thu, 5 Nov 2020 19:58:31 -0800 [thread overview]
Message-ID: <a9de1928-d709-896f-ffa6-febc5d6d34c6@gmail.com> (raw)
In-Reply-To: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org>
On 11/5/2020 6:56 PM, Prasad Sodagudi wrote:
> This patch series adds register read/write event tracing
> support. Qualcomm team tried upstreaming the register
> trace buffer solution - [1] with pstore and dynamic debug
> feature but that patch series didn't merge. I have followed
> Steve suggestion from -[2] and used tracepoint_enabled() API.
>
> [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/
> [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@oasis.local.home/
>
> Qualcomm teams uses these logs for debugging various issues
> in the product life cycle and hopping that this logging
> would help other silicon vendors as this is generic approach.
There is not anything arm64 specific here other than where you have
hooked into the low-level I/O accessors, you could consider adding this
as a generic facility to other architectures as well.
Also, have you looked at making mmiotrace less x86 specific and more
generic?
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-06 3:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 2:56 [PATCH 2] Register read and writes tracing Prasad Sodagudi
2020-11-06 2:56 ` Prasad Sodagudi
2020-11-06 2:56 ` [PATCH v2] tracing: Add register read and write tracing support Prasad Sodagudi
2020-11-06 2:56 ` Prasad Sodagudi
2020-11-06 6:49 ` Greg KH
2020-11-06 6:49 ` Greg KH
2020-11-06 9:09 ` Will Deacon
2020-11-06 9:09 ` Will Deacon
2020-11-06 3:58 ` Florian Fainelli [this message]
2020-11-06 3:58 ` [PATCH 2] Register read and writes tracing Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9de1928-d709-896f-ffa6-febc5d6d34c6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=ccross@android.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jim.cromie@gmail.com \
--cc=joe@perches.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=psodagud@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.