All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Valentin Schneider <valentin.schneider@arm.com>
Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
	tglx@linutronix.de
Subject: Re: [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq
Date: Fri, 18 Dec 2020 20:53:53 +0000	[thread overview]
Message-ID: <aad56a6f5af539b1dc39d3e75ef83bc3@kernel.org> (raw)
In-Reply-To: <jhjo8iqsvgk.mognet@arm.com>

On 2020-12-18 20:36, Valentin Schneider wrote:
> On 18/12/20 18:40, irqchip-bot for Marc Zyngier wrote:
>> The following commit has been merged into the irq/irqchip-next branch 
>> of irqchip:
>> 
>> Commit-ID:     d7f39c40ebb6986e7371510d1c20a4efee4a7f0d
>> Gitweb:        
>> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/d7f39c40ebb6986e7371510d1c20a4efee4a7f0d
>> Author:        Marc Zyngier <maz@kernel.org>
>> AuthorDate:    Fri, 18 Dec 2020 18:03:46
>> Committer:     Marc Zyngier <maz@kernel.org>
>> CommitterDate: Fri, 18 Dec 2020 18:34:17
>> 
>> irqchip/bcm2836: Fix IPI acknowledgement after conversion to 
>> handle_percpu_devid_irq
>> 
>> It appears that despite its name, the bcm2836_arm_irqchip_ipi_eoi()
>> callback is an acknowledgement, and not an EOI. This means that
>> we lose IPIs that are made pending between the handling of the
>> IPI and the write to LOCAL_MAILBOX0_CLR0. With the right timing,
>> things fail nicely.
>> 
>> This used to work with handle_percpu_devid_fasteoi_ipi(), which
>> started by eoi-ing the interrupt. With the standard fasteoi flow,
>> this doesn't work anymore.
>> 
>> So let's use this callback for what it is, an ack. Your favourite
>> RPi-2/3 is back up and running.
>> 
> 
> Thanks for cleaning up my mess!

Shared responsibilities... ;-)

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2020-12-18 20:54 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09  9:41 [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Valentin Schneider
2020-11-09  9:41 ` Valentin Schneider
2020-11-09  9:41 ` [PATCH 1/5] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() Valentin Schneider
2020-11-09  9:41   ` Valentin Schneider
2020-12-11 14:58   ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09  9:41 ` [PATCH 2/5] irqchip/armada-370-xp: Make IPIs " Valentin Schneider
2020-11-09  9:41   ` Valentin Schneider
2020-12-11 14:58   ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09  9:41 ` [PATCH 3/5] irqchip/bcm2836: " Valentin Schneider
2020-11-09  9:41   ` Valentin Schneider
2020-12-11 14:58   ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-15  0:21   ` [PATCH 3/5] " Guenter Roeck
2020-12-15  0:21     ` Guenter Roeck
2020-12-15 10:19     ` Marc Zyngier
2020-12-15 10:19       ` Marc Zyngier
2020-12-15 11:14       ` Valentin Schneider
2020-12-15 11:14         ` Valentin Schneider
2020-12-15 12:14         ` Marc Zyngier
2020-12-15 12:14           ` Marc Zyngier
2020-12-15 15:21       ` Guenter Roeck
2020-12-15 15:21         ` Guenter Roeck
2020-12-15 15:26         ` Marc Zyngier
2020-12-15 15:26           ` Marc Zyngier
2020-12-15 15:39           ` Guenter Roeck
2020-12-15 15:39             ` Guenter Roeck
2020-12-15 15:46             ` Marc Zyngier
2020-12-15 15:46               ` Marc Zyngier
2020-12-15 16:23               ` Guenter Roeck
2020-12-15 16:23                 ` Guenter Roeck
2020-12-18  5:18               ` Guenter Roeck
2020-12-18  5:18                 ` Guenter Roeck
2020-12-18 18:40                 ` Marc Zyngier
2020-12-18 18:40                   ` Marc Zyngier
2020-12-18 18:47                   ` Guenter Roeck
2020-12-18 18:47                     ` Guenter Roeck
2020-12-18 18:40             ` [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq irqchip-bot for Marc Zyngier
2020-12-18 20:36               ` Valentin Schneider
2020-12-18 20:53                 ` Marc Zyngier [this message]
2020-11-09  9:41 ` [PATCH 4/5] irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Valentin Schneider
2020-11-09  9:41   ` Valentin Schneider
2020-12-11 14:58   ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-11-09  9:41 ` [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Valentin Schneider
2020-11-09  9:41   ` Valentin Schneider
2020-12-11 14:58   ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider
2020-12-11 15:01 ` [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Marc Zyngier
2020-12-11 15:01   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aad56a6f5af539b1dc39d3e75ef83bc3@kernel.org \
    --to=maz@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=tglx@linutronix.de \
    --cc=valentin.schneider@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.