From: Valentin Schneider <valentin.schneider@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Thomas Gleixner <tglx@linutronix.de>, Marc Zyngier <maz@kernel.org>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com> Subject: [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Date: Mon, 9 Nov 2020 09:41:21 +0000 [thread overview] Message-ID: <20201109094121.29975-6-valentin.schneider@arm.com> (raw) In-Reply-To: <20201109094121.29975-1-valentin.schneider@arm.com> handle_percpu_devid_fasteoi_ipi() has no more users, and handle_percpu_devid_irq() can do all that it was supposed to do. Get rid of it. This reverts commit c5e5ec033c4ab25c53f1fd217849e75deb0bf7bf. Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> --- include/linux/irq.h | 1 - kernel/irq/chip.c | 27 --------------------------- 2 files changed, 28 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index c54365309e97..ca26bec51cec 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -647,7 +647,6 @@ static inline int irq_set_parent(int irq, int parent_irq) */ extern void handle_level_irq(struct irq_desc *desc); extern void handle_fasteoi_irq(struct irq_desc *desc); -extern void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc); extern void handle_edge_irq(struct irq_desc *desc); extern void handle_edge_eoi_irq(struct irq_desc *desc); extern void handle_simple_irq(struct irq_desc *desc); diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index b9b9618e1aca..0ae308efa604 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -944,33 +944,6 @@ void handle_percpu_devid_irq(struct irq_desc *desc) chip->irq_eoi(&desc->irq_data); } -/** - * handle_percpu_devid_fasteoi_ipi - Per CPU local IPI handler with per cpu - * dev ids - * @desc: the interrupt description structure for this irq - * - * The biggest difference with the IRQ version is that the interrupt is - * EOIed early, as the IPI could result in a context switch, and we need to - * make sure the IPI can fire again. We also assume that the arch code has - * registered an action. If not, we are positively doomed. - */ -void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc) -{ - struct irq_chip *chip = irq_desc_get_chip(desc); - struct irqaction *action = desc->action; - unsigned int irq = irq_desc_get_irq(desc); - irqreturn_t res; - - __kstat_incr_irqs_this_cpu(desc); - - if (chip->irq_eoi) - chip->irq_eoi(&desc->irq_data); - - trace_irq_handler_entry(irq, action); - res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id)); - trace_irq_handler_exit(irq, action, res); -} - /** * handle_percpu_devid_fasteoi_nmi - Per CPU local NMI handler with per cpu * dev ids -- 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com> To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Andrew Lunn <andrew@lunn.ch>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Jason Cooper <jason@lakedaemon.net>, Scott Branden <sbranden@broadcom.com>, Marc Zyngier <maz@kernel.org>, Gregory Clement <gregory.clement@bootlin.com>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Thomas Gleixner <tglx@linutronix.de>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Subject: [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Date: Mon, 9 Nov 2020 09:41:21 +0000 [thread overview] Message-ID: <20201109094121.29975-6-valentin.schneider@arm.com> (raw) In-Reply-To: <20201109094121.29975-1-valentin.schneider@arm.com> handle_percpu_devid_fasteoi_ipi() has no more users, and handle_percpu_devid_irq() can do all that it was supposed to do. Get rid of it. This reverts commit c5e5ec033c4ab25c53f1fd217849e75deb0bf7bf. Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> --- include/linux/irq.h | 1 - kernel/irq/chip.c | 27 --------------------------- 2 files changed, 28 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index c54365309e97..ca26bec51cec 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -647,7 +647,6 @@ static inline int irq_set_parent(int irq, int parent_irq) */ extern void handle_level_irq(struct irq_desc *desc); extern void handle_fasteoi_irq(struct irq_desc *desc); -extern void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc); extern void handle_edge_irq(struct irq_desc *desc); extern void handle_edge_eoi_irq(struct irq_desc *desc); extern void handle_simple_irq(struct irq_desc *desc); diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index b9b9618e1aca..0ae308efa604 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -944,33 +944,6 @@ void handle_percpu_devid_irq(struct irq_desc *desc) chip->irq_eoi(&desc->irq_data); } -/** - * handle_percpu_devid_fasteoi_ipi - Per CPU local IPI handler with per cpu - * dev ids - * @desc: the interrupt description structure for this irq - * - * The biggest difference with the IRQ version is that the interrupt is - * EOIed early, as the IPI could result in a context switch, and we need to - * make sure the IPI can fire again. We also assume that the arch code has - * registered an action. If not, we are positively doomed. - */ -void handle_percpu_devid_fasteoi_ipi(struct irq_desc *desc) -{ - struct irq_chip *chip = irq_desc_get_chip(desc); - struct irqaction *action = desc->action; - unsigned int irq = irq_desc_get_irq(desc); - irqreturn_t res; - - __kstat_incr_irqs_this_cpu(desc); - - if (chip->irq_eoi) - chip->irq_eoi(&desc->irq_data); - - trace_irq_handler_entry(irq, action); - res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id)); - trace_irq_handler_exit(irq, action, res); -} - /** * handle_percpu_devid_fasteoi_nmi - Per CPU local NMI handler with per cpu * dev ids -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-09 9:43 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-09 9:41 [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider 2020-11-09 9:41 ` [PATCH 1/5] irqchip/gic, gic-v3: Make SGIs use handle_percpu_devid_irq() Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider 2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider 2020-11-09 9:41 ` [PATCH 2/5] irqchip/armada-370-xp: Make IPIs " Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider 2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider 2020-11-09 9:41 ` [PATCH 3/5] irqchip/bcm2836: " Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider 2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider 2020-12-15 0:21 ` [PATCH 3/5] " Guenter Roeck 2020-12-15 0:21 ` Guenter Roeck 2020-12-15 10:19 ` Marc Zyngier 2020-12-15 10:19 ` Marc Zyngier 2020-12-15 11:14 ` Valentin Schneider 2020-12-15 11:14 ` Valentin Schneider 2020-12-15 12:14 ` Marc Zyngier 2020-12-15 12:14 ` Marc Zyngier 2020-12-15 15:21 ` Guenter Roeck 2020-12-15 15:21 ` Guenter Roeck 2020-12-15 15:26 ` Marc Zyngier 2020-12-15 15:26 ` Marc Zyngier 2020-12-15 15:39 ` Guenter Roeck 2020-12-15 15:39 ` Guenter Roeck 2020-12-15 15:46 ` Marc Zyngier 2020-12-15 15:46 ` Marc Zyngier 2020-12-15 16:23 ` Guenter Roeck 2020-12-15 16:23 ` Guenter Roeck 2020-12-18 5:18 ` Guenter Roeck 2020-12-18 5:18 ` Guenter Roeck 2020-12-18 18:40 ` Marc Zyngier 2020-12-18 18:40 ` Marc Zyngier 2020-12-18 18:47 ` Guenter Roeck 2020-12-18 18:47 ` Guenter Roeck 2020-12-18 18:40 ` [irqchip: irq/irqchip-next] irqchip/bcm2836: Fix IPI acknowledgement after conversion to handle_percpu_devid_irq irqchip-bot for Marc Zyngier 2020-12-18 20:36 ` Valentin Schneider 2020-12-18 20:53 ` Marc Zyngier 2020-11-09 9:41 ` [PATCH 4/5] irqchip/hip04: Make IPIs use handle_percpu_devid_irq() Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider 2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider 2020-11-09 9:41 ` Valentin Schneider [this message] 2020-11-09 9:41 ` [PATCH 5/5] Revert "genirq: Add fasteoi IPI flow" Valentin Schneider 2020-12-11 14:58 ` [irqchip: irq/irqchip-next] " irqchip-bot for Valentin Schneider 2020-12-11 15:01 ` [PATCH 0/5] genirq: Get rid of handle_percpu_devid_fasteoi_ipi() Marc Zyngier 2020-12-11 15:01 ` Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201109094121.29975-6-valentin.schneider@arm.com \ --to=valentin.schneider@arm.com \ --cc=Lorenzo.Pieralisi@arm.com \ --cc=andrew@lunn.ch \ --cc=f.fainelli@gmail.com \ --cc=gregory.clement@bootlin.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=maz@kernel.org \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.