From: Roger Quadros <rogerq@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org>, miquel.raynal@bootlin.com, robh+dt@kernel.org Cc: richard@nod.at, vigneshr@ti.com, kishon@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Date: Fri, 25 Mar 2022 14:05:45 +0200 [thread overview] Message-ID: <abcbe390-45a8-6183-56a8-f9f751e84f49@kernel.org> (raw) In-Reply-To: <a222efb1-4f95-d65d-919b-ed55c5448c9a@kernel.org> On 24/03/2022 20:26, Krzysztof Kozlowski wrote: > On 23/03/2022 12:18, Roger Quadros wrote: >> TI's AM64 SoC has the Error Locator Module. Add compatible and >> related properties to support ELM on AM64 SoC. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- >> .../devicetree/bindings/mtd/ti,elm.yaml | 27 ++++++++++++++++++- >> 1 file changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> index 24ed0fb84204..bc01d35ce605 100644 >> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> @@ -17,7 +17,9 @@ description: >> properties: >> compatible: >> items: >> - - const: ti,am3352-elm >> + - enum: >> + - ti,am3352-elm >> + - ti,am64-elm >> >> reg: >> maxItems: 1 >> @@ -25,6 +27,17 @@ properties: >> interrupts: >> maxItems: 1 >> >> + clocks: >> + maxItems: 1 >> + description: Functional clock. >> + >> + clock-names: >> + items: >> + - const: fck >> + >> + power-domains: >> + maxItems: 1 >> + >> ti,hwmods: >> description: >> Name of the HWMOD associated with ELM. This is for legacy >> @@ -37,6 +50,18 @@ required: >> - reg >> - interrupts >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: ti,am64-elm >> + then: >> + required: >> + - clocks >> + - clock-names >> + - power-domains > > Are these new properties also valid for am3352? No they are not required for am3352-elm. Only required for K3 based platforms like AM64. > >> + >> additionalProperties: false >> >> examples: > > > Best regards, > Krzysztof cheers, -roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@kernel.org> To: Krzysztof Kozlowski <krzk@kernel.org>, miquel.raynal@bootlin.com, robh+dt@kernel.org Cc: richard@nod.at, vigneshr@ti.com, kishon@ti.com, nm@ti.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Date: Fri, 25 Mar 2022 14:05:45 +0200 [thread overview] Message-ID: <abcbe390-45a8-6183-56a8-f9f751e84f49@kernel.org> (raw) In-Reply-To: <a222efb1-4f95-d65d-919b-ed55c5448c9a@kernel.org> On 24/03/2022 20:26, Krzysztof Kozlowski wrote: > On 23/03/2022 12:18, Roger Quadros wrote: >> TI's AM64 SoC has the Error Locator Module. Add compatible and >> related properties to support ELM on AM64 SoC. >> >> Signed-off-by: Roger Quadros <rogerq@kernel.org> >> --- >> .../devicetree/bindings/mtd/ti,elm.yaml | 27 ++++++++++++++++++- >> 1 file changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mtd/ti,elm.yaml b/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> index 24ed0fb84204..bc01d35ce605 100644 >> --- a/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> +++ b/Documentation/devicetree/bindings/mtd/ti,elm.yaml >> @@ -17,7 +17,9 @@ description: >> properties: >> compatible: >> items: >> - - const: ti,am3352-elm >> + - enum: >> + - ti,am3352-elm >> + - ti,am64-elm >> >> reg: >> maxItems: 1 >> @@ -25,6 +27,17 @@ properties: >> interrupts: >> maxItems: 1 >> >> + clocks: >> + maxItems: 1 >> + description: Functional clock. >> + >> + clock-names: >> + items: >> + - const: fck >> + >> + power-domains: >> + maxItems: 1 >> + >> ti,hwmods: >> description: >> Name of the HWMOD associated with ELM. This is for legacy >> @@ -37,6 +50,18 @@ required: >> - reg >> - interrupts >> >> +allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: ti,am64-elm >> + then: >> + required: >> + - clocks >> + - clock-names >> + - power-domains > > Are these new properties also valid for am3352? No they are not required for am3352-elm. Only required for K3 based platforms like AM64. > >> + >> additionalProperties: false >> >> examples: > > > Best regards, > Krzysztof cheers, -roger ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-03-25 12:05 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-23 11:18 [PATCH 0/3] mtd: rawnand: omap_elm: convert DT binding to yaml Roger Quadros 2022-03-23 11:18 ` Roger Quadros 2022-03-23 11:18 ` [PATCH 1/3] dt-bindings: mtd: ti,elm: Convert " Roger Quadros 2022-03-23 11:18 ` Roger Quadros 2022-03-24 18:24 ` Krzysztof Kozlowski 2022-03-24 18:24 ` Krzysztof Kozlowski 2022-03-25 12:03 ` Roger Quadros 2022-03-25 12:03 ` Roger Quadros 2022-03-23 11:18 ` [PATCH 2/3] dt-bindings: mtd: ti,elm: Add support for AM64 ELM Roger Quadros 2022-03-23 11:18 ` Roger Quadros 2022-03-24 18:26 ` Krzysztof Kozlowski 2022-03-24 18:26 ` Krzysztof Kozlowski 2022-03-25 12:05 ` Roger Quadros [this message] 2022-03-25 12:05 ` Roger Quadros 2022-03-25 12:08 ` Krzysztof Kozlowski 2022-03-25 12:08 ` Krzysztof Kozlowski 2022-03-25 12:13 ` Roger Quadros 2022-03-25 12:13 ` Roger Quadros 2022-03-25 12:27 ` Krzysztof Kozlowski 2022-03-25 12:27 ` Krzysztof Kozlowski 2022-03-23 11:18 ` [PATCH 3/3] mtd: rawnand: omap_elm: Add compatible " Roger Quadros 2022-03-23 11:18 ` Roger Quadros
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=abcbe390-45a8-6183-56a8-f9f751e84f49@kernel.org \ --to=rogerq@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kishon@ti.com \ --cc=krzk@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=nm@ti.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.