All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC] mx6cuboxi: Enable OF_CONTROL and DM in SPL
@ 2020-01-29 13:58 Walter Lozano
  2020-02-04 13:41 ` Baruch Siach
  0 siblings, 1 reply; 3+ messages in thread
From: Walter Lozano @ 2020-01-29 13:58 UTC (permalink / raw)
  To: u-boot

Make an additional step to add full DM support to mx6cuboxi, including its support for SPL

With this new configuration SPL image is 50 KB, higher than the
38 KB from the previous version, but it still under the 68 KB limit.

Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
---
 arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi | 4 ++++
 configs/mx6cuboxi_defconfig                                 | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
index d302b2e275..b1364a0bbf 100644
--- a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
+++ b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
@@ -34,3 +34,7 @@
 &usdhc1 {
 	status = "disabled";
 };
+
+&usdhc2 {
+	u-boot,dm-pre-reloc;
+};
diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig
index 23ce485f43..ae8d920260 100644
--- a/configs/mx6cuboxi_defconfig
+++ b/configs/mx6cuboxi_defconfig
@@ -24,6 +24,7 @@ CONFIG_USE_PREBOOT=y
 CONFIG_PREBOOT="if hdmidet; then usb start; setenv stdin  serial,usbkbd; setenv stdout serial,vga; setenv stderr serial,vga; else setenv stdin  serial; setenv stdout serial; setenv stderr serial; fi;"
 CONFIG_BOUNCE_BUFFER=y
 CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_SPL_SEPARATE_BSS=y
 CONFIG_SPL_FS_EXT4=y
 CONFIG_SPL_I2C_SUPPORT=y
 CONFIG_SPL_WATCHDOG_SUPPORT=y
@@ -36,6 +37,7 @@ CONFIG_CMD_CACHE=y
 CONFIG_CMD_EXT4_WRITE=y
 # CONFIG_SPL_PARTITION_UUIDS is not set
 CONFIG_OF_CONTROL=y
+CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="imx6dl-hummingboard2-emmc-som-v15"
 CONFIG_OF_LIST="imx6dl-hummingboard2-emmc-som-v15 imx6q-hummingboard2-emmc-som-v15"
 CONFIG_MULTI_DTB_FIT=y
@@ -44,6 +46,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
 CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
+CONFIG_SPL_DM=y
 CONFIG_DWC_AHSATA=y
 CONFIG_DM_GPIO=y
 CONFIG_DM_MMC=y
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [RFC] mx6cuboxi: Enable OF_CONTROL and DM in SPL
  2020-01-29 13:58 [RFC] mx6cuboxi: Enable OF_CONTROL and DM in SPL Walter Lozano
@ 2020-02-04 13:41 ` Baruch Siach
  2020-02-05 13:04   ` Walter Lozano
  0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2020-02-04 13:41 UTC (permalink / raw)
  To: u-boot

Hi Walter,

Thanks for the patch.

One comment below.

On Wed, Jan 29, 2020 at 10:58:07AM -0300, Walter Lozano wrote:
> Make an additional step to add full DM support to mx6cuboxi, including its support for SPL
> 
> With this new configuration SPL image is 50 KB, higher than the
> 38 KB from the previous version, but it still under the 68 KB limit.
> 
> Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
> ---
>  arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi | 4 ++++
>  configs/mx6cuboxi_defconfig                                 | 3 +++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
> index d302b2e275..b1364a0bbf 100644
> --- a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
> +++ b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
> @@ -34,3 +34,7 @@
>  &usdhc1 {
>  	status = "disabled";
>  };
> +
> +&usdhc2 {
> +	u-boot,dm-pre-reloc;
> +};

Have you tested boot from eMMC?

You would most likely need to add &usdhc3 to SPL DT for that.

baruch

> diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig
> index 23ce485f43..ae8d920260 100644
> --- a/configs/mx6cuboxi_defconfig
> +++ b/configs/mx6cuboxi_defconfig
> @@ -24,6 +24,7 @@ CONFIG_USE_PREBOOT=y
>  CONFIG_PREBOOT="if hdmidet; then usb start; setenv stdin  serial,usbkbd; setenv stdout serial,vga; setenv stderr serial,vga; else setenv stdin  serial; setenv stdout serial; setenv stderr serial; fi;"
>  CONFIG_BOUNCE_BUFFER=y
>  CONFIG_BOARD_EARLY_INIT_F=y
> +CONFIG_SPL_SEPARATE_BSS=y
>  CONFIG_SPL_FS_EXT4=y
>  CONFIG_SPL_I2C_SUPPORT=y
>  CONFIG_SPL_WATCHDOG_SUPPORT=y
> @@ -36,6 +37,7 @@ CONFIG_CMD_CACHE=y
>  CONFIG_CMD_EXT4_WRITE=y
>  # CONFIG_SPL_PARTITION_UUIDS is not set
>  CONFIG_OF_CONTROL=y
> +CONFIG_SPL_OF_CONTROL=y
>  CONFIG_DEFAULT_DEVICE_TREE="imx6dl-hummingboard2-emmc-som-v15"
>  CONFIG_OF_LIST="imx6dl-hummingboard2-emmc-som-v15 imx6q-hummingboard2-emmc-som-v15"
>  CONFIG_MULTI_DTB_FIT=y
> @@ -44,6 +46,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>  CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>  CONFIG_NET_RANDOM_ETHADDR=y
>  CONFIG_DM=y
> +CONFIG_SPL_DM=y
>  CONFIG_DWC_AHSATA=y
>  CONFIG_DM_GPIO=y
>  CONFIG_DM_MMC=y

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [RFC] mx6cuboxi: Enable OF_CONTROL and DM in SPL
  2020-02-04 13:41 ` Baruch Siach
@ 2020-02-05 13:04   ` Walter Lozano
  0 siblings, 0 replies; 3+ messages in thread
From: Walter Lozano @ 2020-02-05 13:04 UTC (permalink / raw)
  To: u-boot

Hi Baruch,

Thanks for your comments. My replay below.

On 4/2/20 10:41, Baruch Siach wrote:
> Hi Walter,
>
> Thanks for the patch.
>
> One comment below.
>
> On Wed, Jan 29, 2020 at 10:58:07AM -0300, Walter Lozano wrote:
>> Make an additional step to add full DM support to mx6cuboxi, including its support for SPL
>>
>> With this new configuration SPL image is 50 KB, higher than the
>> 38 KB from the previous version, but it still under the 68 KB limit.
>>
>> Signed-off-by: Walter Lozano <walter.lozano@collabora.com>
>> ---
>>   arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi | 4 ++++
>>   configs/mx6cuboxi_defconfig                                 | 3 +++
>>   2 files changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
>> index d302b2e275..b1364a0bbf 100644
>> --- a/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
>> +++ b/arch/arm/dts/imx6qdl-hummingboard2-emmc-som-v15-u-boot.dtsi
>> @@ -34,3 +34,7 @@
>>   &usdhc1 {
>>   	status = "disabled";
>>   };
>> +
>> +&usdhc2 {
>> +	u-boot,dm-pre-reloc;
>> +};
> Have you tested boot from eMMC?
>
> You would most likely need to add &usdhc3 to SPL DT for that.
Good point. I haven't tested booting from eMMC as I can only boot from 
SD because of eFuse settings. However after re thinking it should be 
still possible to test it by keeping SPL on SD and placing U-Boot on eMMC.

Regards,

Walter
>
> baruch
>
>> diff --git a/configs/mx6cuboxi_defconfig b/configs/mx6cuboxi_defconfig
>> index 23ce485f43..ae8d920260 100644
>> --- a/configs/mx6cuboxi_defconfig
>> +++ b/configs/mx6cuboxi_defconfig
>> @@ -24,6 +24,7 @@ CONFIG_USE_PREBOOT=y
>>   CONFIG_PREBOOT="if hdmidet; then usb start; setenv stdin  serial,usbkbd; setenv stdout serial,vga; setenv stderr serial,vga; else setenv stdin  serial; setenv stdout serial; setenv stderr serial; fi;"
>>   CONFIG_BOUNCE_BUFFER=y
>>   CONFIG_BOARD_EARLY_INIT_F=y
>> +CONFIG_SPL_SEPARATE_BSS=y
>>   CONFIG_SPL_FS_EXT4=y
>>   CONFIG_SPL_I2C_SUPPORT=y
>>   CONFIG_SPL_WATCHDOG_SUPPORT=y
>> @@ -36,6 +37,7 @@ CONFIG_CMD_CACHE=y
>>   CONFIG_CMD_EXT4_WRITE=y
>>   # CONFIG_SPL_PARTITION_UUIDS is not set
>>   CONFIG_OF_CONTROL=y
>> +CONFIG_SPL_OF_CONTROL=y
>>   CONFIG_DEFAULT_DEVICE_TREE="imx6dl-hummingboard2-emmc-som-v15"
>>   CONFIG_OF_LIST="imx6dl-hummingboard2-emmc-som-v15 imx6q-hummingboard2-emmc-som-v15"
>>   CONFIG_MULTI_DTB_FIT=y
>> @@ -44,6 +46,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>   CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG=y
>>   CONFIG_NET_RANDOM_ETHADDR=y
>>   CONFIG_DM=y
>> +CONFIG_SPL_DM=y
>>   CONFIG_DWC_AHSATA=y
>>   CONFIG_DM_GPIO=y
>>   CONFIG_DM_MMC=y

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-05 13:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-29 13:58 [RFC] mx6cuboxi: Enable OF_CONTROL and DM in SPL Walter Lozano
2020-02-04 13:41 ` Baruch Siach
2020-02-05 13:04   ` Walter Lozano

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.