From: Vignesh Raghavendra <vigneshr@ti.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Strashko, Grygorii" <grygorii.strashko@ti.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
Vadym Kochan <vkochan@marvell.com>,
Taras Chornyi <tchornyi@marvell.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Ivan Vecera <ivecera@redhat.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA
Date: Tue, 16 Feb 2021 16:52:50 +0530 [thread overview]
Message-ID: <adcbe8ce-60b3-551a-941b-f8de52a134d7@ti.com> (raw)
In-Reply-To: <20210212144053.2pumwc6mlt4l2gcj@skbuf>
Hi,
On 2/12/21 8:10 PM, Vladimir Oltean wrote:
> On Fri, Feb 12, 2021 at 08:01:33PM +0530, Vignesh Raghavendra wrote:
>> Hi Vladimir,
>>
>> On 2/12/21 7:47 PM, Grygorii Strashko wrote:
>>>
>>>
>>> On 12/02/2021 03:05, Vladimir Oltean wrote:
>>>> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>> [...]
>>>
>>> Sorry, but we seems just added more work for you.
>>> https://lore.kernel.org/patchwork/cover/1379380/
>>>
>>
>> Could you squash these when you post new version:
>> Sorry for not noticing earlier.
>
> Hey, thanks for the fixup patch and congrats on the new driver support
> for the AM65 NUSS! What's functionally different compared to the other
> CPSW instantiations?
>
CPSW is mostly present on older TI's 32 bit SoCs and can support upto 2
external ports.
AM65 NUSS is next generation multi port switch IP (up to 8 external
ports) present on TI's newer 64 bit platform. It also has different DMA integration and has native HW support to work as both Multi Mac and Switch mode.
> Also, do I get it right that you also tested the bridge port flags
> passed in the new format and that they still work ok? May I add your
> Tested-by tag?
>
Sorry, I have not done extensive testing but tried couple of cmds. Those worked as expected:
root@evm:~# ip link set eth0 type bridge_slave flood off mcast_flood off learning off
Error: bridge: bridge flag offload is not supported.
root@evm:~# ip link set eth0 type bridge_slave mcast_flood off
[ 65.025285] am65-cpsw-nuss 8000000.ethernet eth0: BR_MCAST_FLOOD: 0 port 1
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh Raghavendra <vigneshr@ti.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Ivan Vecera <ivecera@redhat.com>, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Jiri Pirko <jiri@resnulli.us>, Vadym Kochan <vkochan@marvell.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Taras Chornyi <tchornyi@marvell.com>,
Ido Schimmel <idosch@idosch.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
"Strashko, Grygorii" <grygorii.strashko@ti.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>, Jakub Kicinski <kuba@kernel.org>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA
Date: Tue, 16 Feb 2021 16:52:50 +0530 [thread overview]
Message-ID: <adcbe8ce-60b3-551a-941b-f8de52a134d7@ti.com> (raw)
In-Reply-To: <20210212144053.2pumwc6mlt4l2gcj@skbuf>
Hi,
On 2/12/21 8:10 PM, Vladimir Oltean wrote:
> On Fri, Feb 12, 2021 at 08:01:33PM +0530, Vignesh Raghavendra wrote:
>> Hi Vladimir,
>>
>> On 2/12/21 7:47 PM, Grygorii Strashko wrote:
>>>
>>>
>>> On 12/02/2021 03:05, Vladimir Oltean wrote:
>>>> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>> [...]
>>>
>>> Sorry, but we seems just added more work for you.
>>> https://lore.kernel.org/patchwork/cover/1379380/
>>>
>>
>> Could you squash these when you post new version:
>> Sorry for not noticing earlier.
>
> Hey, thanks for the fixup patch and congrats on the new driver support
> for the AM65 NUSS! What's functionally different compared to the other
> CPSW instantiations?
>
CPSW is mostly present on older TI's 32 bit SoCs and can support upto 2
external ports.
AM65 NUSS is next generation multi port switch IP (up to 8 external
ports) present on TI's newer 64 bit platform. It also has different DMA integration and has native HW support to work as both Multi Mac and Switch mode.
> Also, do I get it right that you also tested the bridge port flags
> passed in the new format and that they still work ok? May I add your
> Tested-by tag?
>
Sorry, I have not done extensive testing but tried couple of cmds. Those worked as expected:
root@evm:~# ip link set eth0 type bridge_slave flood off mcast_flood off learning off
Error: bridge: bridge flag offload is not supported.
root@evm:~# ip link set eth0 type bridge_slave mcast_flood off
[ 65.025285] am65-cpsw-nuss 8000000.ethernet eth0: BR_MCAST_FLOOD: 0 port 1
Regards
Vignesh
next prev parent reply other threads:[~2021-02-16 11:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:05 [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 1/9] net: switchdev: propagate extack to port attributes Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 3:20 ` Florian Fainelli
2021-02-12 3:20 ` [Bridge] " Florian Fainelli
2021-02-12 1:05 ` [PATCH v4 net-next 2/9] net: bridge: offload all port flags at once in br_setport Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 3/9] net: bridge: don't print in br_switchdev_set_port_flag Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 4/9] net: dsa: configure better brport flags when ports leave the bridge Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 5/9] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes Vladimir Oltean
2021-02-12 1:05 ` [Bridge] [PATCH v4 net-next 5/9] net: switchdev: pass flags and mask to both {PRE_, }BRIDGE_FLAGS attributes Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 6/9] net: dsa: act as ass passthrough for bridge port flags Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 8:36 ` Vladimir Oltean
2021-02-12 8:36 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 7/9] net: mscc: ocelot: use separate flooding PGID for broadcast Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 12:23 ` Vladimir Oltean
2021-02-12 12:23 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 8/9] net: mscc: ocelot: offload bridge port flags to device Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 1:05 ` [PATCH v4 net-next 9/9] net: dsa: sja1105: " Vladimir Oltean
2021-02-12 1:05 ` [Bridge] " Vladimir Oltean
2021-02-12 14:17 ` [PATCH v4 net-next 0/9] Cleanup in brport flags switchdev offload for DSA Grygorii Strashko
2021-02-12 14:31 ` Vignesh Raghavendra
2021-02-12 14:31 ` [Bridge] " Vignesh Raghavendra
2021-02-12 14:40 ` Vladimir Oltean
2021-02-12 14:40 ` [Bridge] " Vladimir Oltean
2021-02-16 11:22 ` Vignesh Raghavendra [this message]
2021-02-16 11:22 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adcbe8ce-60b3-551a-941b-f8de52a134d7@ti.com \
--to=vigneshr@ti.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=idosch@idosch.org \
--cc=ioana.ciornei@nxp.com \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=roopa@nvidia.com \
--cc=tchornyi@marvell.com \
--cc=vivien.didelot@gmail.com \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.