From: David Rientjes <rientjes@google.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Rohit Vaswani <rvaswani@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Nicolas Pitre <nico@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Sudeep KarkadaNagesha <Sudeep.>
Subject: Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible
Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1308192357420.17575@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com>
On Mon, 12 Aug 2013, Mark Rutland wrote:
> > static void __init msm_smp_prepare_cpus(unsigned int max_cpus)
> > {
> > + int cpu, map;
> > + unsigned int flags = 0;
> > +
> > + for_each_present_cpu(cpu) {
> > + map = cpu_logical_map(cpu);
> > + if (map > ARRAY_SIZE(cold_boot_flags)) {
> > + set_cpu_present(cpu, false);
> > + __WARN();
> > + continue;
> > + }
> > + flags |= cold_boot_flags[map];
__WARN() can't be used in generic code because it's possible to have
CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.
WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Rohit Vaswani <rvaswani@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Pawel Moll <Pawel.Moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Rob Landley <rob@landley.net>,
Russell King <linux@arm.linux.org.uk>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Nicolas Pitre <nico@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>
Subject: Re: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible
Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1308192357420.17575@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com>
On Mon, 12 Aug 2013, Mark Rutland wrote:
> > static void __init msm_smp_prepare_cpus(unsigned int max_cpus)
> > {
> > + int cpu, map;
> > + unsigned int flags = 0;
> > +
> > + for_each_present_cpu(cpu) {
> > + map = cpu_logical_map(cpu);
> > + if (map > ARRAY_SIZE(cold_boot_flags)) {
> > + set_cpu_present(cpu, false);
> > + __WARN();
> > + continue;
> > + }
> > + flags |= cold_boot_flags[map];
__WARN() can't be used in generic code because it's possible to have
CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.
WARNING: multiple messages have this Message-ID (diff)
From: rientjes@google.com (David Rientjes)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible
Date: Mon, 19 Aug 2013 23:59:44 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1308192357420.17575@chino.kir.corp.google.com> (raw)
In-Reply-To: <20130812155016.GC27165@e106331-lin.cambridge.arm.com>
On Mon, 12 Aug 2013, Mark Rutland wrote:
> > static void __init msm_smp_prepare_cpus(unsigned int max_cpus)
> > {
> > + int cpu, map;
> > + unsigned int flags = 0;
> > +
> > + for_each_present_cpu(cpu) {
> > + map = cpu_logical_map(cpu);
> > + if (map > ARRAY_SIZE(cold_boot_flags)) {
> > + set_cpu_present(cpu, false);
> > + __WARN();
> > + continue;
> > + }
> > + flags |= cold_boot_flags[map];
__WARN() can't be used in generic code because it's possible to have
CONFIG_BUG=n, you probably want something like WARN_ON(1) instead.
next prev parent reply other threads:[~2013-08-20 6:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 2:15 [RESEND PATCH 0/4]Add SMP support for MSM8660, MSM8960 and MSM8974 Rohit Vaswani
2013-08-02 2:15 ` Rohit Vaswani
2013-08-02 2:15 ` [RESEND PATCH 1/4] ARM: msm: Remove pen_release usage Rohit Vaswani
2013-08-02 2:15 ` Rohit Vaswani
2013-08-02 2:15 ` [RESEND PATCH 2/4] ARM: msm: Re-organize platsmp to make it extensible Rohit Vaswani
2013-08-02 2:15 ` Rohit Vaswani
2013-08-12 15:50 ` Mark Rutland
2013-08-12 15:50 ` Mark Rutland
2013-08-12 15:50 ` Mark Rutland
2013-08-14 20:55 ` Rohit Vaswani
2013-08-14 20:55 ` Rohit Vaswani
2013-08-14 20:55 ` Rohit Vaswani
2013-08-16 9:37 ` Mark Rutland
2013-08-16 9:37 ` Mark Rutland
2013-08-16 9:37 ` Mark Rutland
2013-08-20 6:59 ` David Rientjes [this message]
2013-08-20 6:59 ` David Rientjes
2013-08-20 6:59 ` David Rientjes
2013-08-02 2:15 ` [PATCH 3/4] ARM: msm: Add SMP support for 8960 Rohit Vaswani
2013-08-02 2:15 ` Rohit Vaswani
2013-08-02 15:43 ` Kumar Gala
2013-08-02 15:43 ` Kumar Gala
2013-08-14 22:41 ` Rohit Vaswani
2013-08-14 22:41 ` Rohit Vaswani
2013-08-12 16:19 ` Mark Rutland
2013-08-12 16:19 ` Mark Rutland
2013-08-12 16:19 ` Mark Rutland
2013-08-02 2:15 ` [RESEND PATCH 4/4] ARM: msm: Add support for 8974 SMP Rohit Vaswani
2013-08-02 2:15 ` Rohit Vaswani
2013-08-02 15:46 ` Kumar Gala
2013-08-02 15:46 ` Kumar Gala
2013-08-14 22:43 ` Rohit Vaswani
2013-08-14 22:43 ` Rohit Vaswani
2013-08-12 16:39 ` Mark Rutland
2013-08-12 16:39 ` Mark Rutland
2013-08-12 16:39 ` Mark Rutland
2013-08-14 22:38 ` Rohit Vaswani
2013-08-14 22:38 ` Rohit Vaswani
2013-08-14 22:38 ` Rohit Vaswani
2013-08-16 9:44 ` Mark Rutland
2013-08-16 9:44 ` Mark Rutland
2013-08-16 9:44 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1308192357420.17575@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dwalker@fifo99.com \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nico@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=rvaswani@codeaurora.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.