All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Dou Liyang <dou_liyang@163.com>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
	Ming Lei <tom.leiming@gmail.com>,
	Sumit Saxena <sumit.saxena@broadcom.com>,
	Ming Lei <ming.lei@redhat.com>, Christoph Hellwig <hch@lst.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Shivasharan Srikanteshwara
	<shivasharan.srikanteshwara@broadcom.com>,
	linux-block <linux-block@vger.kernel.org>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>
Subject: Re: Affinity managed interrupts vs non-managed interrupts
Date: Thu, 6 Sep 2018 13:46:46 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1809061244151.1570@nanos.tec.linutronix.de> (raw)
In-Reply-To: <d2a6f7cf-31df-de17-82e3-eccb9cc73ed8@163.com>

On Thu, 6 Sep 2018, Dou Liyang wrote:
> At 09/05/2018 06:38 PM, Thomas Gleixner wrote:
> > Oh well. This was not intended to magically provide the solution you want
> > to have. It merily changed the behaviour of the managed interrupt
> > selection, which is a valid thing to do independent of the stuff you want
> > to see.
> > 
> 
> Thank you for clarifying it, I will send the patch independently.
> 
> > As I said that needs more thought and I really can't tell when I have a
> > time slot to look at that.
> > 
> 
> In this period, I am willing to be a volunteer to try to do that you
> said in the previous reply. May I?

You don't have to ask for permission. It's Open Source :)

There are a few things we need to clarify upfront:

Right now the pre and post vectors are marked managed and their
affinity mask is set to the irq default affinity mask.

The default affinity mask is by default ALL cpus, but it can be tweaked
both on the kernel command line and via proc.

If that mask is only a subset of CPUs and all of them go offline
then these vectors are shutdown in managed mode.

That means we need to set the affinity mask of the pre and post vectors to
possible mask, but that doesn't make much sense either, unless there is a
reason to have them marked managed.

I think the right solution for these pre/post vectors is to _NOT_ mark
them managed and leave them as regular interrupts which can be affinity
controlled and also can move freely on hotplug.

Christoph?

Thanks,

	Thomas

  reply	other threads:[~2018-09-06 16:22 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <eccc46e12890a1d033d9003837012502@mail.gmail.com>
2018-08-29  8:46 ` Affinity managed interrupts vs non-managed interrupts Ming Lei
2018-08-29 10:46   ` Sumit Saxena
2018-08-30 17:15     ` Kashyap Desai
2018-08-31  6:54     ` Ming Lei
2018-08-31  7:50       ` Kashyap Desai
2018-08-31  7:50         ` Kashyap Desai
2018-08-31 20:24         ` Thomas Gleixner
2018-08-31 20:24           ` Thomas Gleixner
2018-08-31 21:49           ` Kashyap Desai
2018-08-31 21:49             ` Kashyap Desai
2018-08-31 22:48             ` Thomas Gleixner
2018-08-31 22:48               ` Thomas Gleixner
2018-08-31 23:37               ` Kashyap Desai
2018-08-31 23:37                 ` Kashyap Desai
2018-09-02 12:02                 ` Thomas Gleixner
2018-09-02 12:02                   ` Thomas Gleixner
2018-09-03  5:34                   ` Kashyap Desai
2018-09-03  5:34                     ` Kashyap Desai
2018-09-03 16:28                     ` Thomas Gleixner
2018-09-03 16:28                       ` Thomas Gleixner
2018-09-04 10:29                       ` Kashyap Desai
2018-09-04 10:29                         ` Kashyap Desai
2018-09-05  5:46                         ` Dou Liyang
2018-09-05  5:46                           ` Dou Liyang
2018-09-05  9:45                           ` Kashyap Desai
2018-09-05  9:45                             ` Kashyap Desai
2018-09-05 10:38                             ` Thomas Gleixner
2018-09-05 10:38                               ` Thomas Gleixner
2018-09-06 10:14                               ` Dou Liyang
2018-09-06 10:14                                 ` Dou Liyang
2018-09-06 11:46                                 ` Thomas Gleixner [this message]
2018-09-06 11:46                                   ` Thomas Gleixner
2018-09-11  9:13                                   ` Christoph Hellwig
2018-09-11  9:13                                     ` Christoph Hellwig
2018-09-11  9:38                                     ` Dou Liyang
2018-09-11  9:38                                       ` Dou Liyang
2018-09-11  9:22               ` Christoph Hellwig
2018-09-11  9:22                 ` Christoph Hellwig
2018-09-03  2:13         ` Ming Lei
2018-09-03  2:13           ` Ming Lei
2018-09-03  6:10           ` Kashyap Desai
2018-09-03  6:10             ` Kashyap Desai
2018-09-03  9:21             ` Ming Lei
2018-09-03  9:21               ` Ming Lei
2018-09-03  9:50               ` Kashyap Desai
2018-09-03  9:50                 ` Kashyap Desai
2018-09-11  9:21     ` Christoph Hellwig
2018-09-11  9:54       ` Kashyap Desai
2018-08-28  6:47 Sumit Saxena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1809061244151.1570@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=dou_liyang@163.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hch@lst.de \
    --cc=kashyap.desai@broadcom.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --cc=shivasharan.srikanteshwara@broadcom.com \
    --cc=sumit.saxena@broadcom.com \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.