All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: zhongshiqi <zhong.shiqi@zte.com.cn>
Cc: Julia.Lawall@lip6.fr, Gilles Muller <Gilles.Muller@lip6.fr>,
	nicolas.palix@imag.fr, michal.lkml@markovi.net,
	cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
	xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn,
	cheng.shengyu@zte.com.cn, yamada.masahiro@socionext.com
Subject: Re: [PATCH] Configuring COCCI parameter as a directory is supportted
Date: Wed, 23 Oct 2019 10:55:39 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910231054250.2335@hadrien> (raw)
In-Reply-To: <1571819563-18118-1-git-send-email-zhong.shiqi@zte.com.cn>



On Wed, 23 Oct 2019, zhongshiqi wrote:

> This patch puts a modification in scripts/coccicheck which supports users
> in configuring COCCI parameter as a directory to traverse files in
> directory.
>
> Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
> ---
>  scripts/coccicheck | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e04d328..a1c4197 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
>      for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
>  	coccinelle $f
>      done
> +elif [ -d "$COCCI" ] ; then
> +    for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
> +	coccinelle $f
> +    done
>  else
>      coccinelle $COCCI
>  fi

Thanks for the contribution.  I'm not that knowledgeable about these
scripts.  What is the relation between the last two if branches?  If the
first one fails, does that mean that $COCCI has no definition?  In that
case, is the final else useful?

thanks,
julia

WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <julia.lawall@lip6.fr>
To: zhongshiqi <zhong.shiqi@zte.com.cn>
Cc: wang.yi59@zte.com.cn, michal.lkml@markovi.net,
	nicolas.palix@imag.fr, linux-kernel@vger.kernel.org,
	xue.zhihong@zte.com.cn, cheng.shengyu@zte.com.cn,
	cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] Configuring COCCI parameter as a directory is supportted
Date: Wed, 23 Oct 2019 10:55:39 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.1910231054250.2335@hadrien> (raw)
In-Reply-To: <1571819563-18118-1-git-send-email-zhong.shiqi@zte.com.cn>



On Wed, 23 Oct 2019, zhongshiqi wrote:

> This patch puts a modification in scripts/coccicheck which supports users
> in configuring COCCI parameter as a directory to traverse files in
> directory.
>
> Signed-off-by: zhongshiqi <zhong.shiqi@zte.com.cn>
> ---
>  scripts/coccicheck | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index e04d328..a1c4197 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -257,6 +257,10 @@ if [ "$COCCI" = "" ] ; then
>      for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
>  	coccinelle $f
>      done
> +elif [ -d "$COCCI" ] ; then
> +    for f in `find $COCCI/ -name '*.cocci' -type f | sort`; do
> +	coccinelle $f
> +    done
>  else
>      coccinelle $COCCI
>  fi

Thanks for the contribution.  I'm not that knowledgeable about these
scripts.  What is the relation between the last two if branches?  If the
first one fails, does that mean that $COCCI has no definition?  In that
case, is the final else useful?

thanks,
julia
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-10-23  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23  8:32 [PATCH] Configuring COCCI parameter as a directory is supportted zhongshiqi
2019-10-23  8:32 ` [Cocci] " zhongshiqi
2019-10-23  8:55 ` Julia Lawall [this message]
2019-10-23  8:55   ` Julia Lawall
2019-10-23  9:40   ` [Cocci] [PATCH] Configuring COCCI parameter as a directory issupportted zhong.shiqi
2019-10-23 14:08   ` [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search Markus Elfring
2019-10-23 14:08     ` [Cocci] " Markus Elfring
2019-10-23 14:08     ` Markus Elfring
2019-10-23 13:20 ` Markus Elfring
2019-10-23 13:20   ` [Cocci] " Markus Elfring
2019-10-23 13:20   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1910231054250.2335@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=Gilles.Muller@lip6.fr \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    --cc=yamada.masahiro@socionext.com \
    --cc=zhong.shiqi@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.