* [PATCH] riscv: export pm_power_off again
@ 2019-06-11 10:28 Andreas Schwab
2019-06-11 13:50 ` Christoph Hellwig
2019-06-11 13:54 ` Paul Walmsley
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Schwab @ 2019-06-11 10:28 UTC (permalink / raw)
To: linux-riscv; +Cc: Atish Patra, Palmer Dabbelt, Christoph Hellwig
Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt /
machine_power_off") removed the export of pm_power_off, but it is used by
several modules:
ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined!
ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined!
ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
Signed-off-by: Andreas Schwab <schwab@suse.de>
---
arch/riscv/kernel/reset.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/kernel/reset.c b/arch/riscv/kernel/reset.c
index cfb6eb1d762d..d0fe623bfb8f 100644
--- a/arch/riscv/kernel/reset.c
+++ b/arch/riscv/kernel/reset.c
@@ -13,6 +13,7 @@ static void default_power_off(void)
}
void (*pm_power_off)(void) = default_power_off;
+EXPORT_SYMBOL(pm_power_off);
void machine_restart(char *cmd)
{
--
2.22.0
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: export pm_power_off again
2019-06-11 10:28 [PATCH] riscv: export pm_power_off again Andreas Schwab
@ 2019-06-11 13:50 ` Christoph Hellwig
2019-06-11 13:54 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2019-06-11 13:50 UTC (permalink / raw)
To: Andreas Schwab
Cc: Atish Patra, linux-riscv, Palmer Dabbelt, Christoph Hellwig
On Tue, Jun 11, 2019 at 12:28:40PM +0200, Andreas Schwab wrote:
> Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt /
> machine_power_off") removed the export of pm_power_off, but it is used by
> several modules:
>
> ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined!
> ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined!
> ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined!
> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
None of these drivers should be buildable on RISC-V. Please work with
the maintainers to fix this up.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: export pm_power_off again
2019-06-11 10:28 [PATCH] riscv: export pm_power_off again Andreas Schwab
2019-06-11 13:50 ` Christoph Hellwig
@ 2019-06-11 13:54 ` Paul Walmsley
1 sibling, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2019-06-11 13:54 UTC (permalink / raw)
To: Andreas Schwab
Cc: Atish Patra, linux-riscv, Palmer Dabbelt, Christoph Hellwig
On Tue, 11 Jun 2019, Andreas Schwab wrote:
> Commit bf0102a0fdd9 ("riscv: call pm_power_off from machine_halt /
> machine_power_off") removed the export of pm_power_off, but it is used by
> several modules:
>
> ERROR: "pm_power_off" [drivers/mfd/rk808.ko] undefined!
> ERROR: "pm_power_off" [drivers/mfd/max8907.ko] undefined!
> ERROR: "pm_power_off" [drivers/mfd/axp20x.ko] undefined!
> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>
> Signed-off-by: Andreas Schwab <schwab@suse.de>
Thanks, queued for v5.2-rc, along with a "Fixes:" line.
- Paul
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-11 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 10:28 [PATCH] riscv: export pm_power_off again Andreas Schwab
2019-06-11 13:50 ` Christoph Hellwig
2019-06-11 13:54 ` Paul Walmsley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.