All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Darren Hart <dvhart@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	David Howells <dhowells@redhat.com>,
	"Serge E. Hallyn" <serge.hallyn@canonical.com>,
	kernel-hardening@lists.openwall.com, spender@grsecurity.net
Subject: Re: [PATCH] futex: mark get_robust_list as deprecated
Date: Fri, 23 Mar 2012 19:27:53 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1203231926000.2542@ionos> (raw)
In-Reply-To: <20120323175855.GA23668@www.outflux.net>

On Fri, 23 Mar 2012, Kees Cook wrote:

> Notify get_robust_list users that the syscall is going away.

That want's an entry in Documentation/feature-removal-schedule.txt as
well.

That's on top of your previous one, right ?

Thanks,

	tglx
 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  kernel/futex.c        |    2 ++
>  kernel/futex_compat.c |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/futex.c b/kernel/futex.c
> index 439440d..545d7a3 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -2449,6 +2449,8 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> +	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> +
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;
> diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
> index a9642d5..83e368b 100644
> --- a/kernel/futex_compat.c
> +++ b/kernel/futex_compat.c
> @@ -142,6 +142,8 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> +	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> +
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;
> -- 
> 1.7.0.4
> 
> -- 
> Kees Cook
> ChromeOS Security
> 

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
	Darren Hart <dvhart@linux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jiri Kosina <jkosina@suse.cz>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	David Howells <dhowells@redhat.com>,
	"Serge E. Hallyn" <serge.hallyn@canonical.com>,
	kernel-hardening@lists.openwall.com, spender@grsecurity.net
Subject: [kernel-hardening] Re: [PATCH] futex: mark get_robust_list as deprecated
Date: Fri, 23 Mar 2012 19:27:53 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1203231926000.2542@ionos> (raw)
In-Reply-To: <20120323175855.GA23668@www.outflux.net>

On Fri, 23 Mar 2012, Kees Cook wrote:

> Notify get_robust_list users that the syscall is going away.

That want's an entry in Documentation/feature-removal-schedule.txt as
well.

That's on top of your previous one, right ?

Thanks,

	tglx
 
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  kernel/futex.c        |    2 ++
>  kernel/futex_compat.c |    2 ++
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/futex.c b/kernel/futex.c
> index 439440d..545d7a3 100644
> --- a/kernel/futex.c
> +++ b/kernel/futex.c
> @@ -2449,6 +2449,8 @@ SYSCALL_DEFINE3(get_robust_list, int, pid,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> +	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> +
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;
> diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c
> index a9642d5..83e368b 100644
> --- a/kernel/futex_compat.c
> +++ b/kernel/futex_compat.c
> @@ -142,6 +142,8 @@ compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
>  	if (!futex_cmpxchg_enabled)
>  		return -ENOSYS;
>  
> +	WARN_ONCE(1, "deprecated: get_robust_list will be deleted in 2013.\n");
> +
>  	rcu_read_lock();
>  
>  	ret = -ESRCH;
> -- 
> 1.7.0.4
> 
> -- 
> Kees Cook
> ChromeOS Security
> 

  reply	other threads:[~2012-03-23 18:28 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-19 23:12 [PATCH] futex: do not leak robust list to unprivileged process Kees Cook
2012-03-19 23:12 ` [kernel-hardening] " Kees Cook
2012-03-20 13:31 ` Serge Hallyn
2012-03-20 13:31   ` [kernel-hardening] " Serge Hallyn
2012-03-20 17:02   ` Thomas Gleixner
2012-03-20 17:02     ` [kernel-hardening] " Thomas Gleixner
2012-03-20 17:11     ` Kees Cook
2012-03-20 17:11       ` [kernel-hardening] " Kees Cook
2012-03-20 17:23       ` Ingo Molnar
2012-03-20 17:23         ` [kernel-hardening] " Ingo Molnar
2012-03-22 23:46         ` Thomas Gleixner
2012-03-22 23:46           ` [kernel-hardening] " Thomas Gleixner
2012-03-23 17:58           ` [PATCH] futex: mark get_robust_list as deprecated Kees Cook
2012-03-23 17:58             ` [kernel-hardening] " Kees Cook
2012-03-23 18:27             ` Thomas Gleixner [this message]
2012-03-23 18:27               ` [kernel-hardening] " Thomas Gleixner
2012-03-23 19:08               ` Kees Cook
2012-03-23 19:08                 ` [kernel-hardening] " Kees Cook
2012-03-23 19:08               ` [PATCH v2] " Kees Cook
2012-03-23 19:08                 ` [kernel-hardening] " Kees Cook
     [not found]                 ` <20120323190855.GA27213-0X9Bc/hWBUTk6RaD4rd5nQ@public.gmane.org>
2012-03-23 22:06                   ` Eric W. Biederman
2012-03-23 22:06                     ` [kernel-hardening] " Eric W. Biederman
2012-03-23 22:06                     ` Eric W. Biederman
     [not found]                     ` <m1fwczvuph.fsf-+imSwln9KH6u2/kzUuoCbdi2O/JbrIOy@public.gmane.org>
2012-03-23 22:10                       ` Kees Cook
2012-03-23 22:10                         ` [kernel-hardening] " Kees Cook
2012-03-23 22:10                         ` Kees Cook
2012-03-30  5:05                       ` Matt Helsley
2012-03-30  5:05                         ` [kernel-hardening] " Matt Helsley
2012-03-30  5:05                         ` Matt Helsley
     [not found]                         ` <20120330050544.GA32299-52DBMbEzqgQ/wnmkkaCWp/UQ3DHhIser@public.gmane.org>
2012-03-30  6:14                           ` Pavel Emelyanov
2012-03-30  6:14                             ` [kernel-hardening] " Pavel Emelyanov
2012-03-30  6:14                             ` Pavel Emelyanov
2012-03-30 22:51                           ` Gene Cooperman
2012-03-30 22:51                         ` Gene Cooperman
2012-03-30 22:51                           ` [kernel-hardening] " Gene Cooperman
2012-03-27 18:05                 ` Josh Boyer
2012-03-27 18:05                   ` [kernel-hardening] " Josh Boyer
2012-03-27 19:13                   ` Peter Zijlstra
2012-03-27 19:13                     ` [kernel-hardening] " Peter Zijlstra
2012-03-29  9:56                 ` [tip:core/locking] futex: Mark " tip-bot for Kees Cook
2012-08-02 10:35                 ` [PATCH v2] futex: mark " richard -rw- weinberger
2012-08-02 10:35                   ` [kernel-hardening] " richard -rw- weinberger
2012-08-02 11:11                   ` Eric W. Biederman
2012-08-02 11:11                     ` [kernel-hardening] " Eric W. Biederman
2012-08-03 10:17                     ` richard -rw- weinberger
2012-08-03 10:17                       ` [kernel-hardening] " richard -rw- weinberger
2012-08-03 11:02                       ` Cyrill Gorcunov
2012-08-03 11:02                         ` [kernel-hardening] " Cyrill Gorcunov
2012-08-03 11:19                         ` richard -rw- weinberger
2012-08-03 11:19                           ` [kernel-hardening] " richard -rw- weinberger
2012-08-03 11:27                           ` Cyrill Gorcunov
2012-08-03 11:27                             ` [kernel-hardening] " Cyrill Gorcunov
2012-08-03 11:30                             ` richard -rw- weinberger
2012-08-03 11:30                               ` [kernel-hardening] " richard -rw- weinberger
2012-08-03 11:35                               ` Cyrill Gorcunov
2012-08-03 11:35                                 ` [kernel-hardening] " Cyrill Gorcunov
2012-08-03 11:38                                 ` richard -rw- weinberger
2012-08-03 11:38                                   ` [kernel-hardening] " richard -rw- weinberger
2012-08-03 12:38                         ` Pavel Emelyanov
2012-08-03 12:38                           ` [kernel-hardening] " Pavel Emelyanov
2012-08-03 12:58                           ` Eric W. Biederman
2012-08-03 12:58                             ` [kernel-hardening] " Eric W. Biederman
2012-08-03 13:00                             ` richard -rw- weinberger
2012-08-03 13:00                               ` [kernel-hardening] " richard -rw- weinberger
2012-08-03 17:16                             ` Kees Cook
2012-08-03 17:16                               ` [kernel-hardening] " Kees Cook
2012-08-03 18:06                               ` [kernel-hardening] [PATCH] Revert "futex: Mark get_robust_list as deprecated" Richard Weinberger
2012-03-28 18:33           ` [PATCH] futex: do not leak robust list to unprivileged process Kees Cook
2012-03-28 18:33             ` [kernel-hardening] " Kees Cook
2012-03-28 21:24             ` Thomas Gleixner
2012-03-28 21:24               ` [kernel-hardening] " Thomas Gleixner
2012-03-29  9:55 ` [tip:core/locking] futex: Do " tip-bot for Kees Cook
2012-06-19  1:41   ` Wanlong Gao
2012-06-19  2:24     ` Serge Hallyn
2012-06-19  2:32       ` Wanlong Gao
2012-06-19  3:13         ` Serge Hallyn
2012-06-19  3:21           ` Wanlong Gao
2012-06-19 12:23             ` Serge Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1203231926000.2542@ionos \
    --to=tglx@linutronix.de \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=dvhart@linux.intel.com \
    --cc=ebiederm@xmission.com \
    --cc=jkosina@suse.cz \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serge.hallyn@canonical.com \
    --cc=spender@grsecurity.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.