All of lore.kernel.org
 help / color / mirror / Atom feed
* [MODERATED] [PATCH v2.1 0/6] On top of Thomas+Paolo's
@ 2018-06-20 20:42 konrad.wilk
  2018-06-21  3:14 ` [MODERATED] " Konrad Rzeszutek Wilk
  0 siblings, 1 reply; 6+ messages in thread
From: konrad.wilk @ 2018-06-20 20:42 UTC (permalink / raw)
  To: speck

Hey,

This patchset replaces Paolo's second patch but also adds the warnings
that Linus wanted. Along with some extra knobs in case the MSR will
have more things in the future.

Oh, and one bug-fix.

I am also working on using the VMX Load MSR list so that the L1D flush
happens automatically on VMENTER.


Konrad Rzeszutek Wilk (5):
      x86/bugs: Move the l1tf function and define pr_fmt properly
      x86/cpufeatures: Add detection of L1D cache flush support.
      x86/bugs: Read FLUSH_CMD MSR during boot.
      x86/KVM: Warn user if KVM is loaded SMT and L1TF CPU bug being present.
      x86/KVM: Use L1 cache flush before VMENTER if available.

Paolo Bonzini (1):
      kvm: x86: mitigation for L1 cache terminal fault vulnerabilities

 Documentation/admin-guide/kernel-parameters.txt |  4 ++
 arch/x86/include/asm/cpu.h                      |  4 ++
 arch/x86/include/asm/cpufeatures.h              |  1 +
 arch/x86/include/asm/kvm_host.h                 |  7 ++-
 arch/x86/include/asm/msr-index.h                |  6 ++
 arch/x86/kernel/cpu/bugs.c                      | 83 +++++++++++++++++--------
 arch/x86/kvm/mmu.c                              |  1 +
 arch/x86/kvm/svm.c                              |  3 +-
 arch/x86/kvm/vmx.c                              | 46 +++++++++++++-
 arch/x86/kvm/x86.c                              | 80 +++++++++++++++++++++++-
 kernel/cpu.c                                    |  1 +
 11 files changed, 205 insertions(+), 31 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MODERATED] Re: [PATCH v2.1 0/6] On top of Thomas+Paolo's
  2018-06-20 20:42 [MODERATED] [PATCH v2.1 0/6] On top of Thomas+Paolo's konrad.wilk
@ 2018-06-21  3:14 ` Konrad Rzeszutek Wilk
  2018-06-21  8:46   ` Peter Zijlstra
  0 siblings, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2018-06-21  3:14 UTC (permalink / raw)
  To: speck

[-- Attachment #1: Type: text/plain, Size: 1889 bytes --]

On Wed, Jun 20, 2018 at 04:42:56PM -0400, speck for konrad.wilk_at_oracle.com wrote:
> Hey,
> 
> This patchset replaces Paolo's second patch but also adds the warnings
> that Linus wanted. Along with some extra knobs in case the MSR will
> have more things in the future.
> 
> Oh, and one bug-fix.
> 
> I am also working on using the VMX Load MSR list so that the L1D flush
> happens automatically on VMENTER.

Done.

Attached is the git bundle of the patches that were posted and also
code to do L1D flush using the VMX load MSR list. 

I can most certainly post it, but I hadn't run any performance numbers
so not sure if that approach is even worth it or not.

> 
> 
> Konrad Rzeszutek Wilk (5):
>       x86/bugs: Move the l1tf function and define pr_fmt properly
>       x86/cpufeatures: Add detection of L1D cache flush support.
>       x86/bugs: Read FLUSH_CMD MSR during boot.
>       x86/KVM: Warn user if KVM is loaded SMT and L1TF CPU bug being present.
>       x86/KVM: Use L1 cache flush before VMENTER if available.
> 
> Paolo Bonzini (1):
>       kvm: x86: mitigation for L1 cache terminal fault vulnerabilities
> 
>  Documentation/admin-guide/kernel-parameters.txt |  4 ++
>  arch/x86/include/asm/cpu.h                      |  4 ++
>  arch/x86/include/asm/cpufeatures.h              |  1 +
>  arch/x86/include/asm/kvm_host.h                 |  7 ++-
>  arch/x86/include/asm/msr-index.h                |  6 ++
>  arch/x86/kernel/cpu/bugs.c                      | 83 +++++++++++++++++--------
>  arch/x86/kvm/mmu.c                              |  1 +
>  arch/x86/kvm/svm.c                              |  3 +-
>  arch/x86/kvm/vmx.c                              | 46 +++++++++++++-
>  arch/x86/kvm/x86.c                              | 80 +++++++++++++++++++++++-
>  kernel/cpu.c                                    |  1 +
>  11 files changed, 205 insertions(+), 31 deletions(-)

[-- Attachment #2: kvm.l1tf.v4.rc5.bundle --]
[-- Type: application/octet-stream, Size: 49667 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MODERATED] Re: [PATCH v2.1 0/6] On top of Thomas+Paolo's
  2018-06-21  3:14 ` [MODERATED] " Konrad Rzeszutek Wilk
@ 2018-06-21  8:46   ` Peter Zijlstra
  2018-06-21 15:35     ` Thomas Gleixner
  2018-06-21 20:37     ` Linus Torvalds
  0 siblings, 2 replies; 6+ messages in thread
From: Peter Zijlstra @ 2018-06-21  8:46 UTC (permalink / raw)
  To: speck

On Wed, Jun 20, 2018 at 11:14:31PM -0400, speck for Konrad Rzeszutek Wilk wrote:
> > I am also working on using the VMX Load MSR list so that the L1D flush
> > happens automatically on VMENTER.

That's a pretty neat trick.

> Attached is the git bundle of the patches that were posted and also
> code to do L1D flush using the VMX load MSR list. 

Is there any way to just _view_ a bundle? Without the pain to load it
into git and then figure out how to extract useful patches from that
again? git-bundle doesn't seem to have that option.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2.1 0/6] On top of Thomas+Paolo's
  2018-06-21  8:46   ` Peter Zijlstra
@ 2018-06-21 15:35     ` Thomas Gleixner
  2018-06-21 17:49       ` [MODERATED] " Konrad Rzeszutek Wilk
  2018-06-21 20:37     ` Linus Torvalds
  1 sibling, 1 reply; 6+ messages in thread
From: Thomas Gleixner @ 2018-06-21 15:35 UTC (permalink / raw)
  To: speck

On Thu, 21 Jun 2018, speck for Peter Zijlstra wrote:
>
> Is there any way to just _view_ a bundle? Without the pain to load it
> into git and then figure out how to extract useful patches from that
> again? git-bundle doesn't seem to have that option.

Not that I know of and the Oracles of Gurgle do not know anything either.

Thanks,

	tglx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MODERATED] Re: [PATCH v2.1 0/6] On top of Thomas+Paolo's
  2018-06-21 15:35     ` Thomas Gleixner
@ 2018-06-21 17:49       ` Konrad Rzeszutek Wilk
  0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2018-06-21 17:49 UTC (permalink / raw)
  To: speck

On Thu, Jun 21, 2018 at 05:35:53PM +0200, speck for Thomas Gleixner wrote:
> On Thu, 21 Jun 2018, speck for Peter Zijlstra wrote:
> >
> > Is there any way to just _view_ a bundle? Without the pain to load it
> > into git and then figure out how to extract useful patches from that
> > again? git-bundle doesn't seem to have that option.

I can post them all once I rebase on l1tf.v6 that Thomas just sent.

> 
> Not that I know of and the Oracles of Gurgle do not know anything either.
> 
> Thanks,
> 
> 	tglx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MODERATED] Re: [PATCH v2.1 0/6] On top of Thomas+Paolo's
  2018-06-21  8:46   ` Peter Zijlstra
  2018-06-21 15:35     ` Thomas Gleixner
@ 2018-06-21 20:37     ` Linus Torvalds
  1 sibling, 0 replies; 6+ messages in thread
From: Linus Torvalds @ 2018-06-21 20:37 UTC (permalink / raw)
  To: speck



On Thu, 21 Jun 2018, speck for Peter Zijlstra wrote:
> 
> Is there any way to just _view_ a bundle? Without the pain to load it
> into git and then figure out how to extract useful patches from that
> again? git-bundle doesn't seem to have that option.

A bundle on its own doesn't even have all the information. It's not a 
collection of patches. It's literally an offline version of the git 
synchronization protocol, so it's delta-compressed against the repository 
etc, and a bundle on its own will not make sense.

So you have to do

    git fetch bundle

to integrate it into the repository and give it all the context it needs 
to make sense. Then "gitk ..FETCH_HEAD" etc will work, and all the normal 
git tools to look at patches.

            Linus

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-06-21 20:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-20 20:42 [MODERATED] [PATCH v2.1 0/6] On top of Thomas+Paolo's konrad.wilk
2018-06-21  3:14 ` [MODERATED] " Konrad Rzeszutek Wilk
2018-06-21  8:46   ` Peter Zijlstra
2018-06-21 15:35     ` Thomas Gleixner
2018-06-21 17:49       ` [MODERATED] " Konrad Rzeszutek Wilk
2018-06-21 20:37     ` Linus Torvalds

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.