From: Jiri Kosina <jkosina@suse.cz> To: Pavel Machek <pavel@ucw.cz> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux-pm mailing list <linux-pm@lists.osdl.org>, kernel list <linux-kernel@vger.kernel.org>, Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx <intel-gfx@lists.freedesktop.org> Subject: Re: 3.15-rc: regression in suspend Date: Thu, 7 Aug 2014 14:54:41 +0200 (CEST) [thread overview] Message-ID: <alpine.LNX.2.00.1408071453370.6219@pobox.suse.cz> (raw) In-Reply-To: <alpine.LNX.2.00.1408071445250.6219@pobox.suse.cz> On Thu, 7 Aug 2014, Jiri Kosina wrote: > The patch below seems to finally cure the problem at my system; I've just > attached it to freedesktop bugzilla, but sending it to this thread as well > to hopefully get as much testing coverage by affected people as possible. > > I am going on with testing whether it really completely fixes the problem > or just made it less likely. Okay, after 31 suspend-resume cycles, the problem appeared again (while without the patch, it triggers with 100% reliability). So it's not a complete fix, it just makes the problem much less visible. Going back to bugzilla discussion. > > From: Jiri Kosina <jkosina@suse.cz> > Subject: [PATCH] drm/i915: read HEAD register back in init_ring_common() to enforce ordering > > Withtout this, ring initialization fails reliabily during resume with > > [drm:init_ring_common] *ERROR* render ring initialization failed ctl 0001f001 head ffffff8804 tail 00000000 start 000e4000 > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 279488a..7add7ee 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -517,6 +517,9 @@ static int init_ring_common(struct intel_engine_cs *ring) > else > ring_setup_phys_status_page(ring); > > + /* Enforce ordering by reading HEAD register back */ > + I915_READ_HEAD(ring); > + > /* Initialize the ring. This must happen _after_ we've cleared the ring > * registers with the above sequence (the readback of the HEAD registers > * also enforces ordering), otherwise the hw might lose the new ring -- Jiri Kosina SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Kosina <jkosina@suse.cz> To: Pavel Machek <pavel@ucw.cz> Cc: Linux-pm mailing list <linux-pm@lists.osdl.org>, intel-gfx <intel-gfx@lists.freedesktop.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, kernel list <linux-kernel@vger.kernel.org> Subject: Re: 3.15-rc: regression in suspend Date: Thu, 7 Aug 2014 14:54:41 +0200 (CEST) [thread overview] Message-ID: <alpine.LNX.2.00.1408071453370.6219@pobox.suse.cz> (raw) In-Reply-To: <alpine.LNX.2.00.1408071445250.6219@pobox.suse.cz> On Thu, 7 Aug 2014, Jiri Kosina wrote: > The patch below seems to finally cure the problem at my system; I've just > attached it to freedesktop bugzilla, but sending it to this thread as well > to hopefully get as much testing coverage by affected people as possible. > > I am going on with testing whether it really completely fixes the problem > or just made it less likely. Okay, after 31 suspend-resume cycles, the problem appeared again (while without the patch, it triggers with 100% reliability). So it's not a complete fix, it just makes the problem much less visible. Going back to bugzilla discussion. > > From: Jiri Kosina <jkosina@suse.cz> > Subject: [PATCH] drm/i915: read HEAD register back in init_ring_common() to enforce ordering > > Withtout this, ring initialization fails reliabily during resume with > > [drm:init_ring_common] *ERROR* render ring initialization failed ctl 0001f001 head ffffff8804 tail 00000000 start 000e4000 > > Signed-off-by: Jiri Kosina <jkosina@suse.cz> > --- > drivers/gpu/drm/i915/intel_ringbuffer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c > index 279488a..7add7ee 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.c > +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c > @@ -517,6 +517,9 @@ static int init_ring_common(struct intel_engine_cs *ring) > else > ring_setup_phys_status_page(ring); > > + /* Enforce ordering by reading HEAD register back */ > + I915_READ_HEAD(ring); > + > /* Initialize the ring. This must happen _after_ we've cleared the ring > * registers with the above sequence (the readback of the HEAD registers > * also enforces ordering), otherwise the hw might lose the new ring -- Jiri Kosina SUSE Labs
next prev parent reply other threads:[~2014-08-07 12:54 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-05-13 16:09 3.15-rc: regression in suspend Pavel Machek 2014-05-13 16:19 ` Bjørn Mork 2014-05-13 16:50 ` Pavel Machek 2014-05-13 16:37 ` Pavel Machek 2014-05-13 21:41 ` Pavel Machek 2014-05-14 12:39 ` Jiri Kosina 2014-05-14 15:57 ` Pavel Machek 2014-05-14 16:10 ` Jiri Kosina 2014-05-14 20:31 ` Pavel Machek 2014-05-14 18:20 ` Pavel Machek 2014-05-15 15:29 ` Jiri Kosina 2014-05-15 15:31 ` Daniel Vetter 2014-05-15 15:31 ` Daniel Vetter 2014-06-07 12:05 ` Pavel Machek 2014-06-07 12:06 ` Pavel Machek 2014-06-07 23:11 ` Pavel Machek 2014-06-07 23:11 ` Pavel Machek 2014-06-09 9:25 ` Daniel Vetter 2014-06-09 9:25 ` Daniel Vetter 2014-06-09 10:23 ` Pavel Machek 2014-06-09 10:23 ` Pavel Machek 2014-06-09 11:03 ` Jiri Kosina 2014-06-09 11:03 ` Jiri Kosina 2014-06-10 11:50 ` Bisecting the heisenbugs (was Re: 3.15-rc: regression in suspend) Pavel Machek 2014-06-10 11:50 ` Pavel Machek 2014-06-21 20:29 ` 3.16, i915: less colors in X? Pavel Machek 2014-06-21 20:29 ` Pavel Machek 2014-06-21 20:35 ` Pavel Machek 2014-06-21 21:06 ` Chris Wilson 2014-06-21 21:06 ` Chris Wilson 2014-06-22 14:26 ` Pavel Machek 2014-06-22 14:26 ` Pavel Machek 2014-06-22 15:11 ` regression: 3.16, i915: less colors in X?, caused by 773875bfb6737982903c42d1ee88cf60af80089c Pavel Machek 2014-06-21 21:16 ` 3.16, i915: less colors in X? Martin Steigerwald [not found] ` <7569_1403385738_53A5F78A_7569_14810_1_2527490.06bevSLs0l@merkaba> 2014-06-21 22:51 ` Thomas Richter 2014-06-22 10:02 ` Martin Steigerwald 2014-06-25 22:35 ` 3.15-rc: regression in suspend Pavel Machek 2014-06-25 22:35 ` Pavel Machek 2014-06-27 13:37 ` Jiri Kosina 2014-06-27 13:37 ` Jiri Kosina 2014-07-07 8:39 ` Daniel Vetter 2014-07-07 8:39 ` Daniel Vetter 2014-07-11 19:26 ` Pavel Machek 2014-07-11 23:33 ` Jiri Kosina 2014-07-11 23:33 ` Jiri Kosina 2014-08-07 12:47 ` Jiri Kosina 2014-08-07 12:47 ` Jiri Kosina 2014-08-07 12:54 ` Jiri Kosina [this message] 2014-08-07 12:54 ` Jiri Kosina 2014-08-07 14:36 ` [Intel-gfx] " Daniel Vetter 2014-08-07 14:36 ` Daniel Vetter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LNX.2.00.1408071453370.6219@pobox.suse.cz \ --to=jkosina@suse.cz \ --cc=chris@chris-wilson.co.uk \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@lists.osdl.org \ --cc=pavel@ucw.cz \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.